From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Nitin Gupta <ngupta@vflare.org>,
Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Subject: RE: [PATCH 1/2] staging: fix zcache building
Date: Sun, 24 Jul 2011 20:19:24 -0700 (PDT) [thread overview]
Message-ID: <a5d17beb-847b-48c0-82d7-cfabe419e7f9@default> (raw)
In-Reply-To: <1311556452-1859-1-git-send-email-cascardo@holoscopio.com>
> From: Thadeu Lima de Souza Cascardo [mailto:cascardo@holoscopio.com]
> Sent: Sunday, July 24, 2011 7:14 PM
> To: Nitin Gupta
> Cc: Dan Magenheimer; Greg Kroah-Hartman; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org;
> Thadeu Lima de Souza Cascardo
> Subject: [PATCH 1/2] staging: fix zcache building
>
> zcache is only building tmem.c and not building zcache.c. To keep the
> module name, zcache.c must be renamed if symbols from tmem.c are to
> remain unexported.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Greg --
Since a newer version of zcache.c is already in staging-next (and
hopefully soon in staging-for-linus for the 3.1 window), this
patch, which simply replaces the (older) zcache.c with identical
code with a different filename, would not apply cleanly. Could
you advise on the best way to ensure both the newer version
and the file rename are applied... perhaps the rename must be
done manually in your git tree(s)?
Though I'm not certain of the process steps, please consider the
rename, the one liner Makefile change for the rename, and the GPL
module license addition (in patch 2/2)...
Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
Thanks,
Dan
next prev parent reply other threads:[~2011-07-25 3:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 1:14 Thadeu Lima de Souza Cascardo
2011-07-25 1:14 ` [PATCH 2/2] zcache: module is GPL Thadeu Lima de Souza Cascardo
2011-07-25 3:19 ` Dan Magenheimer [this message]
2011-07-29 11:00 ` [PATCH 1/2] staging: fix zcache building Stratos Psomadakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5d17beb-847b-48c0-82d7-cfabe419e7f9@default \
--to=dan.magenheimer@oracle.com \
--cc=cascardo@holoscopio.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome