From: Joao Correia <joaomiguelcorreia@gmail.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: John Dykstra <john.dykstra1@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
akpm@linux-foundation.org,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH] Re: some tc commands fail on 2.6.29-rc6-git5, works on 2.6.28.7
Date: Thu, 5 Mar 2009 00:32:08 +0000 [thread overview]
Message-ID: <a5d9929e0903041632r56af217r3b6645d3d01c8ca5@mail.gmail.com> (raw)
In-Reply-To: <20090304233458.GA8303@ami.dom.local>
Hello
Confirmed working now on latest 2.6.29-rc6 git.
Thank you very much all for the prompt answer and solution, really impressive.
Back to work on the ultimate custom firewall *evil laugh*.
Cheers,
Joao Correia
Centro de Informatica
Universidade da Beira Interior
Portugal
On Wed, Mar 4, 2009 at 11:34 PM, Jarek Poplawski <jarkao2@gmail.com> wrote:
> On Tue, Mar 03, 2009 at 08:50:28PM -0600, John Dykstra wrote:
>> On Tue, 2009-03-03 at 23:10 +0000, Joao Correia wrote:
>> > I have confirmed again that the exact same commands (as on the
>> > original message), work flawlessly on 2.6.28.7 without a hitch, and,
>> > AFAIK, work as intended. I have also tried the latest 2.6.29-rc6-git7
>> > and it still fails like on git6.
>>
>> I have also reproduced this on Linus' latest 2.6.29-rc6 tree, using tc
>> version iproute2-ss071016 and a kernel config with all traffic control
>> features enabled.
>>
>> The error reported by tc comes from the kernel-level check added by:
>>
>> commit c1b56878fb68e9c14070939ea4537ad4db79ffae
>> Author: Stephen Hemminger <shemminger@vyatta.com>
>> Date: Tue Nov 25 21:14:06 2008 -0800
>>
>> tc: policing requires a rate estimator
>>
>> Found that while trying average rate policing, it was possible to
>> request average rate policing without a rate estimator. This results
>> in no policing which is harmless but incorrect.
>>
>> Since policing could be setup in two steps, need to check
>> in the kernel.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>> I got the same error when using the tc version iproute2-ss090115 built
>> this evening from the public git repository.
>>
>> -- John
>>
>
> Very nice diagnose, thanks!
> Jarek P.
>
> PS: after upgrading iproute I couldn't reproduce this seemingly OK
> test with older versions anymore...
>
> ------------------->
> pkt_sched: act_police: Fix a rate estimator test.
>
> A commit c1b56878fb68e9c14070939ea4537ad4db79ffae "tc: policing requires
> a rate estimator" introduced a test which invalidates previously working
> configs, based on examples from iproute2: doc/actions/actions-general.
> This is too rigorous: a rate estimator is needed only when police's
> "avrate" option is used.
>
> Reported-by: Joao Correia <joaomiguelcorreia@gmail.com>
> Diagnosed-by: John Dykstra <john.dykstra1@gmail.com>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
> ---
>
> net/sched/act_police.c | 13 ++++++-------
> 1 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/net/sched/act_police.c b/net/sched/act_police.c
> index 5c72a11..f8f047b 100644
> --- a/net/sched/act_police.c
> +++ b/net/sched/act_police.c
> @@ -183,13 +183,6 @@ override:
> if (R_tab == NULL)
> goto failure;
>
> - if (!est && (ret == ACT_P_CREATED ||
> - !gen_estimator_active(&police->tcf_bstats,
> - &police->tcf_rate_est))) {
> - err = -EINVAL;
> - goto failure;
> - }
> -
> if (parm->peakrate.rate) {
> P_tab = qdisc_get_rtab(&parm->peakrate,
> tb[TCA_POLICE_PEAKRATE]);
> @@ -205,6 +198,12 @@ override:
> &police->tcf_lock, est);
> if (err)
> goto failure_unlock;
> + } else if (tb[TCA_POLICE_AVRATE] &&
> + (ret == ACT_P_CREATED ||
> + !gen_estimator_active(&police->tcf_bstats,
> + &police->tcf_rate_est))) {
> + err = -EINVAL;
> + goto failure_unlock;
> }
>
> /* No failure allowed after this point */
>
next prev parent reply other threads:[~2009-03-05 0:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 0:36 Joao Correia
2009-03-02 0:57 ` Andrew Morton
2009-03-02 18:44 ` Jarek Poplawski
2009-03-03 23:10 ` Joao Correia
2009-03-04 0:06 ` Jarek Poplawski
2009-03-04 2:50 ` John Dykstra
2009-03-04 14:09 ` Joao Correia
2009-03-04 17:59 ` Denys Fedoryschenko
2009-03-04 23:34 ` [PATCH] " Jarek Poplawski
2009-03-05 0:32 ` Joao Correia [this message]
2009-03-05 1:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5d9929e0903041632r56af217r3b6645d3d01c8ca5@mail.gmail.com \
--to=joaomiguelcorreia@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jarkao2@gmail.com \
--cc=john.dykstra1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®