From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752142AbdKVXam (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Nov 2017 18:30:42 -0500
Received: from mga03.intel.com ([134.134.136.65]:51470 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751692AbdKVXal (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Nov 2017 18:30:41 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,438,1505804400"; 
   d="scan'208";a="152271572"
Subject: Re: [PATCH 09/30] x86, kaiser: only populate shadow page tables for
 userspace
To: Andy Lutomirski <luto@kernel.org>
References: <20171110193058.BECA7D88@viggo.jf.intel.com>
 <20171110193113.E35BC3BF@viggo.jf.intel.com>
 <alpine.DEB.2.20.1711202057581.2348@nanos>
 <7e458284-b334-bb70-a374-c65cc4ef9f02@linux.intel.com>
 <CALCETrXv3VxEdr1UOjWW9GTFTd_BoUCpThxOxz7a4-YC+d_i=Q@mail.gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>, moritz.lipp@iaik.tugraz.at,
        Daniel Gruss <daniel.gruss@iaik.tugraz.at>,
        michael.schwarz@iaik.tugraz.at, richard.fellner@student.tugraz.at,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Kees Cook <keescook@google.com>, Hugh Dickins <hughd@google.com>,
        X86 ML <x86@kernel.org>
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <a5dbe14a-b4f3-dc31-4622-70c2fe81ec82@linux.intel.com>
Date: Wed, 22 Nov 2017 15:30:37 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CALCETrXv3VxEdr1UOjWW9GTFTd_BoUCpThxOxz7a4-YC+d_i=Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/21/2017 07:44 PM, Andy Lutomirski wrote:
>> So, I guess we could enforce that only PGDs with _PAGE_USER set can ever
>> be cleared.  That has a nice symmetry to it because we set the shadow
>> when we see _PAGE_USER and we would then clear the shadow when we see
>> _PAGE_USER.
> Is this code path ever hit in any case other than tearing down an LDT?

Do you mean the PGD clearing?  We use it for tearing down userspace
PGDs, but that's it.