From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Karl Mehltretter <kmehltretter@gmail.com>,
Eduardo Valentin <edubezval@gmail.com>,
Keerthy <j-keerthy@ti.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: ti-soc-thermal: Fix the return value in ti_bandgap_get_sensor_data() kernel-doc
Date: Tue, 13 Oct 2026 11:33:43 +0200 [thread overview]
Message-ID: <a5e5a7a2-ba8e-4229-af4f-7479e7e8f37f@oss.qualcomm.com> (raw)
In-Reply-To: <20260912062252.42762-1-kmehltretter@gmail.com>
On 9/12/26 08:22, Karl Mehltretter wrote:
> ti_bandgap_get_sensor_data() returns an ERR_PTR() if the bandgap
> instance or sensor ID is invalid. Otherwise it returns the stored sensor
> data, which can be NULL if no data has been set or the stored value has
> been cleared.
>
> This mismatch was already present in omap_bandgap_get_sensor_data() when
> the driver was introduced in staging.
>
> Document the validation errors while retaining NULL as a possible stored
> value.
>
> Fixes: 8feaf0ce1a04 ("staging: OMAP4+: thermal: introduce bandgap temperature sensor")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
Applied, thanks
prev parent reply other threads:[~2026-10-13 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 6:22 Karl Mehltretter
2026-10-13 9:33 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5e5a7a2-ba8e-4229-af4f-7479e7e8f37f@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=daniel.lezcano@kernel.org \
--cc=edubezval@gmail.com \
--cc=j-keerthy@ti.com \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®