mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonas Karlman <jonas@kwiboo.se>
To: Heiko Stuebner <heiko@sntech.de>, Chukun Pan <amadeus@jmu.edu.cn>
Cc: "Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Uwe Kleine-König" <ukleinek@kernel.org>,
	"Yao Zi" <ziyao@disroot.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: (subset) [PATCH 0/2] arm64: dts: rockchip: Add pwm nodes for RK3528
Date: Wed, 12 Mar 2025 15:00:57 +0100	[thread overview]
Message-ID: <a5ec9062-ca57-4748-8c0f-fb5b9c75fa28@kwiboo.se> (raw)
In-Reply-To: <174176555637.249409.2785731072183565436.b4-ty@sntech.de>

Hi Heiko,

On 2025-03-12 08:45, Heiko Stuebner wrote:
> 
> On Fri, 07 Mar 2025 20:00:02 +0800, Chukun Pan wrote:
>> Add pwm nodes for RK3528. Most rk3528 boards use pwm-regulator to
>> supply to CPU, add node to enable them. The PWM core on RK3528 is
>> the same as RK3328, but the driver doesn't support interrupts yet.
>>
>> Unlike other SoCs, pinctrl-names need to be in "active" state,
>> I'm not sure about this, but otherwise the pwm-regulator will
>> not work properly.
>>
>> [...]
> 
> Applied, thanks!

The pinctrl-names should be changed to "default" and not "active",
something you can fixup or do you want a patch?

In commit 96d8d3253246 ("arm64: dts: rockchip: Fix PWM pinctrl names")
similar issue was corrected for current rockchip boards.

Regards,
Jonas

> 
> [2/2] arm64: dts: rockchip: Add pwm nodes for RK3528
>       commit: 2973d077aedfc114affab96c3b2c7286163cc8c9
> 
> Best regards,


  reply	other threads:[~2025-03-12 14:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 12:00 Chukun Pan
2025-03-07 12:00 ` [PATCH 1/2] dt-bindings: pwm: rockchip: Add rockchip,rk3528-pwm Chukun Pan
2025-03-07 15:35   ` Conor Dooley
2025-03-07 17:07   ` Uwe Kleine-König
2025-03-08 16:25     ` Heiko Stuebner
2025-03-09  0:24       ` Uwe Kleine-König
2025-03-07 12:00 ` [PATCH 2/2] arm64: dts: rockchip: Add pwm nodes for RK3528 Chukun Pan
2025-03-09 18:28   ` Jonas Karlman
2025-03-12  7:45 ` (subset) [PATCH 0/2] " Heiko Stuebner
2025-03-12 14:00   ` Jonas Karlman [this message]
2025-03-12 14:35     ` Chukun Pan
2025-03-12 15:00       ` Jonas Karlman
2025-03-12 19:38         ` Heiko Stuebner
2025-03-13  7:10           ` Chukun Pan
2025-03-13  8:22             ` Jonas Karlman
2025-03-13  9:01               ` Chukun Pan
2025-03-13 12:03                 ` Jonas Karlman
2025-03-13 13:01                   ` Chukun Pan
2025-03-14 15:40                   ` Chukun Pan
2025-03-13 22:14             ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5ec9062-ca57-4748-8c0f-fb5b9c75fa28@kwiboo.se \
    --to=jonas@kwiboo.se \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®