From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DABD97429E; Thu, 1 Feb 2024 18:35:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.249 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706812521; cv=none; b=KYlvudIptDNPcUspQ/aXUesJe71LIpIt4aM5c5GD0DnPWhfF3vgkwtpQ+rqVZkb6M4jklH302n8f71sb3o9AmN6dLG29h0RxwXAGs97lbk/1177A5Znv2WepTfPDplPS02J9QQARAohXo5zeNcR+/krUMmo/7KQsF8P/rvHa9jA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706812521; c=relaxed/simple; bh=RIkbALjZPSreUFXEN2IqnBWkCSRe05VWOl3KjcYVaaU=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=a78z5VhazPooAQ/7UtHH67llcRnftqV6vtlsg157WHQyEOMgLXxVafPvtgzBnFG4u9rjHNsKOf3cjKNrPtoiDFeo9uyhS1gO44PZYBuX/ZacnAaM9J6a8GH91xybSjy0mlbkPsCmdORqjg03sRCyEM9nRU3c5e4TPwqcZNw6Iqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=PMAzKlAa; arc=none smtp.client-ip=198.47.23.249 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="PMAzKlAa" Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 411IYvKu004605; Thu, 1 Feb 2024 12:34:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1706812497; bh=M8yVYusQsDMX27rn12ZXPGp6iti7X27Z6TtYkXc9Hlw=; h=Date:Subject:To:References:From:In-Reply-To; b=PMAzKlAavbNenLCMhUVCT04qGfGfCtUtkaJAbz3CnzyJTK5M6DaGeRi/HxRTYO/Du sZqkKHhAEazjsVBR+BUYw/PMmoTvA82U0N10Dz+kPZG29IqBrURfWHUfFfm5W41YPf cS7AIbVT3dbqx7HNOjjW76mZy4/IP7xRcL9p/SVM= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 411IYvRk070402 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 1 Feb 2024 12:34:57 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 1 Feb 2024 12:34:57 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Feb 2024 12:34:56 -0600 Received: from [10.249.42.149] ([10.249.42.149]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 411IYuU5031306; Thu, 1 Feb 2024 12:34:56 -0600 Message-ID: Date: Thu, 1 Feb 2024 12:34:56 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] arm64: dts: ti: k3-j784s4: Add Wave5 Video Encoder/Decoder Node Content-Language: en-US To: Brandon Brnich , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Bjorn Andersson , Geert Uytterhoeven , Arnd Bergmann , Konrad Dybcio , Neil Armstrong , =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Marek Szyprowski , , , , Darren Etheridge References: <20240131212625.1862775-1-b-brnich@ti.com> <20240131212625.1862775-2-b-brnich@ti.com> From: Andrew Davis In-Reply-To: <20240131212625.1862775-2-b-brnich@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 On 1/31/24 3:26 PM, Brandon Brnich wrote: > This patch adds support for the Wave521cl on the J784S4-evm. > > Signed-off-by: Brandon Brnich > --- > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 8 ++++++++ > arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 20 ++++++++++++++++++++ > arch/arm64/boot/dts/ti/k3-j784s4.dtsi | 2 ++ > 3 files changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > index f34b92acc56d..7d37c11b4df4 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts > @@ -784,6 +784,14 @@ &main_gpio0 { > status = "okay"; > }; > > +&vpu0 { > + status = "okay"; > +}; > + > +&vpu1 { > + status = "okay"; > +}; > + > &mcu_cpsw { > status = "okay"; > pinctrl-names = "default"; > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > index f2b720ed1e4f..8b2623ac8160 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi > @@ -662,6 +662,26 @@ main_i2c6: i2c@2060000 { > status = "disabled"; > }; > > + vpu0: video-codec@4210000 { > + compatible = "ti,j721s2-wave521c", "cnm,wave521c"; > + reg = <0x00 0x4210000 0x00 0x10000>; > + interrupts = ; > + clocks = <&k3_clks 241 2>; > + clock-names = "vcodec"; > + power-domains = <&k3_pds 241 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; Why are these default disabled? I don't see anything missing that would need to be added at the board level. You disable them just to re-enable them in the next patch. Leave these default enabled. > + }; > + > + vpu1: video-codec@4220000 { > + compatible = "ti,j721s2-wave521c", "cnm,wave521c"; > + reg = <0x00 0x4220000 0x00 0x10000>; > + interrupts = ; > + clocks = <&k3_clks 242 2>; > + clock-names = "vcodec"; > + power-domains = <&k3_pds 242 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > + }; > + > main_sdhci0: mmc@4f80000 { > compatible = "ti,j721e-sdhci-8bit"; > reg = <0x00 0x04f80000 0x00 0x1000>, > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4.dtsi > index 4398c3a463e1..93bb0cba1b48 100644 > --- a/arch/arm64/boot/dts/ti/k3-j784s4.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j784s4.dtsi > @@ -247,6 +247,8 @@ cbass_main: bus@100000 { > <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>, /* MAIN NAVSS */ > <0x41 0x00000000 0x41 0x00000000 0x01 0x00000000>, /* PCIe1 DAT1 */ > <0x4e 0x20000000 0x4e 0x20000000 0x00 0x00080000>, /* GPU */ > + <0x00 0x04210000 0x00 0x04210000 0x00 0x00010000>, /* VPU0 */ > + <0x00 0x04220000 0x00 0x04220000 0x00 0x00010000>, /* VPU1 */ Add these in sorted by memory address order. Andrew > > /* MCUSS_WKUP Range */ > <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>,