From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>, Corey Minyard <minyard@acm.org>
Cc: openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Andrew Jeffery <andrew@aj.id.au>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] ipmi: bt-bmc: Add ast2500 compatible string
Date: Wed, 22 Mar 2017 15:09:33 +0100 [thread overview]
Message-ID: <a5f74faa-e5a2-e13d-01f0-6ae732f07c80@kaod.org> (raw)
In-Reply-To: <20170322140112.2479-1-joel@jms.id.au>
On 03/22/2017 03:01 PM, Joel Stanley wrote:
> The ast2500 SoCs contain the same IPMI BT device.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 4 +++-
> drivers/char/ipmi/bt-bmc.c | 1 +
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> index 6f28969af9dc..028268fd99ee 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt
> @@ -6,7 +6,9 @@ perform in-band IPMI communication with their host.
>
> Required properties:
>
> -- compatible : should be "aspeed,ast2400-ibt-bmc"
> +- compatible : should be one of
> + "aspeed,ast2400-ibt-bmc"
> + "aspeed,ast2500-ibt-bmc"
> - reg: physical address and size of the registers
>
> Optional properties:
> diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
> index fc9e8891eae3..002907e6c7d9 100644
> --- a/drivers/char/ipmi/bt-bmc.c
> +++ b/drivers/char/ipmi/bt-bmc.c
> @@ -485,6 +485,7 @@ static int bt_bmc_remove(struct platform_device *pdev)
>
> static const struct of_device_id bt_bmc_match[] = {
> { .compatible = "aspeed,ast2400-ibt-bmc" },
> + { .compatible = "aspeed,ast2500-ibt-bmc" },
> { },
> };
>
>
next prev parent reply other threads:[~2017-03-22 15:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 14:01 Joel Stanley
2017-03-22 14:09 ` Cédric Le Goater [this message]
2017-03-29 1:22 ` Rob Herring
2017-03-29 2:16 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f74faa-e5a2-e13d-01f0-6ae732f07c80@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®