From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2F738B7B1 for ; Thu, 2 Apr 2026 09:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775121794; cv=none; b=mBuCaQ1uOh45lUbjJV/2ioV/VB8u59lVZB6HCW8Xaf7MnCAK00PBcYEhoJFAfwtNoyYcVOg7HypxOKO94Ke9jSpFTdTYl5MeY7DjBcQSMpDoSbyFWkN2hsPtMAIIzjHDF0BdZA6m/GJsEd4kLXmX/zEIKMosF/2RXAXn8+peRCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775121794; c=relaxed/simple; bh=q9j+367l79vYQecpLmaLpTtH+va4Wtpz6t3r4tF7vyk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KhapBmsmXzFovVUqOeI0z7jQ6PPjBCPkcowimyAvl5oa8Z/nCc7O6n1mno5i0JJ3BPOCJ890wwG23XCnE+OaOT4Tg93zbAiNqMD7xTBz9bF1V5iPITSofAIYlhlsFwSJeRSdaxqRqrq5HHq6PG47oeumVd5tja5ilSs7Z7EUs7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YWV/tnlY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RyB6PIU+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YWV/tnlY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RyB6PIU+" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6326lg1i4009757 for ; Thu, 2 Apr 2026 09:23:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CvBiLwxg7AThsdO3zDQ/KZkqwxu86EBPRQfQ963Utkc=; b=YWV/tnlYRJfUMLIy TtfMrPl/X9K4U9R2hhggX70fmeuj6hM48rj0ijQQ2B6Wq2K5SMtGijcEJukjAj8M lVuF/OIetpvHMnQ0Hhf5THmXOxvQE6nmf99mtqySBVKD/pKjmwDWU8mf/HPWEpob iHQ8f72tHMNybvcn9j6lfoA90SRSp2IjmvtxwO1Umz+udXJWJUMSsLebEr4V/NJI PmhSIlz+eEMHAdVOTSwqULAaAXwccXutUPY/gVS5gAY0skDcc3ja+dhCzK9TB647 FCPunDFOkpJ52jdlYZaq+NETM8ePB5ZHo/MRACM2yfTyScRzLX4G9cYSaCp+Dlxm 6aVKzw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d97e038xt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 09:23:09 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89f548d0872so2053566d6.3 for ; Thu, 02 Apr 2026 02:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775121789; x=1775726589; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CvBiLwxg7AThsdO3zDQ/KZkqwxu86EBPRQfQ963Utkc=; b=RyB6PIU+8Z75WmgIYMOW/t0EF/0/ulbziOBxFX5/0xI1AUFVEgZnUjurh0o+Nr2hjj 5zk4XHDvC1k51q4EzSZY/s4ehOsVd9vjZULZVWD3E8GxKJ4YcvKuxZuUK7uM2Zyl2z2/ dTpgXQQQqtoUZDYUhYWJ25x90z38ZVeYFAHlb6HxfPi7bjfI+oY6oifLFhVyF2uCzI8j Ym/FvKVRpVb3FoxK9THdF37BdtaCYuX6puCXlz+8fqVBY/D8ko7/NE7TGI+18PfITUMd uBoUiwZFqfRz9C+aNEtZOCe605I7xoDGkaeRtlxgtv/Nv4o4QfbVSlY1Jko+NpEHKH9G rHRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775121789; x=1775726589; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CvBiLwxg7AThsdO3zDQ/KZkqwxu86EBPRQfQ963Utkc=; b=EBk+HwX1MT85rnpscUetDVDWuu6d0s6xkr877qDO9R6EIi8l6kz6uARp21zwGHXN7J iuMFoZswaY6tqW9yqV0E/WTlH4UzFwMEf2KJuvOH5MGgCgyWg/W+JuD/gH/+nyEZkf/x blj9A1lkdZmbch+AW2yAgjs+vqZsStjTwcmbA/e1plyLjTMI7btrCu7WjSo0LTWnXI73 NMUWToncY52ho3AcRT398yRZtz3MBZPrZcah8/Uwx+bSpNMJP/thxdZJzgdlISaqdXCH k9vRsmM0PXSVu9IpyOhJVfWu5bwzzVeZprAdx6TVo5VyWosCcKfxkIKmHplB9wali6tv WChQ== X-Forwarded-Encrypted: i=1; AJvYcCWCXjp/IJaGogyjhnhL8T2ErqOJ0yVId7aWvMzZzwJ52iJ9WbHpe6GB/XZmPkUcBpWBeNieFut89q4yJKI=@vger.kernel.org X-Gm-Message-State: AOJu0YxSaCNdancXUWlm/yP49Fzn3gqm0vvGlBuQqSDIzTUn1SMAQDiy yiMMj+1VzwDmN+enGpXyqSsjKttQQaljGljMJSSuw6OyIXurs6JH8ERiluHqLosuFSmpCCOhgmt F0k9Ig1Dz/5W/+LUVTVi6n2CYSU6v/nbX304VniOj0PKYkT/vDSGYsNA5cy3Ev98uSFE= X-Gm-Gg: ATEYQzx0Aa9h1Q+qOotiMXcrqD+QgBhCuTLYJ71ys5wS+NbDA8gHN/ZD3UshlzHsNRJ CF4XBDkXDxDn89pwk7aVSK3BCeq7Hpq3R2z07ObIPCJ3BjEK6tMq68N8G2BnB8winybylabqOYz nbgDrYQd+DhqVi/ZTL6EYEcCDbvVE600z5ipQRDEiCVaMgpPr346Y17ldIbIGq9Qeq0mPnhXkoJ mg1reWGYfpICcoB89uqJTlrgjGyE5dKCUjui9T0QT5bjBnPJkK27+ghjKEQpr3qrcmMnoZ2Bp5r EcEIZbW8zZH7jcxGgoosCqcKYWMeK/qQ1zdremZvuPTJPa33Mp3wWoYUXkZkJbyvgo2MxRNqxJ3 fsnsD9cVsBkWKf8T9bCBKnDNcNgHbW+k7ml5X6JfPY7UukVm6ujf6Mp7zAQW16sE2cdz5zZHV8S ZKb2g= X-Received: by 2002:a05:622a:1818:b0:50b:8ccc:a41f with SMTP id d75a77b69052e-50d3bd5723bmr73354171cf.6.1775121789005; Thu, 02 Apr 2026 02:23:09 -0700 (PDT) X-Received: by 2002:a05:622a:1818:b0:50b:8ccc:a41f with SMTP id d75a77b69052e-50d3bd5723bmr73354031cf.6.1775121788564; Thu, 02 Apr 2026 02:23:08 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cec6cc4sm65225266b.32.2026.04.02.02.23.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 02:23:07 -0700 (PDT) Message-ID: Date: Thu, 2 Apr 2026 11:23:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sdm845-shift-axolotl: Enable sdcard To: david@ixit.cz, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dylan Van Assche Cc: linux-arm-msm@vger.kernel.org, Petr Hodina , Casey Connolly , Dmitry Baryshkov , Alexander Martinz , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20260401-axolotl-misc-p1-v2-0-f3af384bbb50@ixit.cz> <20260401-axolotl-misc-p1-v2-1-f3af384bbb50@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260401-axolotl-misc-p1-v2-1-f3af384bbb50@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=fdGgCkQF c=1 sm=1 tr=0 ts=69ce357e cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=Mtb5h6N5A-RCbQxWbuYA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: KhdPMES8EytTUtwb_1i2X9pjoLqFX8Ne X-Proofpoint-GUID: KhdPMES8EytTUtwb_1i2X9pjoLqFX8Ne X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA4MyBTYWx0ZWRfX1wF31uj5zx2/ L7BRLk+JJ6SvFexNJX7C4nqQZiIR8wFkgSoEYZv6aUKkHjqkqk7ZSMMkSY3ikjXKXjjxUWSpwmL e8BdUX5lepPfWgnvAYeIXTlF6b/l/V4Fbd4jVp+gsh7UrGjWFJNIIrRHdDn9i7LqRzfzEf6Cc8G XswxsSGNbnwPOambnhEWsUeJP6PcZHgvWAmkALfTFc5uM0N48tvrp6Z4CJhbuM+oFopUO6v4hcA GT9TUAjaMOhcLqT/2SjHkKYy7u8+XhcKY3sZWdJigjDkVboSsGcCENjv4IasnQ0zQlXY5gTgHUe MpE573IiQwB2v7VEm81+AmK19+7qRGiCF8tsRxCJY2vofHqoSARlQKHcSrEO6YyuZrbJrjqS271 swqdguK65UJfZiksEt5dy+VJ9KQmuJ/5/fOgFag7vX6f9fwRF+nmVRNTi3yGITU/jllHjDQczXV HGWAb4jL/IX5WZFW9Gg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020083 On 4/1/26 6:51 PM, David Heidelberg via B4 Relay wrote: > From: Casey Connolly > > The SHIFT6mq features an sdcard slot, add it. > > Signed-off-by: Casey Connolly > Signed-off-by: David Heidelberg > --- > arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 44 +++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > index 740eb22550724..c394350998c26 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts > @@ -600,6 +600,24 @@ &qupv3_id_1 { > status = "okay"; > }; > > +&sdhc_2 { > + status = "okay"; couple nits: Status should be last, although the file is all over the place > + > + pinctrl-names = "default"; > + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>; preferably in this order xxx xxx-names [...] > + sdc2_default_state: sdc2-default-state { > + clk-pins { > + pins = "sdc2_clk"; > + bias-disable; > + drive-strength = <16>; All other pin definitions in this file have the bias property below drive-strength (like the card_det_n node you're adding) other than that Reviewed-by: Konrad Dybcio Konrad