mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: akpm@linux-foundation.org, ardb@kernel.org, bp@alien8.de,
	dave.hansen@linux.intel.com, graf@amazon.com,
	guoweikang.kernel@gmail.com, henry.willard@oracle.com,
	hpa@zytor.com, jbohac@suse.cz, joel.granados@kernel.org,
	linux-kernel@vger.kernel.org, mingo@redhat.com, noodles@fb.com,
	paul.x.webb@oracle.com, rppt@kernel.org, sohil.mehta@intel.com,
	sourabhjain@linux.ibm.com, stable@vger.kernel.org,
	tglx@linutronix.de, x86@kernel.org, yifei.l.liu@oracle.com
Subject: Re: [PATCH v2 3/3] x86/kexec: Add a sanity check on previous kernel's ima kexec buffer
Date: Tue, 30 Dec 2025 18:45:02 -0500	[thread overview]
Message-ID: <a5fbf391731b04b5cea5aa2202f375986ea90991.camel@linux.ibm.com> (raw)
In-Reply-To: <20251229081523.622515-4-harshit.m.mogalapalli@oracle.com>

On Mon, 2025-12-29 at 00:15 -0800, Harshit Mogalapalli wrote:
> When the second-stage kernel is booted via kexec with a limiting command
> line such as "mem=<size>", the physical range that contains the carried
> over IMA measurement list may fall outside the truncated RAM leading to
> a kernel panic.
> 
>     BUG: unable to handle page fault for address: ffff97793ff47000
>     RIP: ima_restore_measurement_list+0xdc/0x45a
>     #PF: error_code(0x0000) – not-present page
> 
> Other architectures already validate the range with page_is_ram(), as
> done in commit cbf9c4b9617b ("of: check previous kernel's
> ima-kexec-buffer against memory bounds") do a similar check on x86.
> 
> Without carrying the measurement list across kexec, the attestation
> would fail.
> 
> Cc: stable@vger.kernel.org
> Fixes: b69a2afd5afc ("x86/kexec: Carry forward IMA measurement log on kexec")
> Reported-by: Paul Webb <paul.x.webb@oracle.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> V1-> V2: Added a line about carrying measure list across kexec based on
> suggestion from Mimi Zohar. Made use to the new generic helper
> [Suggestion from Borislav]

Thanks, Harshit.

Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>


      reply	other threads:[~2025-12-30 23:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-29  8:15 [PATCH v2 0/3] Address page fault in ima_restore_measurement_list() Harshit Mogalapalli
2025-12-29  8:15 ` [PATCH v2 1/3] ima: Add ima_validate_range() for previous kernel IMA buffer Harshit Mogalapalli
2025-12-30 20:35   ` Mimi Zohar
2025-12-31  5:59     ` Harshit Mogalapalli
2025-12-29  8:15 ` [PATCH v2 2/3] of/kexec: refactor ima_get_kexec_buffer() to use ima_validate_range() Harshit Mogalapalli
2025-12-30 23:45   ` Mimi Zohar
2025-12-29  8:15 ` [PATCH v2 3/3] x86/kexec: Add a sanity check on previous kernel's ima kexec buffer Harshit Mogalapalli
2025-12-30 23:45   ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5fbf391731b04b5cea5aa2202f375986ea90991.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=graf@amazon.com \
    --cc=guoweikang.kernel@gmail.com \
    --cc=harshit.m.mogalapalli@oracle.com \
    --cc=henry.willard@oracle.com \
    --cc=hpa@zytor.com \
    --cc=jbohac@suse.cz \
    --cc=joel.granados@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=noodles@fb.com \
    --cc=paul.x.webb@oracle.com \
    --cc=rppt@kernel.org \
    --cc=sohil.mehta@intel.com \
    --cc=sourabhjain@linux.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yifei.l.liu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®