From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D985F1E489 for ; Sun, 5 Jan 2025 03:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736046280; cv=none; b=bVB0uMTI8Dni4lqsmkvoAEn6uRyjJMOxT+hdtaJclK5ZkhDGptl0ssE6icpP7gJZ3n9NqmlOttjh0fyHrHAbMIXFsS1JD2G8jzfI7q8GZXOZFR+2iwHW4m9sfIAT9z5chi24SZSueD/99aswYXV1fnVjOOuhv/8IMJNXeJbtNEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736046280; c=relaxed/simple; bh=hd892KwPVoDKj6L3O0TAWNjNiGEbhmwOjdXoOj1Tbl0=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=AGXfwRR1RkYZQmoXjerzjaF/uL6TD+Y1Kyqoc8+uFPwhMECcZcc8aA7uYdYvsufizy4YuiWWlrITp9/4ujBwT7LLCMyfbyYlzkqF+M4LA2cleUVtq/mcqiWdeMappGEQbceHtjj7pRvvOt9GkIo2ZZ0NWI76J3XOjRroIVwrAjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=KZBwIk2S; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="KZBwIk2S" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-4678cce3d60so134134551cf.2 for ; Sat, 04 Jan 2025 19:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1736046278; x=1736651078; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=Z/ypkJniTy2sqyoish9hOsiaKAFlmo543f6O+rUVzGs=; b=KZBwIk2Sy2ppB72Re6JHFjKKsoAKVX/umSTsVx/vLpO0b7mBw6aXmQRrUGwzzqEdxx mHP6HRZ1CNEmX+X+Ui2vOR1cT0HYkskxMn+Wae8ZN/hJG56ScEcuRaJ2YRLYcRooBSZz aTVN4ZQo0mA+CIXXTn51g9heaIawdLW12B1qFC9JeroqMrKrUGIXm5Vc2OrpfqgrA1be Q0qE2+hw8pJ3LsbYBNd0jYk6MbWKWMJZN2isjX5UKdGdUBIgG75xfiJeDPdun3nTac3y Kfn1fppU9LScLB0s0fAg9Tg9Y7vrEe5gfDuJRzJb3AfqTN4Wa+44N964IOj8zkOFk+DA OBrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736046278; x=1736651078; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Z/ypkJniTy2sqyoish9hOsiaKAFlmo543f6O+rUVzGs=; b=bWYi3B8OJrFE4eFlNKxApS5csqC6uHVIukpa3x1f/SPVkneoH1Lvykfjmp97nwY2Wn 03WmId3tZvRBfloRmz5eO/wqxQSAS0z9OOJt6VllNiYXB4NjmXOQd+AYKh+nVMLo0gOt noqoJbD9Y2/w/76Ru+d8oz+0hrVV5aBaWjwkdB3TK1qi9HzErOPxuo2uDXJrE+onq22d 8u5J68J+yqEfl6nBeaOY/ehR4nkjZX7O/yba3CmmHnTYuEL/Sj/niCSd3yjXDpxj5Z3u Ry/Z1uws52BIdgZNXJcy+GxbG6kHXIihwoVCAJZu3khhY9Ge3X3GEQCG4AT6iiPLyE2w XzLA== X-Forwarded-Encrypted: i=1; AJvYcCX9qozsBMefxJBhE8fFhXurRErvPMdFljxgINrKxFqBdBuwMOcNJJEe7BykoXq7FpFMCfC8w8rXufQp6Cw=@vger.kernel.org X-Gm-Message-State: AOJu0YxIjCz3XE2SaowWCHXhx7CJjIHvF8VFlZ5QIVhV0ljeLmljytHQ Yd86rVeDo86ZiPYqoEd2d8OHJwdl4cIoIXuKIm91axMdiJKEgE+vKEQwRsN1JQ== X-Gm-Gg: ASbGncteJuXD2P9OUZZBOcMxt2Z/JoAXFbxLKV36u9+RSMiYRgjO/b212i8V3hR1UEh 8ev300MKSQA4tjKZonpJePofX8sjV95gz2yKQE4NT95RLsLgfGxlXn+qzkXk2Lk7mfVQsZBeu0p xyl1a+nJQkOku5o8olYq6BPdxc01+1zjAtTgJedtg7V90C9933GI9JSe6095gpGO4JkdiFKNBLR xYWdu68BBMFxO/eKpp+sGtFdzd5t11RbfKmrgHtUgtooh8G3R4= X-Google-Smtp-Source: AGHT+IHRKFmN9qbAXkzpX87dy3tF+Dit0bfAJ4XWTifWGarIFaNZroIWRSMyGGq4nY0LZqvSdLQhSA== X-Received: by 2002:a05:622a:11d6:b0:467:b625:b37f with SMTP id d75a77b69052e-46a4a9e2d94mr1094866931cf.56.1736046277895; Sat, 04 Jan 2025 19:04:37 -0800 (PST) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3eb16ca0sm161329711cf.65.2025.01.04.19.04.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 19:04:37 -0800 (PST) Date: Sat, 04 Jan 2025 22:04:37 -0500 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20250104_1133/pstg-lib:20250104_1133/pstg-pwork:20250104_1133 From: Paul Moore To: =?UTF-8?q?Christian=20G=C3=B6ttsche?= Cc: =?UTF-8?q?Christian=20G=C3=B6ttsche?= , James Morris , "Serge E. Hallyn" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 1/2] lsm: constify function parameters References: <20241125105926.47141-2-cgoettsche@seltendoof.de> In-Reply-To: <20241125105926.47141-2-cgoettsche@seltendoof.de> On Nov 25, 2024 =?UTF-8?q?Christian=20G=C3=B6ttsche?= wrote: > > The functions print_ipv4_addr() and print_ipv6_addr() are called with > string literals and do not modify these parameters internally. > > Reported by clang: > > security/lsm_audit.c:324:7: warning: passing 'const char[6]' to parameter of type 'char *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers] > 324 | "laddr", "lport"); > | ^~~~~~~ > security/lsm_audit.c:183:27: note: passing argument to parameter 'name1' here > 183 | __be16 port, char *name1, char *name2) > | ^ > > Signed-off-by: Christian Göttsche > --- > security/lsm_audit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Merged into lsm/dev, thanks. -- paul-moore.com