From: WGH <wgh@torlan.ru>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Mike Snitzer <snitzer@redhat.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
dm-devel@redhat.com, Ilya Dryomov <idryomov@gmail.com>,
Zdenek Kabelac <zkabelac@redhat.com>
Subject: Re: LVM snapshot broke between 4.14 and 4.16
Date: Sat, 4 Aug 2018 13:01:32 +0300 [thread overview]
Message-ID: <a5feeaa7-e043-3987-cf23-4090e3eeec4a@torlan.ru> (raw)
In-Reply-To: <CA+55aFzSM6qhZpM4CCpRNR_LWNCbLyRtQQ3hnPwnRrBdDkwWUw@mail.gmail.com>
On 08/03/2018 10:22 PM, Linus Torvalds wrote:
> And in fact, maybe the right thing to do is to not revert the original
> commit entirely, but instead just weaken it a lot. Turn the "you did a
> write request on a RO disk" into a WARN_ON_ONCE() instead of a hard
> error.
>
> Something like the attached patch.
>
> WGH, do you build your own kernels? Does this attached (untested)
> patch make things work for you? It should give a big warning, but let
> the old behavior through..
The patch works for me.
However, there's no text messsage in the kernel log, just a traceback. I
think that's because WARN_ONCE is supposed to take condition as a first
argument.
next prev parent reply other threads:[~2018-08-04 10:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 12:26 WGH
2018-08-02 13:31 ` Ilya Dryomov
2018-08-02 15:10 ` WGH
2018-08-02 16:41 ` Linus Torvalds
2018-08-02 18:18 ` Ilya Dryomov
2018-08-02 18:32 ` Linus Torvalds
2018-08-02 21:32 ` WGH
2018-08-02 21:39 ` WGH
2018-08-02 21:52 ` Linus Torvalds
2018-08-03 13:31 ` Mike Snitzer
2018-08-03 15:20 ` [dm-devel] " Theodore Y. Ts'o
2018-08-03 18:39 ` Mike Snitzer
2018-08-03 18:57 ` Linus Torvalds
2018-08-03 19:06 ` Mike Snitzer
2018-08-03 19:11 ` Linus Torvalds
2018-08-03 19:33 ` Mike Snitzer
2018-08-03 19:22 ` Linus Torvalds
2018-08-04 10:01 ` WGH [this message]
2018-08-04 17:04 ` Linus Torvalds
2018-08-04 18:19 ` Mike Snitzer
2018-08-04 20:29 ` WGH
[not found] ` <20180803195636.GA31444@agk-dp.fab.redhat.com>
[not found] ` <20180803200817.GB31444@agk-dp.fab.redhat.com>
2018-08-03 20:42 ` [dm-devel] " Linus Torvalds
2018-08-03 21:26 ` Alasdair G Kergon
2018-08-03 13:31 ` Zdenek Kabelac
2018-08-03 16:37 ` Linus Torvalds
2018-08-03 18:54 ` Mike Snitzer
2018-08-03 19:09 ` Linus Torvalds
2018-08-03 19:30 ` Mike Snitzer
2018-08-03 19:36 ` Linus Torvalds
2018-08-04 5:20 ` [dm-devel] " Theodore Y. Ts'o
2018-08-04 8:36 ` Zdenek Kabelac
2018-08-04 16:22 ` Theodore Y. Ts'o
2018-08-04 18:18 ` Mike Snitzer
2018-08-04 19:37 ` Theodore Y. Ts'o
2018-08-04 21:48 ` Mike Snitzer
2018-08-04 15:19 ` Mike Snitzer
2018-08-03 19:18 ` [dm-devel] " Zdenek Kabelac
2018-08-03 19:30 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5feeaa7-e043-3987-cf23-4090e3eeec4a@torlan.ru \
--to=wgh@torlan.ru \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=idryomov@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®