From: "Shah, Nehal-bakulchandra" <Nehal-Bakulchandra.shah@amd.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Daniel Kurtz <djkurtz@chromium.org>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Ken Xue <Ken.Xue@amd.com>
Cc: adurbin@chromium.org,
"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl/amd: poll InterruptEnable bits in enable_irq
Date: Wed, 28 Mar 2018 10:49:49 +0530 [thread overview]
Message-ID: <a5ff2e32-662d-1c34-2ab9-16d98ffe9390@amd.com> (raw)
In-Reply-To: <CACRpkdaXzf=2nap2oqU0z_sTQ7XaFJGBnuk0UBE7FfNpT8mAFA@mail.gmail.com>
Hi
On 3/26/2018 2:42 PM, Linus Walleij wrote:
> On Mon, Mar 12, 2018 at 5:45 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:
>
>> In certain cases interrupt enablement will be delayed relative to when
>> the InterruptEnable bits are written. One example of this is when
>> a GPIO's "debounce" logice is first enabled. After enabling debounce,
>> there is a 900 us "warm up" period during which InterruptEnable[0]
>> (bit 11) will read as 0 despite being written 1. During this time
>> InterruptSts will not be updated, nor will interrupts be delivered, even
>> if the GPIO's interrupt configuration has been written to the register.
>>
>> To work around this delay, poll the InterruptEnable bits after setting
>> them to ensure interrupts have truly been enabled in hardware before
>> returning from the irq_enable handler.
>>
>> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
>
> Patch applied.
>
> I see the AMD people were not on CC so adding them here so they can
> say if there is any problem with the approach.
>
> Daniel: maybe you should consider listing yourself as comaintainer of this
> driver?
>
> Yours,
> Linus Walleij
>
Looks good.
Regards
Nehal Shah
prev parent reply other threads:[~2018-03-28 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 16:45 Daniel Kurtz
2018-03-26 9:12 ` Linus Walleij
2018-03-28 5:19 ` Shah, Nehal-bakulchandra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ff2e32-662d-1c34-2ab9-16d98ffe9390@amd.com \
--to=nehal-bakulchandra.shah@amd.com \
--cc=Ken.Xue@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=adurbin@chromium.org \
--cc=djkurtz@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®