From: Qu Wenruo <wqu@suse.com>
To: Cheng Yongkang <teel4res@gmail.com>
Cc: David Sterba <dsterba@suse.com>, Chris Mason <mason@kernel.org>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] btrfs: tree-checker: reject file extents with oversized disk_num_bytes
Date: Tue, 17 Nov 2026 16:08:45 +1030 [thread overview]
Message-ID: <a6045455-5c90-4a79-85e8-06587f0b65db@suse.com> (raw)
In-Reply-To: <20261117045725.606165-1-teel4res@gmail.com>
在 2026/11/17 15:27, Cheng Yongkang 写道:
> On 2026/11/17 15:01, Qu Wenruo wrote:
>> I don't know which agent you're using, but I have seen several ones (not
>> only from you) doing this linking-to-older-versions behavior.
>>
>> It doesn't make much sense.
> [...]
>> And the full changelog would make more sense, other than letting the
>> reviewer to jump to your previous version for history.
>
> The links came from Documentation/process/submitting-patches.rst, which
> recommends adding lore links to previous versions after the "---" line.
> Its example also lists the changes of every version, though, and I only
> listed the v3 changes. That was my mistake.
>
> I'll follow the btrfs style from now on: the full changelog of all
> versions, without links to the older ones.
>
>> I think the ram bytes check should apply to both compressed and
>> uncompressed extents.
>>
>> For compressed, it's MAX_UNCOMPRESSED, and for uncompressed it's U32_MAX.
>
> Will do in v4, with max_ram_bytes picked the same way as
> max_disk_num_bytes.
And Sashiko has some reviews too:
https://sashiko.dev/#/patchset/20261117023841.467366-1-teel4res%40gmail.com
>
> Thanks,
> Cheng Yongkang
prev parent reply other threads:[~2026-11-17 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 2:38 Cheng Yongkang
2026-11-17 4:31 ` Qu Wenruo
2026-11-17 4:57 ` Cheng Yongkang
2026-11-17 5:38 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6045455-5c90-4a79-85e8-06587f0b65db@suse.com \
--to=wqu@suse.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@kernel.org \
--cc=teel4res@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®