From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 126421B7F7 for ; Tue, 16 Jan 2024 11:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="s0aFfV17" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6RK8HhUL7/mSLlRQcfu0FfBwVC2fqWvwSpORs6uHkzQ=; b=s0aFfV17JvR2ozhnpfGP5R2701 MqtQfq04Kn9eNo5CmFEYE6JLRGcextvHOveZ9/7kcn1NfSIlcBcK8KtaQKUf1Q5VKcrLc8O3ZRDt2 kmiLcGSE1XDVlMIaKLwhIgehEicZSZ7MZPQtWhtlvmfTpewH8d2mTIETlqME6nx8kZugNzZGm7269 rQMOTShleb/Xk2d7KRvMW3dDdHSWmt+bRRa7fV1rMnLp1hUG4Ihd7fbPobVEcJfxwuH3Dhx3EhqNC 3CP+0GBy4N8CliUiTmCabDjXGe1fhNvON1YjNlId8WBdMRQ9UqalvsBgEdwhd4yb68DDry1bpq8kj ChwaY3VQ==; Received: from [177.45.63.147] (helo=[192.168.1.111]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1rPhyF-006woJ-M6; Tue, 16 Jan 2024 12:51:07 +0100 Message-ID: Date: Tue, 16 Jan 2024 08:50:59 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] drm/atomic: Allow drivers to write their own plane check for async To: Pekka Paalanen Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, Simon Ser , daniel@ffwll.ch, Daniel Stone , =?UTF-8?B?J01hcmVrIE9sxaHDoWsn?= , Dave Airlie , ville.syrjala@linux.intel.com, Xaver Hugl References: <20240116045159.1015510-1-andrealmeid@igalia.com> <20240116114522.5b83d8b6@eldfell> Content-Language: en-US From: =?UTF-8?Q?Andr=C3=A9_Almeida?= In-Reply-To: <20240116114522.5b83d8b6@eldfell> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Pekka, Em 16/01/2024 06:45, Pekka Paalanen escreveu: > On Tue, 16 Jan 2024 01:51:57 -0300 > André Almeida wrote: > >> Hi, >> >> AMD hardware can do more on the async flip path than just the primary plane, so >> to lift up the current restrictions, this patchset allows drivers to write their >> own check for planes for async flips. > > Hi, > > what's the userspace story for this, how could userspace know it could do more? > What kind of userspace would take advantage of this and in what situations? > > Or is this not meant for generic userspace? Sorry, I forgot to document this. So the idea is that userspace will query what they can do here with DRM_MODE_ATOMIC_TEST_ONLY calls, instead of having capabilities for each prop. > > > Thanks, > pq > >> I'm not sure if adding something new to drm_plane_funcs is the right way to do, >> because if we want to expand the other object types (crtc, connector) we would >> need to add their own drm_XXX_funcs, so feedbacks are welcome! >> >> André >> >> André Almeida (2): >> drm/atomic: Allow drivers to write their own plane check for async >> flips >> drm/amdgpu: Implement check_async_props for planes >> >> .../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 30 +++++++++ >> drivers/gpu/drm/drm_atomic_uapi.c | 62 ++++++++++++++----- >> include/drm/drm_atomic_uapi.h | 12 ++++ >> include/drm/drm_plane.h | 5 ++ >> 4 files changed, 92 insertions(+), 17 deletions(-) >> >