mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aditya Kumar Singh <quic_adisi@quicinc.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] wifi: mac80211: re-order unassigning channel in activate links
Date: Thu, 5 Dec 2024 20:43:12 +0530	[thread overview]
Message-ID: <a60eb1a7-9739-4dbc-a683-417ac6d47adc@quicinc.com> (raw)
In-Reply-To: <d421f8067ea54bcfc38a9b021ebda13515145c45.camel@sipsolutions.net>

On 12/5/24 18:30, Johannes Berg wrote:
> On Thu, 2024-12-05 at 12:43 +0100, Johannes Berg wrote:
>>>
>>> Therefore, re-order the logic so that stations are handled first and then
>>> channel is unassigned.
>>>
>>
>> This causes memory leaks in my tests with iwlwifi.
>>
> 
> And also firmware crashes because the station is removed while it's
> still being used.
> 

So is this exposing some underlying issue with iwlwifi? Or this change 
will break drivers which does not group multiple hardware into single 
wiphy?

Also, how about non-ML scenario in iwlwifi? There, first station is 
removed and then the interface goes down right?

-- 
Aditya

  reply	other threads:[~2024-12-05 15:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 11:12 Aditya Kumar Singh
2024-12-05 11:43 ` Johannes Berg
2024-12-05 13:00   ` Johannes Berg
2024-12-05 15:13     ` Aditya Kumar Singh [this message]
2024-12-06 10:07       ` Johannes Berg
2024-12-09  5:12         ` Aditya Kumar Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a60eb1a7-9739-4dbc-a683-417ac6d47adc@quicinc.com \
    --to=quic_adisi@quicinc.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®