From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F422FD684 for ; Thu, 4 Dec 2025 09:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764838943; cv=none; b=EtxHhqocn6zKSrqHDWnFTshRAVmUo5HWih4Ufuj5WN5hHqOKdTmdh67O7MUCMzinXVCBrpsjuqKtDVos95vMsIpciwK3xbnKQeXjQvph9kRrRuQQ+nSR0q9k+MSy9sXXXAZbIEiwPD6PYh7+j/mf92LS+yXSExTyMBpV5shu85g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764838943; c=relaxed/simple; bh=KUJyn23st0EO5ZkU3NLsK2sjOM7AT9M6glu8bkKBxzo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KTo+hQVatm6p8Fwfk60BwKo/yamfzK26VOsWTJ4wAmXfTO18xkn/G92BAnb7GzXI2NlR5o2AObz8BR7CQZApuEgxSfgh+T0tCCo/IYrNneEeP8i6Xtmq8OwsU34hKLItdYKug6qErv1l7AiXlfDK/qy3g9XhImoy7WFO8Uteu/8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C4zsSmnl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RaQRV1HC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C4zsSmnl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RaQRV1HC" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B468sC8133283 for ; Thu, 4 Dec 2025 09:02:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mtgo4fM6ZCxfI0LXagFtoyQxIjtvK98di1Fn6M4ipAk=; b=C4zsSmnlmuvejCfZ EmYxMWG7XCn10vscZxrbJH1Lkibfk99zkyQ3eRtLBWJ7pu3l31CDEIZJaaojCDf3 Qu0Sp+SIc2JRVEo2bnLnoejPDcob54YgqvCWpbZ5nTHwLZAv9kQHDLzmqf0KirDo 0jtOawtTypbzVklwSiO8DTo9/H7JYFmcPOnkiOh3QfT18Smt1Z8K2IPtNUA6RW+t aqmWjlsNHd85W9URfp7Xnkw3u3cUMSIC2Ems0MRB+mE6xwfvKH4n0DO7l/k007c2 auwvdch+CFbIgZsF/XXafpHwjAeMmu0nHs10em6DwfXVDkOTf6S8W/DjXaIQ5cZs Zf3tVA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4atm0hujvc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Dec 2025 09:02:21 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee00f2b7d7so1883261cf.0 for ; Thu, 04 Dec 2025 01:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764838940; x=1765443740; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mtgo4fM6ZCxfI0LXagFtoyQxIjtvK98di1Fn6M4ipAk=; b=RaQRV1HCSVEHfAgSq/sT7jFtXqNrK9kK+spsBhqosI4ibaiuj2eUtd7sI/+Eo+nBQt DihO/acShTCj1n48rhqAmL6431XhtRo63Q4VvGzwjxRFXhKY1eegwByGhDA51o73nnyV dyuF5/GdaQMZmXpH3VxxMgOKhFzkk36pQRkRh96DY/jtW9x1UyGFE76dT9hIehA7I9wH FWnjjZ76WPff3lQbqzhd8bMo+ac+UVdPjCQo1DmS0kE5NOstJY3qMuUTjCUIK4ql44hz GN16nqRNXhWXfpIJ67G4edobxG3rIWk+yP4QmiJ7f5dgRx3m7binlOCts7loOKeJBc74 8rag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764838940; x=1765443740; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mtgo4fM6ZCxfI0LXagFtoyQxIjtvK98di1Fn6M4ipAk=; b=d3EViy9gBRH7XAzgjLggiJC05Vuz4hkwboQCJOy4USa4HM4YKrXVlqqBdy8AozUohV 70tjebZoiiD+t7vR2kMEXsJG0es5VafvnC888WBvb+hFA2zVeSKqEwRmFnYTEb13dAtb +fGouNwKrlH/4SjXXyy9GzdqxdOOuvu6b7UkPqcj9v2qrdzSvUbGzQZIpxO+sz27ZkWh YyFYC1ZPQcfPnKtF4C5i4rJiFMCTljNwxRAgEyz18hfetJuwNff+TSk1Lk6Y8Bwd1cVy 29W3bta62UTBlOLstnb5SaziheZKdbGnZvIQCTJ82DRAqCcEidyMG9pC2bJ1uislRrTG YglQ== X-Forwarded-Encrypted: i=1; AJvYcCWu8qGbEZCicmRJjCkkbSb+C7Ribnm4foGNNg2TTtp24Xwx5VZfwFmAqfL3nuIL7wbnm7rt6nyLGwkwlco=@vger.kernel.org X-Gm-Message-State: AOJu0YyHWKNXeIwIoH0xaAnINbLics61ZHANJHtIb2XyIrXNoq4MeN7y z5fhVJOyrgVX06kgOANuV2zL3VGbG15bx05lg9UmCtQqIbvWP4Tq1pagmEdJ03eRmEFyf+oVkv0 emYJ5mbsSosuciIDzPs8mdM5GV91DjW5JLAcbKsR4HF5dWxhCAQWVMFvlN+E2Mjf/8h0= X-Gm-Gg: ASbGncsb2N88awDSVR0ovwlhqpRTWbj6u1GrBY6kfUaExXaujGPD/n8pNJ6EdMiGTbT ftOu5na8QPnkfsN6BNzy+wyyP4jms6UVNzxjDjWxaYCR5+hu2z4HhGqgTJXG5fDL5QFxwdlnU8f cFx2MQCsCdx70XUcj2KrEMWiqwgySwJrGOMVSjjE8OHr7VCdd9av/j15Z4dW/q/2IEF0sh/9wim ZRYAm3zIo3hX0Y7hWX9Kg8Z6sbn2tW58syPZGotB81aO70u+S5j+JoHIstMbfsj0sjDbLhEEWpW ugOwnqtV0UAiAu8l3tYG1UzjLsdJ4FfSMXfswlAYd7r8h7HohgluPOGzuYvb2k4ZwM+vxpirSJk VZmQ6ptuQhyJIRrUswuw50pYVXZ1aAyhfwq3/UgJP0GXUROwJDUHA9n1+kkJQ5oMfUw== X-Received: by 2002:ac8:5f91:0:b0:4ee:1e33:bc45 with SMTP id d75a77b69052e-4f01b14c0e8mr44792711cf.5.1764838940520; Thu, 04 Dec 2025 01:02:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAwbsJMuv3MZvg5YXcOYqzTvFZ69X0CPQXgF4ehRC/ycYB7Z4fnwQVX2Sw7f8ML85GkecTyg== X-Received: by 2002:ac8:5f91:0:b0:4ee:1e33:bc45 with SMTP id d75a77b69052e-4f01b14c0e8mr44792361cf.5.1764838940015; Thu, 04 Dec 2025 01:02:20 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f4975b94sm75061166b.40.2025.12.04.01.02.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 01:02:19 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 10:02:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] arm64: dts: qcom: Add support for Surface Pro 11 To: =?UTF-8?Q?J=C3=A9r=C3=B4me_de_Bretagne?= Cc: Dale Whinham , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251201011457.17422-1-daleyo@gmail.com> <20251201011457.17422-5-daleyo@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: uTxcUQgR-jCtR7wXJou3EC_1JIEm3ScR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA0MDA3MyBTYWx0ZWRfX3WrN7BTyVVGA j6I+NvVtzR4NBn7bO3S2CZRVlEfQpqbxEW3HH4bbQk1FbcCaRS7bHdrEh5cU4KotOMw7GYhvK+D kY//7xYlMlhTcyzJJI5Pr1QeER1drcLNhYd8QF31n3TzYNCtQHUxDBMIlKBjg+YaB9VSaGUxqeA lLvTLAX5ERlTn8eX9dybRfa43wdmY44l3M5RCEKTeSO3MCy/pzsHCo1D7QYe2tzwQPk75SIAhre gy//DtmLSBfHWoqRSWs14GbNztg1n0GE8zUm4oIvYjV9FCuVczoFFF5yJAFMgs9DL14fCPJq1DQ 1HpXPYbM53uWz+pF1wyr29/wHN0oWNcKpRs3qt3QDyAC6nuVoh+p695O34j+AeGZdSBsQ5t6qPW 0ECTKhP1InO0nq7S9vukdSzt/DHtqQ== X-Proofpoint-GUID: uTxcUQgR-jCtR7wXJou3EC_1JIEm3ScR X-Authority-Analysis: v=2.4 cv=V5lwEOni c=1 sm=1 tr=0 ts=69314e1d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=zgDWnLXL3Kv1Vlv3_yAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_02,2025-12-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512040073 On 12/3/25 10:58 PM, Jérôme de Bretagne wrote: > Le mer. 3 déc. 2025 à 11:56, Konrad Dybcio > a écrit : >> >> On 12/2/25 7:50 PM, Jérôme de Bretagne wrote: >>> Hello, >>> >>> As discussed with Dale, I will take over the v3 submission since we've >>> worked on this patchset together until now. Here is my feedback below. >>> >>> Le lun. 1 déc. 2025 à 16:35, Konrad Dybcio >>> a écrit : >>>> >>>> On 12/1/25 2:14 AM, Dale Whinham wrote: >>>>> Add device trees for the Qualcomm X1E and X1P-based Microsoft Surface >>>>> Pro 11 machines (codenamed 'Denali'). >>>>> >>>>> This device is very similar to the Surface Laptop 7 ('Romulus'). >>>>> >>>>> Use a similar strategy to x1-asus-zenbook-a14.dtsi so that we can create >>>>> x1e and x1p-specific flavors of the device tree without too much code >>>>> duplication. >>>> >>>> [...] >>>> >>>>> + pinctrl-0 = <&hall_int_n_default>; >>>>> + pinctrl-names = "default";in v3 >>>>> + >>>>> + switch-lid { >>>>> + gpios = <&tlmm 2 GPIO_ACTIVE_LOW>; >>>>> + linux,input-type = ; >>>>> + linux,code = ; >>>> >>>> I.. don't think this device has a lid - what triggers this GPIO? >>> >>> When a Surface tablet is connected to a Surface keyboard, opening/closing >>> the keyboard triggers a wakeup/suspend event. I will double-check if this >>> entry is involved and will remove/keep it in v3 based on this check. >> >> If you have a magnet handy, you can run `evtest` as root and try waving it >> around the screen frame - it's presumably just a hall sensor > > After testing tonight, I can confirm that the switch-lid entry is required. Nice, thanks Konrad