From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1781A0BD6 for ; Sat, 22 Nov 2025 15:09:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763824177; cv=none; b=IXG35A90X3u8rLS4CZQ0ap285SZ0rDGN2vAH+lZo28n6TQ3hN+7npZ1fB/+6krCsc+PAjc0miJGyth2yXy9+qt9oBXWEOtqx5CVJoNILmRfpCvCB7aklyj4XRUMgB4dKRRI2Wv8oCv/qoI6VoDYiBdWuabK43Vpi3Oje9Jz3SGo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763824177; c=relaxed/simple; bh=bD6IiCa7MG1LDG3Vy/sVRmJM8FL0GK3kXQ8ix0ygN3g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bqe+s3KZ2zIsOLCYzJgWfvwomERr73lxyz625wKPgEswMQPwYkHk83m00XJpZud+sGCfJuxFX6T0SmgzjfcbCaPdSESvvzucGySjbeG4te7Y7y39b5fTLx/QAN1CGpD9R+ELMnRqNmiloHexwDRl3MpN2SFxbx47Q1boMOgJ1i4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=eUCMvaYY; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="eUCMvaYY" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-3e89a44007dso2207524fac.1 for ; Sat, 22 Nov 2025 07:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1763824174; x=1764428974; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XJ00G5DdHxmUWt9ADxO6Ey9yvGgI73+lh18WVqepTD4=; b=eUCMvaYYlDNGT02uOVYjeo0urVOipryLCetZu3yPMbqm15El+ya9j9wwqSuDn86VTj brO92kqLBeoTcBJhKd98Bqq3aD3D6NSQMXYEE4OLNyEemgVT6E/yDZiy3kxEWb8IwW9Y pXKa55iFVK7CfVWMY8tfdJ3ekeHw1SMZx8Sizq7UnTRpi0ZFj/rIkr4HNhJZ5ILyfBKC 15tU9EdSwQGyqls0j9+UUVJzAk28puLJWY9X7rQWknlYyTiEUjoFDNJp12hw7tPTV01h k/DmBQMRW7C6hI/KSVIpogrkyucwl0Btjn/dygS6Hw0Q2Lp1GlkLAqTSVAnEzC4iGvbD 5UyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763824174; x=1764428974; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XJ00G5DdHxmUWt9ADxO6Ey9yvGgI73+lh18WVqepTD4=; b=nzM/wM63mNTcIpSAjfmKk+c5McW0VD/7c3NYVDPl7XBi0xGHBhF1Tz8GqFxJjGNxbi 4R+CzdKglUYafsNUU5SMHbeUqXpdjAWvP09pGfAtOqLiflTsykKJnh7TTcLh/H1pgBH/ PVLnmnFYDQ1JqrKEeYt+DpNrxWWlQlMxnMk14PR1DOyO7y24a7VCdcPKr4dJMN6pCUaS sGEU2UMVthwZ9pozW3Ix5LXoZjI0d0JEt6bxeaMJek1UsQkKs/q8VhrYt80kjDPWXmYy OxfCJfzmsA0yNifZmAbIDkGO+2uuGlTkhHdp6MGl07Gldh5AnnS9btO6KKhEAfRBeF4/ JVpA== X-Forwarded-Encrypted: i=1; AJvYcCV+WG50HsNaTYXHScXOHlQvy6vMwXPFfUpFdGhWyLTk6QxDx4c2USaK4rRITDpk7P31m5YtyBntRvbP4Sk=@vger.kernel.org X-Gm-Message-State: AOJu0YwI+kbibs/r/Oyq9U9dxScFJLd80Fpwe2NR5P9WOsMGLU2KBMDv rp5lmx0hAQdlnqXYZ5h28oHxNoeUD49R9i5edPhf0AzMUvwMfghOyPGwDWr1Q/gL58Q= X-Gm-Gg: ASbGncurD9LDPiPKA+X/K+eV+IPNha1t1VrNUN4aSusL2byBod3V9hvZKM1qwgJWiF3 DxxsHRwrEbM2+lnmgF/tDxOLzRfznbRI/Y7mVfVboeLi21vVaYR2NVU/SC5h03IEXPvsRob3DVC ITuieRA9+1KUjmJaz1Z+RX5EDJmWedZWFPj8fh1FbuK0xy6FPuwCAeVZTkNF+yU0Qcjm0rALDJa Rh55tCpmVm48viZMHELahSPleXkqpxY+CbFKJOOYKq1X9eJbVmfcFOZ7HlX3hUqlOCvlCEddStc +t4STcBvBZO/P9dK1su1HbLhPuOnFSy6Fh6wtyAc6t9lTN5ERfHL3/H6U4CH8ylLMwqG9XDlCAB MLTFuYt2edX30UnUBl9yMwjRUb7sQWJZFCi4I8PXOcTFLmEndsp6yk8n0RX6/OUQrg4XN/VMxN1 x6sMX78Q6U5Hh0WqPqYPa1MP0LKW9G5FTCQ5Fbv0m4AEnrK29dJiMdp2SRo51a X-Google-Smtp-Source: AGHT+IEQOaRdqKonG9tlK9tE3Ji2R9zXetxeakG5C4CdmSrR6Ade+eh+1BwXwf4Y4MB7MZrKyrAlPg== X-Received: by 2002:a05:6870:4409:b0:3ec:64bf:ef5 with SMTP id 586e51a60fabf-3ecbbe84eaemr2904401fac.27.1763824173974; Sat, 22 Nov 2025 07:09:33 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:e782:93d8:7c2f:f9df? ([2600:8803:e7e4:500:e782:93d8:7c2f:f9df]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3ec9dc88896sm4056963fac.15.2025.11.22.07.09.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Nov 2025 07:09:32 -0800 (PST) Message-ID: Date: Sat, 22 Nov 2025 09:09:29 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add TI ADS1018/ADS1118 To: Krzysztof Kozlowski , Kurt Borja , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tobias Sperling Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron References: <20251121-ads1x18-v1-0-86db080fc9a4@gmail.com> <20251121-ads1x18-v1-1-86db080fc9a4@gmail.com> <32e76bff-f535-40ce-88e2-7bbf7da87620@kernel.org> <2676d37e-fe3c-4504-8990-fbee0ce8407a@baylibre.com> <6ec98294-82b1-4d3e-a7b6-95cb1d65f206@kernel.org> Content-Language: en-US From: David Lechner In-Reply-To: <6ec98294-82b1-4d3e-a7b6-95cb1d65f206@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/22/25 3:34 AM, Krzysztof Kozlowski wrote: > On 21/11/2025 23:40, David Lechner wrote: >> On 11/21/25 2:56 PM, Kurt Borja wrote: >>> Hi Krzysztof, >>> >>> On Fri Nov 21, 2025 at 2:10 PM -05, Krzysztof Kozlowski wrote: >>>> On 21/11/2025 18:16, Kurt Borja wrote: >>>>> Add documentation for Texas Instruments ADS1018 and ADS1118 >>>>> analog-to-digital converters. >>>>> >>>>> Signed-off-by: Kurt Borja >>>> >>>> You did not test it before sending, so no full review but few nits to >>>> save you one round of reviews: >>> >>> My bad! I will fix the errors. Thanks! >>> >> >> ... >> >>>>> + interrupts: >>>>> + description: DOUT/DRDY (Data Out/Data Ready) line. >>>>> + maxitems: 1 >>>>> + >>>>> + drdy-gpios: >>>>> + description: >>>>> + Extra GPIO line connected to DOUT/DRDY (Data Out/Data Ready). This allows >>>>> + distinguishing between latched and real DRDY IRQs. >>>> >>>> I have feeling that you miss proper handling of IRQs (e.g. active level) >>>> on your board. >>> >>> Can you elaborate? Should I specify active level here? >>> >>>> >> The problem is not about the levels. It is rather that the behavior of the >> interrupt when disabled/masked is different on different interrupt controllers. >> >> On some controllers, if an event happens while disabled/masked, it "remembers" >> that and will trigger the interrupt as soon as it is enabled even if the >> condition doesn't exist anymore. Not a great hardware design IMHO, but there >> is real hardware that does this. > > Isn't it misconfiguration of trigger as I said before? It should be for > example edge, instead of level? > > Best regards, > Krzysztof No. It it still works like this for edge triggers.