From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546E5C43332 for ; Wed, 20 Jan 2021 12:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 274872332B for ; Wed, 20 Jan 2021 12:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388022AbhATLmm (ORCPT ); Wed, 20 Jan 2021 06:42:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44120 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389028AbhATLPu (ORCPT ); Wed, 20 Jan 2021 06:15:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611141263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/EVI+1MCqEvTLfz42IzqWVQkkuhCL254qM17MstwaY=; b=V6BNRVa6de70OXBlYqVn3X86Uz1yRnmx8Yeiqi8pbEzugSn/DoSCStn9AY4X3Bc0XcTMmB 5NU1RD7zivgAcmE1zSR6QON2EYFF25EowkfOipOaD6L+Vyq+xXj7UxG2pBvUfb3A/9JbQR ebspVUc8TT2rpXilokB6s36Ds4LLusw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-G7gZTGtOOB2URGV0p1tCAg-1; Wed, 20 Jan 2021 06:14:21 -0500 X-MC-Unique: G7gZTGtOOB2URGV0p1tCAg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B17F01800D41; Wed, 20 Jan 2021 11:14:20 +0000 (UTC) Received: from [10.36.115.161] (ovpn-115-161.ams2.redhat.com [10.36.115.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9967A10023B2; Wed, 20 Jan 2021 11:14:15 +0000 (UTC) Subject: Re: [PATCH] virtio-mem: Assign boolean values to a bool variable To: "Michael S. Tsirkin" Cc: Jiapeng Zhong , jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Tian Tao References: <1611129031-82818-1-git-send-email-abaci-bugfix@linux.alibaba.com> <81a1817d-a1f5-dfca-550c-3e3f62cf3a9d@redhat.com> <20210120045736-mutt-send-email-mst@kernel.org> <20210120060301-mutt-send-email-mst@kernel.org> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Wed, 20 Jan 2021 12:14:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210120060301-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.01.21 12:03, Michael S. Tsirkin wrote: > On Wed, Jan 20, 2021 at 11:04:18AM +0100, David Hildenbrand wrote: >> On 20.01.21 10:57, Michael S. Tsirkin wrote: >>> On Wed, Jan 20, 2021 at 10:40:37AM +0100, David Hildenbrand wrote: >>>> On 20.01.21 08:50, Jiapeng Zhong wrote: >>>>> Fix the following coccicheck warnings: >>>>> >>>>> ./drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment >>>>> of 0/1 to bool variable. >>>>> >>>>> Reported-by: Abaci Robot >>>>> Signed-off-by: Jiapeng Zhong >>>>> --- >>>>> drivers/virtio/virtio_mem.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c >>>>> index 9fc9ec4..85a272c 100644 >>>>> --- a/drivers/virtio/virtio_mem.c >>>>> +++ b/drivers/virtio/virtio_mem.c >>>>> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev) >>>>> * actually in use (e.g., trying to reload the driver). >>>>> */ >>>>> if (vm->plugged_size) { >>>>> - vm->unplug_all_required = 1; >>>>> + vm->unplug_all_required = true; >>>>> dev_info(&vm->vdev->dev, "unplugging all memory is required\n"); >>>>> } >>>>> >>>>> >>>> >>>> Hi, >>>> >>>> we already had a fix on the list for quite a while: >>>> >>>> https://lkml.kernel.org/r/1609233239-60313-1-git-send-email-tiantao6@hisilicon.com >>> >>> Can't find that one. >> >> Looks like it was only on virtualization@ and a couple of people on cc. >> >> https://lists.linuxfoundation.org/pipermail/virtualization/2020-December/051662.html >> >> Interestingly, I cannot find the follow-up ("[PATCH] virtio-mem: use >> boolean value when setting vm->unplug_all_required") in the mailing list >> archives, even though it has virtualization@ on cc. > > > Unsurprising that I didn't merge it then ;) Well, you were on cc ;) > Want to send your ack on this one? Sure Acked-by: David Hildenbrand -- Thanks, David / dhildenb