From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66E9439E180 for ; Tue, 3 Feb 2026 13:35:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770125738; cv=none; b=dCZELbSSKlsupjsnVIJw2avDP1lvN1DtJlF5HoEs0jHifBPk+8hct/ivur1T5Te1fNtYoczDQyIR+NZ/bHqAWoHAEddtcP0FcE+sYH767YQX5uwz2F4WySHmacJ1lnSKIkY6GBv78/6/52uY+Pv6C+Os6WMKlkId8EgXrYGg5VI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770125738; c=relaxed/simple; bh=yhkPRi0ykYv+/r6lZRFmlj13ldSW6PPkSFHE4XNFCw4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NLDiJjRigXZRl3G9kyS2n9HGgKWxb/nUHQT0pqZv3ejNz3Az8Lulh9Mhxw4gAYgJ+tp+KodkEIguVN0MCtIcOmeOQxid/gTm91dceVyNoI97Q5RbtLR2nliCeNtqpOodUDkCejjVxgR7oQgDfbX36B3RVWQjISwHA04O2qSOq+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F1X4xgzf; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CZ8o1RmR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F1X4xgzf"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CZ8o1RmR" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6139vfB23386990 for ; Tue, 3 Feb 2026 13:35:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hJLSOlCwUoSC3zdBMUZ/I2OvP6LPIYSpZBcnJOK9LSc=; b=F1X4xgzfCqVUpMMw FRtiUiHWxSNr45rvSIlaCSLWroD3NQNZ+JlprQWsvskqibLreC7pMaGHxS9fI5CF opBgesQsC/Wby75TkJBphc2eWR2tvl3dx12lzTQ+upb/4GJxGywyhc7d6xYnokzM lxCI9dwqbek0BBk5NSozDg7jgVmqZKJKqx69hq42DTrp2ubGcag4iqXvszZdJ271 BKOB05XL0uDtRADAU08MkImOMXPbH5IJH/AxTYheJwFSqS1T63ldSsp9M39s1WCg zOk7uZh3kZqG/t2XydueSSZWeJPdxfMetudK6DQkveTjagTVkmmn81S4xYCrb3F4 wg1IKA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2xvbum83-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 13:35:36 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c6d6b0f193so103387785a.1 for ; Tue, 03 Feb 2026 05:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770125735; x=1770730535; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hJLSOlCwUoSC3zdBMUZ/I2OvP6LPIYSpZBcnJOK9LSc=; b=CZ8o1RmRPQ2faiOQdtiI3EuOvLZKBHwW1lA4h7DWQXesJLi7vsIb0QmITnEM2fDp7Y suhV4WkQSFEsN7SiuVuNEY7iQiFrTtnDZHvIiDPAxId/iMmLP5y6Nm0i0e8xm45LljJe czZJoEG6ii2wHHSIc/xgNcpLInInX1HcBnmAG81mHUWvzX9pjxjtK9wHs9dEgt2k0kZq eP1rAzEDOZ2ftZHkj3Tkn1bizEwGIqFiyZ9eesDPgokcW4HhHUmQMzx+6jRmgK4ewEbF KO9rzs3C8wBvHlGI0wGUQYebnVPkx6FK3Ha7Dofw8fMRDMuzHkkAF+IJ2GiwJZQUjhub xxvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770125735; x=1770730535; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hJLSOlCwUoSC3zdBMUZ/I2OvP6LPIYSpZBcnJOK9LSc=; b=TXF+dqt8j2HKAun64SRW70rxJGFvXonGeAncn6tkswrXQ2GpU7MDqQ0qBkDMQX/QK5 8CtS9ypOGcfUoCOTYTbuD3SxaKwZkkq8sPnj6NBXk6UYflvG3i87kX4JGmjbF/sX89PH 4jNt6hUu/fj7f0l2DsusQ9ybNfXVQKnJAJPWZBiCzKhyXIbn0nqOKbWXaZB8u0neN6TB 85ePXoWsp3S4/2PDS9IHqzPnAUj/vGFlp0cIj5fBS/F6NoujI7Y96SYVm5TYNgMWyRUB mhXE4ENyZ6t68D7RopqQYaJnTYqUJym8YOm/jkNo5FJxaTC5UAiGLnfVIX4Smd84/0ri 2N4Q== X-Forwarded-Encrypted: i=1; AJvYcCXorCSuQSl52eMVfhwh7Zl/GGKVJaYP37g41Rn/LB/cbwgonyEQ5MdyKEBcDlisqKaHUIwOIdhyXSX0Ig0=@vger.kernel.org X-Gm-Message-State: AOJu0YwxlLh7nHRMKb2ODq+yIzX+GnyEEUyRBBDiFAKFMHoO8LWAE0DN mfolzhF26gngT16Ad5xn9sqOzNIbKfUJ38I+xqP3IocwUs06gTHOhxHxosDUElmGER3gAWK0akK FRr9mIQRJLyyaojWihaCS8MXlpRutG/4wWnscghHDzHW0PLGehVRRSJsblVNICtKM7vIA7PPFCG g= X-Gm-Gg: AZuq6aLq7nnZY7Ez0TLRCG3AltuJ2UXP1JfqciGzTmR0xWU3h19M6PcpypwbZW1DDgD jaE3Ep9rQ0uh9oeat6Cr3pPRep0bUcq1UhM06ZmN+o9vaYjmiGWWjCHExQbhoiKR9oYlUSAKQAM x/UzFDpELhq5sbzsMNPialkSlTNK1P45fZ7RIRtyfBW8Udngjfn6FMyTnZ4pktQXw2DLOiIuiIS fmWxKuxCYnJQKHjMhPED9nXNzTD6n/jDnv/vr25bKZXOPpXweQzCiDy73hf/We+1TObp2wxA6vu t0Q+jznMLQbRybOk5Lz0O5E9PrrucZW/hkMPGNQmZmYC5e2OTce+yYrbbWx13erPp6MtkL/qGXP xRhCfSNV/ZjhcdV//dG/xoQra74NIwHKglkRfSS9xcIDRUKz1/FUw1jrB/9J5jeYW2Bw= X-Received: by 2002:a05:620a:4141:b0:8a3:d644:6930 with SMTP id af79cd13be357-8c9eb2b920amr1467181885a.5.1770125735225; Tue, 03 Feb 2026 05:35:35 -0800 (PST) X-Received: by 2002:a05:620a:4141:b0:8a3:d644:6930 with SMTP id af79cd13be357-8c9eb2b920amr1467179585a.5.1770125734777; Tue, 03 Feb 2026 05:35:34 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbefc56e8sm1036415766b.15.2026.02.03.05.35.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 05:35:33 -0800 (PST) Message-ID: Date: Tue, 3 Feb 2026 14:35:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/9] dt-bindings: soc: qcom: eud: Restructure to model multi-path hardware To: Elson Serrao , Greg Kroah-Hartman , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260126233830.2193816-1-elson.serrao@oss.qualcomm.com> <20260126233830.2193816-2-elson.serrao@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260126233830.2193816-2-elson.serrao@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 8a-LfJaTYXjqKWCjOqbSRmoWlGVIqL-D X-Proofpoint-ORIG-GUID: 8a-LfJaTYXjqKWCjOqbSRmoWlGVIqL-D X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDEwOCBTYWx0ZWRfX/HCTD5HXR0BB D7uaKzDf0rzQ/3GBHcDVVdWo48zXpv1nqJtrK5hcU5SnwflVaPt+SZ4cIU34W+JoOQg4bbEjs3e W1KiN/9gVrJWx7BvH8XsgExPbJamzruYNfuEEIo10uBjBrbzKdsIK6hN3NFWQ97jV0IRMXx1xXo 18sMZ1TyfFQvtMZgz/j53FAb1PmTEumf4ZvEwi69mcZBQFVduNG4XMzaFOWiuX/rmEBDvX7626l 42k6WlIRHMLblmRDFOberH25fWALPBeAivPftAAXZ7TCRZHSpSbrvPaM5kBG7WkFT27EUyc70u8 khBn28wzBIe8A0wplid7suav2NFmyHuCNcvWDu6lINyHk4v93/nrhCBh4ujLQqD3U+0npABvnbV DAwD75n8mzjONTVtOA5oKJ6cVb7z6q9jX7T71OGejLBqkqVU00fsR0vsDdfSB8iNxy/pzBxv45H iaxiHOo0g+4oZ2/C6tg== X-Authority-Analysis: v=2.4 cv=AurjHe9P c=1 sm=1 tr=0 ts=6981f9a8 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=JfHo2pUdUrpnrbDD1w4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_04,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030108 On 1/27/26 12:38 AM, Elson Serrao wrote: > The Qualcomm Embedded USB Debugger (EUD) can intercept one or two > independent High-Speed UTMI paths, depending on the SoC. Each path is > distinct with its own HS-PHY interface, connector/controller wiring, and > UTMI routing behavior. The EUD hardware sits between the USB2 PHY and > the USB controller on each path. > > The existing binding models only a single UTMI path and does not provide > a way to associate the required High-Speed USB PHY. EUD relies on the > HS-PHY on the selected UTMI path for link signalling and correct operation > of the hardware. > > Historically, EUD has worked on platforms that use a single UTMI path > because the USB controller maintains ownership of the PHY during > enumeration and normal operation. This implicit relationship allowed > EUD to function even though the dependency on the PHY was not described > in the binding. However, this behavior is not guaranteed by hardware. > The current binding description is not sufficient for SoCs that expose > two independent UTMI paths, where the PHY association and port wiring > must be explicitly described. > > Introduce per-path eud-path child nodes so each UTMI path can describe > its HS-PHY, port connections, and the role‑switching capability of its > associated USB port. > > Signed-off-by: Elson Serrao > --- [...] > +patternProperties: > + "^eud-path@[0-1]$": I can't quite put it into words why I don't like this name, but I don't like this name.. That said I don't really have any clever ideas for a better one, so I'm not going to object, suppose I just needed to vent my ramblings > + type: object > description: > - These ports is to be attached to the endpoint of the DWC3 controller node > - and type C connector node. The controller has the "usb-role-switch" > - property. > + Represents one High-Speed UTMI path that EUD intercepts. This node models > + the physical data path intercepted by EUD and provides graph endpoints to > + link the USB controller and the external connector associated with this path. > > properties: > - port@0: > - $ref: /schemas/graph.yaml#/properties/port > - description: This port is to be attached to the DWC3 controller. > + reg: > + maxItems: 1 > + description: Path number > + > + phys: > + maxItems: 1 > + description: High-Speed USB PHY associated with this data path. > + > + usb-role-switch: > + type: boolean > + description: > + Set this property if the USB port on this path is role switch capable. This doesn't quite sound right. The EUD acts/can act as a rolesw no matter what's connected to it. > + In device role, debug mode inserts the EUD hub into the UTMI path. In > + host role, the EUD hub is bypassed and UTMI traffic flows directly > + between the PHY and the USB controller. The rest of this paragraph is good stuff, explaining the reasoning > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: > + These ports are to be attached to the endpoint of the USB controller node > + and USB connector node. > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: This port is to be attached to the USB controller. > > - port@1: > - $ref: /schemas/graph.yaml#/properties/port > - description: This port is to be attached to the type C connector. nit: "Type-C" Konrad