From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58407C43461 for ; Mon, 7 Sep 2020 15:25:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1359F2078E for ; Mon, 7 Sep 2020 15:25:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="l3gYcQrw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730040AbgIGPWc (ORCPT ); Mon, 7 Sep 2020 11:22:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730151AbgIGPRI (ORCPT ); Mon, 7 Sep 2020 11:17:08 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D64BC061756 for ; Mon, 7 Sep 2020 08:07:36 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id c8so13101137edv.5 for ; Mon, 07 Sep 2020 08:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BsqSCPCPiaLJ8Go+KX+dmTuaOJyEKP9pJrk437CGKxg=; b=l3gYcQrwwdOR9fijZnyUEmRnV41Jn1GPXnCDbFgLE3/DycIWBY+5xj64K+P4kaRsS/ jWcZgNfSWwU8vJc22qhfcZOz9MyrpKUMuSIf9Ab+agdioBrleVzplVKE38nLSY5cBUX1 ucE+0iOfFSSJCPm8cPHdOGfAEHGc6PTo2aks7VEfJc3QFzqYJEKBjF6QHscBNiJWDZFL yro4UN8yf3Q34nB4re9cCV6hQxXMtz9ndNbsnZ3Ynh5pQZXM9ySv7MuphzR07H6p9bMn FtQUT68lqjxh7HJ0iD4WVyQAd/X2+uiq9CM4zPbJCnZXBEPp0n3sfqRnrw0ggdAGClnB VzNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BsqSCPCPiaLJ8Go+KX+dmTuaOJyEKP9pJrk437CGKxg=; b=GDu1HBdMBQe5HHUBvKH+ViX7XY9B0pZvTKuGV1P9VuO8mOqxHJqUeFt2z3AIunIXrb ZwV4NbHXLevuwbu2W0+q5G1Djx6YFKhw6eyrd5wqcsVld3nCSPMYZEWVvJSilK3SX56c rXlhZ5vZSMvotp6FSJFq3rMtPF3ew4ogKgv5niBBxV8+vSMRyS5Sdf56bN+8vwTL8hRh 2mpxMh+sZqcuzR3ITDMoqEAixIAWIbS/JxwNdvHDJIfGw51nKTfVaxW1h092xmfZE6co TcwlNYEGTNeKzEhBnUEF0sTyOuSEIzEWEgUVfsyUNVnXCckQgnk+oxK7M9ZqzCGVjHtL +7OA== X-Gm-Message-State: AOAM532LsPqeda/P8l53OtjMEKh+QGSKifIs3S59JhZstvvWnyD6hLjm OfKIWn0f/6XxzaLKtdag/YFDaEXSjRkkog== X-Google-Smtp-Source: ABdhPJz4KjCatnUJFTsRS8yPpcGqriKrL3EhPhWrN7yE7V6S7tBAHkHGZ5mzppwc0wjk5DI/rOsxiQ== X-Received: by 2002:aa7:d15a:: with SMTP id r26mr22499081edo.181.1599491254960; Mon, 07 Sep 2020 08:07:34 -0700 (PDT) Received: from tsr-lap-08.nix.tessares.net ([2a02:578:85b0:e00:8ddf:bedd:580e:7a7e]) by smtp.gmail.com with ESMTPSA id o11sm15104926edw.80.2020.09.07.08.07.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Sep 2020 08:07:34 -0700 (PDT) Subject: Re: [MPTCP][PATCH net 2/2] mptcp: fix subflow's remote_id issues To: Geliang Tang Cc: Mat Martineau , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org References: <7187516ee5a9f17a7bf1e4aa9a849da2dd56a734.1599474422.git.geliangtang@gmail.com> From: Matthieu Baerts Message-ID: Date: Mon, 7 Sep 2020 17:07:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <7187516ee5a9f17a7bf1e4aa9a849da2dd56a734.1599474422.git.geliangtang@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geliang, On 07/09/2020 12:29, Geliang Tang wrote: > This patch set the init remote_id to zero, otherwise it will be a random > number. > > Then it added the missing subflow's remote_id setting code both in > __mptcp_subflow_connect and in subflow_ulp_clone. Thank you for this other patch! Here as well, may you add a "Fixes:" tag please? (...) > diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c > index dc2c57860d2d..255695221309 100644 > --- a/net/mptcp/pm_netlink.c > +++ b/net/mptcp/pm_netlink.c > @@ -186,7 +186,7 @@ static void mptcp_pm_create_subflow_or_signal_addr(struct mptcp_sock *msk) > { > struct sock *sk = (struct sock *)msk; > struct mptcp_pm_addr_entry *local; > - struct mptcp_addr_info remote; > + struct mptcp_addr_info remote = { 0 }; To respect the "reversed Xmas tree" way to declare variables, may you move this line up to be the first one in the list please? The rest looks good to me, thank you! Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net