From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C51A81A9B58 for ; Fri, 31 Jul 2026 00:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.113 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785458712; cv=none; b=SnK52Z/mXD9Uyr8FHKCbfELXW+OmOWBV2yqRLOjXMyLfNx8SZsFI+93InA+mLx6q9fkvLSnh/RooiuSW+UB4L76q7EV0cWRsCg4bPF3MbvGDhSm97Na/jvWCEwmlxJzWaSioMm//WtiQUxgXD1TnZCuyItFrDaJszlcuknYrvNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785458712; c=relaxed/simple; bh=3YGkrcb9ty1xvsPRti4EGPeMaMMgmstjBHfzPwM0xdI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cyUqphRa/M8VimrWdNPzm8SR+RLdNBAH182zCAbYcRSghOsXDh7obIlT86pEp6Ro3wuHBdyC19iOMcEgUDJakY1158axH2TTbZModGMmW8/f0JOw3fE/w9n1e1NocZ7H2/qZVKMB7+kEqxEO+6usvcBuqASUbzek1meXP0ZGPXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=SL60XFiC; arc=none smtp.client-ip=115.124.30.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="SL60XFiC" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1785458699; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=v6zC9Pu67+hG+fApLQE3VZHygRmJISPKeFpPL5zynL0=; b=SL60XFiC1tLAzNtjjtISsBnZWhGHeIR1Dcixu0HSbSl+TeRJbj6iY27w/itxgnFhixzwSl/tj3ABo+heJuGYp5LCAvaVPssjeEmtRgNXqSN29yqkAHjbSHUDAIUkk2za7/Sm1m35HMsjiO6nEhI7AV8M3uFVsnBCwet5MObIHf4= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam011083073210;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0X86Hp7q_1785458698; Received: from 30.221.129.39(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0X86Hp7q_1785458698 cluster:ay36) by smtp.aliyun-inc.com; Fri, 31 Jul 2026 08:44:59 +0800 Message-ID: Date: Fri, 31 Jul 2026 08:44:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ocfs2: Remove redundant NULL check for rec variable To: Roman Demidov , Andrew Morton Cc: Mark Fasheh , Joel Becker , ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20260730131507.26636-1-roman.demidov@red-soft.ru> From: Joseph Qi In-Reply-To: <20260730131507.26636-1-roman.demidov@red-soft.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/30/26 9:15 PM, Roman Demidov wrote: > The rec variable will contain the address of the structure array element, > i.e., the address of the ocfs2_chain_rec structure. > This address cannot be NULL. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Roman Demidov Reviewed-by: Joseph Qi > --- > fs/ocfs2/move_extents.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c > index ad1678ee7cc4..b546c7371e28 100644 > --- a/fs/ocfs2/move_extents.c > +++ b/fs/ocfs2/move_extents.c > @@ -415,9 +415,6 @@ static int ocfs2_find_victim_alloc_group(struct inode *inode, > for (i = 0; i < le16_to_cpu(cl->cl_next_free_rec); i++) { > > rec = &(cl->cl_recs[i]); > - if (!rec) > - continue; > - > bg = NULL; > > do {