From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795073762; b=ld+eP+rA2NxS9LPp1w/ZtGjBPj198ZZxNPlN3v5XmsnbVMe1JYZRl+kAn9/ckQq3BFh9 MLEMMs+lftijE8s4roRQ0CCrQ7YpbWoeXQKgFM7HXghj1CWm4en/V/6yMVlXC9S4N8oG5 Tt4095FqBbrfmEbeDKKIWZGEHo9UDwddunPiXK8gAJSKBZxLeQ/rwo5G0hTITG08RHQSU 3wmijxfShbeQrANryOe2HrDmkvaogme222AB7y23ilyehhSemQkR/jE7nxeEKXwgCwhzC cjyQy5VUTzoJ8Ma3pF9smJYHUfI+fvqK5DkbYWbt37Y/B9e75jMIA6+Ksc6vftsYOeg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795073762; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID: X-Authority-Analysis:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=MrR4v6w8hM+joF8rOFBj1WZlbRGV33NqZGNbqm2Vp0A=; b=5Y8qDbv83EZbRh3aqEfqcL/txEMMfQKiRnopoQVrs7nMcNCCFgwKwTn4f9pKPH3JfvHy MWdr2NrblCg8uc05vjMzwDDGLJq1aDh1q1bUGpKKR3kis/j7k5vv4jpuRlWq3dcj08rFf IRmL1R4LJJK13DH35MKVizm9xNn1bsVrSB6NUvfg6mrqOWXHa9xyG7Z4IxjPr754k+zBp qKJbEAwQZuQkFi2LweYIGqH2SlYhxN+McIDdL9EAV8VMrwHakcZJ7OjTtrnWT5259jhLN o/+IrukG7+td2xM8lm8XpSZt11EmgDaGFVmoCM8JTM/A1wLexJWTpMu7Z3N8UEkKMrQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=SPdpQLIQ; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=B1CWnsrd; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67D98606A320 for ; Thu, 19 Nov 2026 07:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 67D98606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=SPdpQLIQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=B1CWnsrd Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AJ7ZrM93718214 for ; Thu, 19 Nov 2026 07:36:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MrR4v6w8hM+joF8rOFBj1WZlbRGV33NqZGNbqm2Vp0A=; b=SPdpQLIQ/hjGJ8Y3 zpJQGpqvX5XR04RNeeNiStAUJZp5gij8VvMpXKIPgv7UTNov3w4lDumv+cMPxZg2 O0WwUMGZJUQgdLzxYrrm/Yu+6ve4S1iC9QfSWIDz2ldbrPKlQcNsOyf0AtG8s8Be 2IYjVack31KNqUp604HdbqWn2MoXXbwORfPe6+ej7wHdpL9azUIOusqHWLcrsbPb jEhKN0VztQgTB36OnDVqfnTEtbco9IwtV8UxkdcDshhRp5eJCW7DxzVgQGXXy0we svvd4P2m8Buh8UgiUeFOPgmR++Sz4R1SZcZ+IABfKpVV6607WiE3Z+DQcoV9Wwvu X1iVsw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j1vv2r02e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Nov 2026 07:35:59 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cc1cdfb337eso1376898a12.0 for ; Wed, 18 Nov 2026 23:35:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1795073759; x=1795678559; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MrR4v6w8hM+joF8rOFBj1WZlbRGV33NqZGNbqm2Vp0A=; b=B1CWnsrdbw8r7kBS6ZvpqzJPy9atzYrMRGCsNIw9axP9V0cVXtPmeb+8HWF6rDhXM/ pt3qgOdre9vURg0WwBpoKylX2ZbLOc2mriBdwni8qfN0Utx1CTURF4Rib5jSsBb65hY+ UCsvuBHLpPB+O9j44yELE/JIBIQKeAv7A2bHSJq6ljpDKRcmxQeG7SXk7C8rB6DblpH6 Bpe+cAgB4TALK8c7UN9IFvPGNZxGo9r5aLZzejVZ7vBQPx5z3CqKPQvkvfUyyQ3q6qxq BkxucCzlG2BsFUAMDbh2AzP0x8TpAkgth3qbW/86OMVXxqVWZTYrrD6YuaVkQPxlyY1y 90kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795073759; x=1795678559; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MrR4v6w8hM+joF8rOFBj1WZlbRGV33NqZGNbqm2Vp0A=; b=D1IuEakDncFrQlyxgWPgGnZ4rK6QhsMd/6zCqNRwH7FsDUCQ6tscrd4CmaTkL4rSNj fjwFO97+P6MqWmSls59bp+pBUFFPYRnsTFGf4GLijSey7WENfD+s/ZQaws7HEHwQvL3G CwBT25NUkMadFQvAH1lBy6TtXSy7q6BTVkjBDIbjm2UKg6suaDKHskatHealyXypn8Nn ZoMeB2tFyIQoWhikkkut/fq8MQcON//VBwxTxGnzck5uT8btTTRoeNKArPVyo7/P1wU+ jqzs0d41AXX+mRYYm4V0MdvmSpcH7zeYQm3hSsrsVp6xeYHvQOhs+TE8BAYsTsrpq0Ub afyA== X-Forwarded-Encrypted: i=1; AL+hErFg6GsEpJMJK9OEibBeEMhGYFBwSzTapcPg0i3tzx7wEjSkrJOCR4uTgCgxc61UT9Xx9oYofV83X+Ol0R0=@vger.kernel.org X-Gm-Message-State: APuU4Z/K/AOUDcu8woNE0kcCq8DSij0q+xvhfjfEvEgCfh3RO4PtIlTQ 33wZEKJKoZ4NmQ9x82QWaDGlhWND0GOgOuA6hWyWnXg8c8gG8Aj9UI5rSoES27S+2Tb7BLVUMK+ veBxsnH7PNM2GjnRMUhuR7Sl1nX49T3HSersMDA9n1VOLzSSnH42UcoO9TSIkt8PMHRQ7E+FUyl w= X-Gm-Gg: AYBFou0JZGLUbnla7Vk6WLuebIr6OlC42icqckNQ9fKN5MlH9IkmeXJAOCcJwLPkZ1w EmC21l8/1sCEq+8RHtfQKb8Vygh+OHQwhxdcAPREYPf3pRh918/6Uw7T2i242YoKu7lKzJq0cYY 5Orevz9AMzcOMN90DCRJ0EIukXVdMSf14SlnF1rrlAQFFjARdRn6yxVhCocuvIom1lWw9+LTQzc wmL9J1Jon+u0FHMzoHRO5V0o97UqdfOs8wLD98e7OTshfPcl5t9It1g6GWCmySTJpjR2tXkeRuA xMNE9nEAEgpAx79gbuzpLCNL2IhbOIu0fs0Inu/2X9Vr3pn3Iym2IW4ss3R0Sr6KDU3Y85Rgw8j Ty7ie7Sl3+SDwyVTJlFiEcaWsvji7xc2JO6iTEhPYmrnXVgqiY05uzEkI50i6UoqZzr5kNTcQBG kS X-Received: by 2002:a05:6a20:a10c:b0:3fa:7d82:5e96 with SMTP id adf61e73a8af0-3fe985f42bamr6096169637.73.1795073758874; Wed, 18 Nov 2026 23:35:58 -0800 (PST) X-Received: by 2002:a05:6a20:a10c:b0:3fa:7d82:5e96 with SMTP id adf61e73a8af0-3fe985f42bamr6096147637.73.1795073758410; Wed, 18 Nov 2026 23:35:58 -0800 (PST) Received: from [10.64.69.173] ([114.94.8.21]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8c5cb54e413sm2433584b3a.43.2026.11.18.23.35.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Nov 2026 23:35:57 -0800 (PST) Message-ID: Date: Thu, 19 Nov 2026 15:35:51 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 08/35] drm/msm/dp: add support to send ACT packets for MST To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20260929-msm-dp-mst-v7-0-4b81473185e7@oss.qualcomm.com> <20260929-msm-dp-mst-v7-8-4b81473185e7@oss.qualcomm.com> <3c28f89e-8b49-4937-b4c8-66da180a5706@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: IuV4-TjEARyfRPp22BsJ-saeMJGjaZpB X-Proofpoint-ORIG-GUID: IuV4-TjEARyfRPp22BsJ-saeMJGjaZpB X-Authority-Analysis: v=2.4 cv=ZZWIpcVA c=1 sm=1 tr=0 ts=6afea6df cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=Uz3yg00KUFJ2y2WijEJ4bw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=Ip3K_fYRsbvWuOMUuCoA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE5MDAyOSBTYWx0ZWRfX0c97fk1ELfkZ RcZW5FvjtKxBb/nzkntc3fqDN6uJJdqbdUD2Zqu8dTYYgDjF0VlKm5ItqglfNJpmt2QHggDUX5D dpkUKhELJGesurPtWz+C14mfubwivxg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE5MDAyOSBTYWx0ZWRfX9iq+QQsx03HN uID4LENkRNH+czoxVc9+guPdN6w9xfiWY213owBw9wUjrr/aFbBiPeMS3eAjFqvmGl8aZv9gw6M nooqLyTpW4x83+u2TQNTsDOWSHtCYwuW0FCTQpzalM2Utjztgj2CI2qenI6vptv5kpmQfYdhJPM TqKv3kWYF5ZCSzamFHwBWRSMSFijsLGJlPryDDH8oPMPO4UPnNqmVB6B8u0Iwk+v6NiHWJ/4xsr QUUduJTpMkLljGcnIJ6dDUtxX3ygmQc2oDXTv+UJnuqBOPQHzvwrHyGzwBTy6tm0WEMmJr5rKW9 furQ+JyzXyQ1X07qtKr9qR7ByDKoFCPbuJXwGeTVQyeQTpXtBvbzAtgU0GUchhpcdSR16EV762Q AGZ7mFUw7WKoi0S90s1b6LGJmpIBRX1pQ7+4xm8uHWrlq/shsanLjtDGNUE0NisgjjdBh3dgC1y aPS7uIfnZ+MBxW7HL3w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-19_02,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611190029 On 11/11/2026 10:22 PM, Dmitry Baryshkov wrote: > On Thu, Oct 15, 2026 at 06:28:52PM +0800, Yongxing Mou wrote: >> >> >> On 10/12/2026 8:23 PM, Dmitry Baryshkov wrote: >>> On Mon, Oct 12, 2026 at 04:44:06PM +0800, Yongxing Mou wrote: >>>> >>>> >>>> On 10/1/2026 6:32 PM, Dmitry Baryshkov wrote: >>>>> On Tue, Sep 29, 2026 at 12:25:32PM +0800, Yongxing Mou wrote: >>>>>> From: Abhinav Kumar >>>>>> >>>>>> Whenever virtual channel slot allocation changes, the DP >>>>>> source must send the action control trigger sequence to notify >>>>>> the sink about the same. This would be applicable during the >>>>>> start and stop of the pixel stream. Add the infrastructure >>>>>> to be able to send ACT packets for the DP controller when >>>>>> operating in MST mode. >>>>>> >>>>>> Add REG_DP_MST_ACT, the ACT trigger register used by this sequence. >>>>>> >>>>>> Signed-off-by: Abhinav Kumar >>>>>> Signed-off-by: Yongxing Mou >>>>>> --- >>>>>> drivers/gpu/drm/msm/dp/dp_ctrl.c | 44 ++++++++++++++++++++++++++++++++++++- >>>>>> drivers/gpu/drm/msm/dp/dp_ctrl.h | 5 ++++- >>>>>> drivers/gpu/drm/msm/dp/dp_display.c | 3 ++- >>>>>> drivers/gpu/drm/msm/dp/dp_display.h | 1 + >>>>>> drivers/gpu/drm/msm/dp/dp_reg.h | 1 + >>>>>> 5 files changed, 51 insertions(+), 3 deletions(-) >>>>>> >>>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c >>>>>> index e1614bc49a7c..65d22505c2b6 100644 >>>>>> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c >>>>>> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c >>>>>> @@ -142,6 +142,7 @@ struct msm_dp_ctrl_private { >>>>>> bool core_clks_on; >>>>>> bool link_clks_on; >>>>>> bool stream_clks_on[DP_STREAM_MAX]; >>>>>> + bool mst_active; >>>>> >>>>> I really don't like the idea of having this flag in two locations. Here >>>>> and in the msm_dp_display_private. Can we have it in one place only? >>>>> >>>> These two fields are intended to represent different states with different >>>> lifetimes. >>>> >>>> msm_dp::mst_active tracks whether the DP connection has an active MST >>>> session. The controller field records whether the current controller/link is >>>> operating in MST mode and remains valid until the link is shut down. >>>> >>>> I agree that using mst_active for both fields makes them look like >>>> duplicated state. I propose renaming the controller field to mst_mode while >>>> keeping the display-side field as mst_active. >>>> >>>> Would you agree with this change? >>> >>> What is the difference between these two? I.e. what os the difference >>> between those two? >>> >> The difference between these two states mainly shows up during unplug. >> mst_active is cleared when dp_display starts handling the unplug, while >> dp_ctrl needs to keep the MST state until all streams are disabled and the >> link is shut down. >> >> So there is a period during teardown where these two states are different, >> which is expected. >> >> My concern with keeping only one state is that we would need to pass the MST >> mode through multiple dp_ctrl APIs, which would make the code more >> complicated. Would it make sense to keep this state in dp_ctrl and rename it >> to mst_mode to make the distinction clearer? > > Sorry for the delayed response. How would the driver behave while those > two disagree? What happens if the user unplugs the MST sink and then, > without stopping the display, plugs in the SST sink? > The window does exist, but it's extremely(130~200ms in my monaco device) short and hard for a user to actually hit. It only exists when the disable commit is asynchronous. We can consider introducing drm_dp_mst_root_conn_atomic_check(). It's specifically designed to serialize the MST disable commit against the SST enable commit. >