mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dan Carpenter" <error27@gmail.com>
To: "Neil Horman" <nhorman@tuxdriver.com>
Cc: kernel-janitors@lists.osdl.org, akpm@osdl.org, maxk@qualcomm.com,
	benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
	kjhall@us.ibm.com
Subject: Re: [KJ] [PATCH] Correct misc_register return code handling in several drivers
Date: Mon, 23 Oct 2006 11:01:36 -0700	[thread overview]
Message-ID: <a63d67fe0610231101v2f407e7dv46adaf8dbb0fb4e@mail.gmail.com> (raw)
In-Reply-To: <20061023171910.GA23714@hmsreliant.homelinux.net>

On 10/23/06, Neil Horman <nhorman@tuxdriver.com> wrote:
> +out3:
> +       for_each_online_node(node) {
> +               if(timers[node] != NULL)
> +                       kfree(timers[node]);
> +       }

Tharindu is going to be unhappy out if he sees that.  There is a
possibility that timers[node] is uninitialized.  if node[0] is null
then node[1] is uninitialized and it's going to cause a crash.

regards,
dan carpenter

  parent reply	other threads:[~2006-10-23 18:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-23 17:19 [KJ][PATCH] " Neil Horman
2006-10-23 17:39 ` Alan Cox
2006-10-23 17:54   ` Neil Horman
2006-10-23 18:23     ` Kylene Jo Hall
2006-10-23 19:18     ` Alan Cox
2006-10-23 18:01 ` Dan Carpenter [this message]
2006-10-23 18:13   ` [KJ] [PATCH] " Neil Horman
2006-10-23 18:32     ` Dan Carpenter
2006-10-23 18:44       ` Neil Horman
2006-10-24  3:34 ` [KJ][PATCH] " Benjamin Herrenschmidt
2006-10-24 12:53   ` Neil Horman
2006-10-24 13:24     ` [KJ] [PATCH] " Matthew Wilcox
2006-10-24 15:07       ` Neil Horman
2006-10-24 22:42     ` [KJ][PATCH] " Benjamin Herrenschmidt
2006-10-25 13:17       ` Neil Horman
2006-11-01 13:56       ` Neil Horman
2006-11-01 23:55         ` Andrew Morton
2006-11-02 14:21           ` Neil Horman
2006-11-02  0:05         ` Jesper Juhl
2006-11-02  0:11           ` Randy Dunlap
2006-11-02  0:24             ` Jesper Juhl
2006-11-02  0:27             ` Andrew Morton
2006-11-02  0:44               ` Jesper Juhl
2006-11-02  1:12                 ` Randy Dunlap
2006-11-02  1:23                   ` Jesper Juhl
2006-11-02  1:22                     ` Randy Dunlap
2006-11-15  0:04                       ` Randy Dunlap
2006-11-15  9:05                         ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a63d67fe0610231101v2f407e7dv46adaf8dbb0fb4e@mail.gmail.com \
    --to=error27@gmail.com \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=kjhall@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome