From: Pavel Skripkin <paskripkin@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: ath9k-devel@qca.qualcomm.com, kvalo@codeaurora.org,
davem@davemloft.net, kuba@kernel.org, linville@tuxdriver.com,
vasanth@atheros.com, Sujith.Manoharan@atheros.com,
senthilkumar@atheros.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+f83a1df1ed4f67e8d8ad@syzkaller.appspotmail.com
Subject: Re: [PATCH] ath9k_htc: fix uninit value bugs
Date: Mon, 17 Jan 2022 21:35:13 +0300 [thread overview]
Message-ID: <a63d6d9b-7e95-3e88-fcd2-2fe5e623dd5b@gmail.com> (raw)
In-Reply-To: <164242422410.16718.5618838300043178474.kvalo@kernel.org>
Hi Kalle,
On 1/17/22 15:57, Kalle Valo wrote:
>> Fixes: fb9987d0f748 ("ath9k_htc: Support for AR9271 chipset.")
>> Reported-by: syzbot+f83a1df1ed4f67e8d8ad@syzkaller.appspotmail.com
>> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
>
> How did you test this? As syzbot is mentioned I assume you did not test this on
> a real device, it would help a lot if this is clearly mentioned in the commit
> log. My trust on syzbot fixes is close to zero due to bad past history.
>
You are right, I've tested only with syzbot's reproducer. I've followed
simple guess: if code works properly with random values in these fields
for 14+ years, then zeroing them won't hurt much.
I might be missing something, but unfortunately I don't have suitable hw
piece to test the change.
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-01-17 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-15 12:27 Pavel Skripkin
2022-01-17 12:57 ` Kalle Valo
2022-01-17 18:35 ` Pavel Skripkin [this message]
2022-01-28 12:32 ` Kalle Valo
2022-01-28 20:52 ` Pavel Skripkin
2022-02-03 8:39 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a63d6d9b-7e95-3e88-fcd2-2fe5e623dd5b@gmail.com \
--to=paskripkin@gmail.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=senthilkumar@atheros.com \
--cc=syzbot+f83a1df1ed4f67e8d8ad@syzkaller.appspotmail.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®