From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF6743D3314 for ; Fri, 20 Mar 2026 17:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.97.179.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774026879; cv=none; b=X1rxI0IPwp0Dl5b4lqBNbnIERkByngtse2CSXCfhB9Wl6XwntxlfpdgQIKP2UQNjdCg5tOh7y11eo5QRaikBqYa6CLuaeK1jkDqtXsGaxrKnf2KIpT1YQtBqUcjJwctq7754n1xTHoCodEKlE0EWlms9OrnCaE8y79Pk9vxW1Lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774026879; c=relaxed/simple; bh=z3Ald1rFt156615FpGAAqki4sLHVaY898mSxO49Y+Zk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M6jQzMcAt6sjvY4uApbuAlgTIq+uEWqxS1TyhY1tqCWqyxnFqxgvWp8tqkLFxBb30q4I67/cKj/2N+YMOlOoO2yRFCrE7NX+OROvxBlKFBhaYocnaTcCUHfB/eW+4glCYlFfSO3ozk6ABZdKMQFRWu6Z0vCTQyfiXwS2cZUzUbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=CyouKC99; arc=none smtp.client-ip=213.97.179.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="CyouKC99" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=huH9MBGAmnG3rOv0QvsEiRwuRB2oaDpci9HPaQB05lc=; b=CyouKC99/AI8R4rlz7GtUrcO0z sdCXP6s34bHkGfrO7P3f2X5D38Hx38fTfORhxsODLWvjaP/EMmcpSmi3dJPUWaHOPghwNefsDeTCd kzhu+cdcUri5ElIg7pJ6luai/cwhOmBHj6MHkWQvS79Zgzzuhr43rL0A4AwXRdOdTsrFp4ep/apVZ XxNVkH95oBhQHnk5ZLS60guoF552n5Ctg7Elj7EMP8LyvoX3brJcpGTgP71QNPTMeKXTMOobH5Duy HFNSCukLjp9yTGJI/CLsW8a28Ru4z2FFNlZPvCufZS65LHsRN8jZhTK9++E8F6KKYRa1nYad61/Tk AlmSRXog==; Received: from [179.118.189.200] (helo=[192.168.15.100]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1w3dQX-003u7X-Nf; Fri, 20 Mar 2026 18:14:25 +0100 Message-ID: Date: Fri, 20 Mar 2026 14:14:19 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [patch v2 07/11] futex: Add support for unlocking robust futexes To: Thomas Gleixner Cc: Mathieu Desnoyers , Sebastian Andrzej Siewior , LKML , Carlos O'Donell , Peter Zijlstra , Florian Weimer , Rich Felker , Torvald Riegel , Darren Hart , Ingo Molnar , Davidlohr Bueso , Arnd Bergmann , "Liam R . Howlett" , Uros Bizjak , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= References: <20260319225224.853416463@kernel.org> <20260319231239.613218128@kernel.org> Content-Language: en-US From: =?UTF-8?Q?Andr=C3=A9_Almeida?= In-Reply-To: <20260319231239.613218128@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Em 19/03/2026 20:24, Thomas Gleixner escreveu: > > The sys_futex() case [ab]uses the @uaddr2 argument to hand the pointer to > the kernel. This argument is only evaluated when the FUTEX_ROBUST_UNLOCK > bit is set and is therefore backward compatible. > I didn't find anywhere in the commit message that says what this pointers points to, so I would add: "@uaddr2 argument to hand the address of robust list pending op to the kernel" and also explain why we can't use current->futex.robust_list->list_op_pending (if I understood it correctly why): "Instead of using the list_op_pending address found at current->futex.robust_list, use the address explicitly set by the user in the syscall arguments to avoid racing with set_robust_list()" Anyway, this is Reviewed-by: André Almeida