mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tariq Toukan <tariqt@nvidia.com>
To: Jinvas <jinvas@126.com>,
	saeedm@nvidia.com, tariqt@nvidia.com, mbloch@nvidia.com,
	leonro@nvidia.com, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, horms@kernel.org,
	alexious@zju.edu.cn
Subject: Re: [PATCH net v3 0/1] net/mlx5e: fix NULL pointer dereference in arfs_create_groups()
Date: Wed, 18 Nov 2026 16:17:33 +0200	[thread overview]
Message-ID: <a64c831a-808c-46d9-b6e9-ad1b63577291@nvidia.com> (raw)
In-Reply-To: <20261118134514.1765-1-jinvas@126.com>



On 18/11/2026 15:45, Jinvas wrote:
> The following patch fixes a NULL pointer dereference in the mlx5e aRFS
> code, which oopses the kernel during NIC bring-up.
> 
> The bug was introduced by commit 3c6d5189246f ("net/mlx5e: fix a
> double-free in arfs_create_groups", in v6.8) and is still present in
> v7.4-rc2.
> 
> 1. What happens
> 
> arfs_create_groups() creates up to two flow groups in ft->g[], and
> increments ft->num_groups for each group that was created successfully.
> If creating the second group fails, the error path frees ft->g and sets
> it to NULL, but leaves ft->num_groups at 1.
> 
> The only caller, arfs_create_table(), calls mlx5e_destroy_flow_table() on
> the error path, which calls mlx5e_destroy_groups():
> 
> 	for (i = ft->num_groups - 1; i >= 0; i--) {
> 		if (!IS_ERR_OR_NULL(ft->g[i]))
> 			mlx5_destroy_flow_group(ft->g[i]);
> 		ft->g[i] = NULL;
> 	}
> 
> ft->g is NULL at this point, so ft->g[0] is a NULL pointer dereference.
> Note that only a failure of the *second* group triggers this; if the
> first group fails, num_groups is still 0 and the loop body never runs.
> 
> The same error path also leaks the flow group that was created
> successfully before the failure, since ft->g is freed without the group
> being destroyed.
> 
> 2. How this was introduced
> 
> Commit 3c6d5189246f fixed a double free of ft->g between
> arfs_create_groups() and its caller. Before that commit, the group
> failure path did not touch ft->g at all:
> 
> 	err:
> 		err = PTR_ERR(ft->g[ft->num_groups]);
> 		ft->g[ft->num_groups] = NULL;
> 	out:
> 		kvfree(in);
> 		return err;
> 
> so the caller destroyed the flow groups that had been created and then
> freed the array. That commit fixed the double free in the allocation
> failure path by freeing ft->g here as well, and in doing so changed the
> group failure path too:
> 
> 	err_clean_group:
> 		err = PTR_ERR(ft->g[ft->num_groups]);
> 		ft->g[ft->num_groups] = NULL;
> 	err_free_in:
> 		kvfree(in);
> 	err_free_g:
> 		kfree(ft->g);
> 		ft->g = NULL;
> 		return err;
> 
> The reset of ft->num_groups that would have prevented this was
> suggested during review, but deferred ("it is a better idea to leave it
> to a refector patch one day"), and that patch never landed.
> 
> 3. The oops
> 
> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
> Oops [#1]
> epc : mlx5e_destroy_groups+0x38/0x6c
>   ra : mlx5e_destroy_flow_table+0x10/0x30
> status: 0000000200000120 badaddr: 0000000000000000 cause: 000000000000000d
> [<ffffffff80843604>] mlx5e_arfs_create_tables+0x44c/0x5d8
> [<ffffffff80815bd6>] mlx5e_create_flow_steering+0x42/0x6bc
> [<ffffffff808043e4>] mlx5e_init_nic_rx+0x84/0x14c
> [<ffffffff80808a4c>] mlx5e_attach_netdev+0xb8/0x2e8
> [<ffffffff8080f36e>] mlx5e_probe+0x48e/0x81c
> Code: 89b3 40f9 e052 098e 7a7d a011 84be 3783 0109 97a6 (6398) 853a
> Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> 
> The register dump shows a5 = 0, i.e. ft->g was read as NULL. Offset 16
> of struct mlx5e_flow_table is ft->g, and the faulting instruction loads
> from the address in a5, so the faulting access is the ft->g[0] read.
> 
> Note that the bug itself is not architecture specific. It is a plain
> error path in C, and it is reachable on any architecture; the register
> dump above is only from the machine on which it was hit.
> 
> 4. How this was hit
> 
> This was found while testing a virtual mlx5 device whose firmware
> answers host mailbox commands. The device took longer than the
> firmware's own timeout to answer one CREATE_FLOW_GROUP command, so the
> firmware reported the command as failed even though the device had
> completed it. The host then took its error path, and the bug above
> turned a command failure into a kernel panic.
> 
> That is only the trigger though, not the cause: the host oopses on any
> error returned by CREATE_FLOW_GROUP, no matter where the error comes
> from (a device that rejects the command, a resource shortage, a command
> timeout, ...). A firmware that returns an error for the second
> CREATE_FLOW_GROUP is enough to reproduce it.
> 
> A minimal reproduction is therefore: enable aRFS, and make the second
> CREATE_FLOW_GROUP of one of the aRFS flow tables fail. The kernel
> then calls mlx5e_destroy_flow_table() with ft->num_groups == 1 and
> ft->g == NULL, and dereferences the NULL array.
> 
> 5. The fix
> 
> The patch leaves the free of ft->g to the caller:
> mlx5e_destroy_flow_table() frees ft->g exactly once, and also destroys
> the flow groups that were created. This fixes the NULL pointer
> dereference and the leak, while keeping the double free fixed.
> 
> For the three error paths of arfs_create_groups():
> 
>    ft->g     num_groups  what the caller does
>    --------  ----------  ----------------------------------------
>    NULL      0           kfree(NULL), no group to destroy
>    non-NULL  0           kfree(ft->g), no group to destroy
>    non-NULL  1           destroy the created group, then kfree(ft->g)
> 
> ft->g is therefore freed exactly once in all three cases, so the double
> free that 3c6d5189246f fixed stays fixed.
> 
> The patch also makes the error handling of this function consistent
> with the rest of the driver, e.g. mlx5e_create_l2_table().

Sentence was not dropped.

Doesn't worth a respin.

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>


      parent reply	other threads:[~2026-11-18 14:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 13:45 Jinvas
2026-11-18 13:45 ` [PATCH net v3 1/1] " Jinvas
2026-11-18 14:17 ` Tariq Toukan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a64c831a-808c-46d9-b6e9-ad1b63577291@nvidia.com \
    --to=tariqt@nvidia.com \
    --cc=alexious@zju.edu.cn \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=horms@kernel.org \
    --cc=jinvas@126.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®