From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E40C001B0 for ; Wed, 9 Aug 2023 14:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233608AbjHIOir (ORCPT ); Wed, 9 Aug 2023 10:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbjHIOiq (ORCPT ); Wed, 9 Aug 2023 10:38:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE101EE for ; Wed, 9 Aug 2023 07:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691591886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FfaqYBoSIYPW90lLITj1L4KV3NJRPADuNi7szlbNvX0=; b=WYeiwRTTMhk5mCUdRsyJOvyG47A108hXSirL2BXRn3M1T2XUi4dHYK56Kgn7kZP/Pt5TtL k+8pf6j+8ZWa3p4ReXfOxmRKgmPQhlPMhb4jih6dvccWvr7JMwIhqQQhE5F0ujHfaU+zIA Yt+PRjH2nSTfACczKlM7DfNQRCWojB4= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-8Nw1bKLFPjSQqWOUz46zgQ-1; Wed, 09 Aug 2023 10:38:04 -0400 X-MC-Unique: 8Nw1bKLFPjSQqWOUz46zgQ-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-523204878d9so3272038a12.0 for ; Wed, 09 Aug 2023 07:38:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691591883; x=1692196683; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FfaqYBoSIYPW90lLITj1L4KV3NJRPADuNi7szlbNvX0=; b=GlnbXY1TnJMH8dbtjeFipI5T5E2VoxhPF2b5GP3kRCyXg4XL6zat3ZZNEMz4iC+ED5 rNNZdNkw/A+sdeZcShAPU4w3siN7E5nsyEWHrrs1hCKDGv0wj6ijXNu0vDKgYmsDTUH2 vcQgAPusQ00Qul6QWrUQcj5i2ohj3z3lopFxBY78jYseYTZjg6mLWNiLFwnQ7trVO+4m 71QmsYZeIJL3DlL5Kmsq1Q9hP5kSZe8OOgYZ2gLegzlgYDFhWx3HpC+DHZ2aSHmPCUj3 Pb8XgFiiQ8Gk3bEUIzyVGg1FM48sEX1dkNtl+eJFj035v3mj190UrjWczlRlioyXcBnF lRNg== X-Gm-Message-State: AOJu0YyXbOFXrMiu5FjbodLC90nCXMbf3SP8CPVvlHTGUffobFjkhPUl VYmYZj4RtbjIqag7HwA8Aonr9maJQBJ9vvenX/9HOeKfvXFrRe216+G/cZLrMTTVg4p4qipmq0m +Auij4sMswYofa/MvVA5C2f9x X-Received: by 2002:a05:6402:184b:b0:522:2bc8:cbb8 with SMTP id v11-20020a056402184b00b005222bc8cbb8mr2373298edy.6.1691591883425; Wed, 09 Aug 2023 07:38:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQPaj55jsOKUpH9lNEEW/swMD5Tp0csnhE3/0wFF+ZhkKPSB2MHE8RfpzaHqSmQr4L+8yfkw== X-Received: by 2002:a05:6402:184b:b0:522:2bc8:cbb8 with SMTP id v11-20020a056402184b00b005222bc8cbb8mr2373293edy.6.1691591883135; Wed, 09 Aug 2023 07:38:03 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id o26-20020aa7d3da000000b0052364845bdfsm954724edr.69.2023.08.09.07.38.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 07:38:01 -0700 (PDT) Message-ID: Date: Wed, 9 Aug 2023 16:38:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation Library Content-Language: en-US, nl To: Yazen Ghannam , Borislav Petkov , "Limonciello, Mario" , linux-edac@vger.kernel.org, markgross@kernel.org, platform-driver-x86@vger.kernel.org, "Luck, Tony" Cc: linux-kernel@vger.kernel.org, avadhut.naik@amd.com References: <20230802185504.606855-1-yazen.ghannam@amd.com> <20230802185504.606855-2-yazen.ghannam@amd.com> <58934edf-4fad-48e0-bc5d-62712b11e607@amd.com> <894b3737-1a0a-4139-9c73-686a95481795@amd.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/8/23 16:07, Yazen Ghannam wrote: > On 8/8/2023 8:10 AM, Borislav Petkov wrote: >> On August 8, 2023 5:17:33 AM GMT+02:00, "Limonciello, Mario" wrote: >>> Given it's 'library code' to be used by a bunch of things and also want to be able to use a module, what about putting it in lib/?  There's plenty of library code there as tristate. >> >> It is x86-specific so not in there. Also, it might be used by multiple things so you want it as a separate "translation" service which is called by other modules. >> > > There are modules in arch/x86, so I guess that's not an issue (not sure what I was thinking). Right, I think arch/x86 makes sense. As for putting this under drivers/platform/x86/amd as initially suggested. That means that any code which wants to select this because it needs the functions also must select X86_PLATFORM_DEVICES, so IMHO it is better to put it in another place. Regards, Hans