From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753131AbdJaBhd (ORCPT ); Mon, 30 Oct 2017 21:37:33 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:35322 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561AbdJaBha (ORCPT ); Mon, 30 Oct 2017 21:37:30 -0400 Subject: Re: [PATCH 2/2] samples/bpf: add a test for bpf_override_return To: Josef Bacik , , , , , References: <1509398375-11927-1-git-send-email-josef@toxicpanda.com> <1509398375-11927-3-git-send-email-josef@toxicpanda.com> CC: Josef Bacik From: Alexei Starovoitov Message-ID: Date: Mon, 30 Oct 2017 18:37:16 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1509398375-11927-3-git-send-email-josef@toxicpanda.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:180::1:5c08] X-ClientProxiedBy: CY4PR2201CA0024.namprd22.prod.outlook.com (2603:10b6:910:5f::34) To DM3PR15MB0970.namprd15.prod.outlook.com (2603:10b6:0:10::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 85f883a2-6086-4199-e781-08d51fffede0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(2017052603238);SRVR:DM3PR15MB0970; X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0970;3:nL9WliUSxc35w87nayZISaEVlk0TAxL1uDkuZ1DLdxSg67paiYg7OXWWDPFF2dzl+wGRpfuBjbXaPy8/XWca5m1dtgqhbWDLM1u0DEQLSZAcVbKtYp0PBYvPNph2VIVD8aJNErvsf2RY28T1SY39ZKxrZU6F3116G9mv+0Z0L9YgucJZbmzlgSN4VutXkHAIpAYAcLi1lvZOpNpKfAMCNv1rjyUf47bEcUerqeFGzpZBbcHfb/VNK5v3jDwV6vvx;25:wodnFHLrOkgJVUoYzaZt2KgaqBeKpZjB1UpFjCe+h59Ut79Oyv68U8Vt/KIuDT+hVRBuc0XZOWyA49CouhjxejjjPWap86dZ38pMYUArATlRj5DWR++5ozk8X9GWySByPn8a0M8BZ1oEHEGRWMMeQshUWFEUymLQhwm6itgrTDUPmt21YIsnvCXqCtC1vw71boyv/yhoWPpsQSqe3+Ng5i91JHe3LEF6pBr50tLPQbSuLbapj2u04D8Ni5r1rgdfkhtN0Mzb8CMFEYacuux47VMyMH/aRpqVWTaAB6SIpXqak71x8n0pjjThg70ASd2Ea0jD67/ZJR9u/JPu+Lkpng==;31:sg5WyJP09KW9rMoFUNCEfb1iRB4HgaSwEdr6Ysg4BsARhhMZQ2X3jfkUgphxLWxDoq2vy/mFgPX5n0ti7yeijPAVhla3uA78W4+yY4WXHfW6o79EpHxxlkHDI0l4DdU/Pag+ipU/giBkBRHOWbnUC7eBgYcmgh4mbPnrWvO7tssGymdDph1sCd3GUKrCb0Z5ZI8yooLKvMpLQ8dIhXAN6rSpfD/m0sQvDSHTcN4dJ1k= X-MS-TrafficTypeDiagnostic: DM3PR15MB0970: X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0970;20:POgisiafMM+LFHBwyASlAf+OhpC8J9UmobTaHCc2qxmWmRy455w7EjIMYNE8ZSju7mx6E1VnhjEr/M0pOWutHaBfheImnZxEuioDcPM7WAS5v9+0Z6I6lKfjgagdKonMMWQ5n9zIDKHPuX7Xe8UlJRGQGzR2zWC2kaMylUky8iWp014X3WVXnP2E+GxLoCp1WDTL/csDw2njG8TYnAmtDDGNjAHIrSmVsuUIzsq/dYOzleDk1fbMNmS99GQUyUTgRQlBQBFCyZcf6gFJPxufWNOO4df9enZFp7AE9ULGHvd0jcsCdxzcBZ86ui1z+I42Yl3fp1+/44trEjggWXV+3o5qBxkceAw8fW8ZYRdGXI/94RiR6WPwIRUPfEIGwizGxC52JOTa9TQz6tUkVibr+WCupIzimEF/xCENdPbXCWq2gZQrvRqnrLhZkddLvAFbHxS6glAH5I59x4HziORUSu58igDb/nmA+GoCpFCVg7eFS8qIvxCZAIrBx+dJhA+/;4:uwZHJ74HsKocaqiF+5oavaQKrkAaYKjV/vWO9Wc9CP5E8cT6Lc6kbhTiI6q948MgFgw/3/Oiw5UOy78K02L/B1fb5oj4zv2xcHMEOScz4m0nREhwmA3AL0l/U0y347QeWnJ4LLDQ4zhWHaACDKjWnfiPsc9G3rNc/ou5xGv6KBLx6JuxE+HLO+hNEbK/tqEeuyGg4+X/lgzb0UFTQVQnDbqsh2LaXA0GIlTpD8C2LgX8kiMSrgn4DQJBo/SQHRZYK/qsa/aeEiQilYbJ6Md+sA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231020)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM3PR15MB0970;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM3PR15MB0970; X-Forefront-PRVS: 04772EA191 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(24454002)(189002)(199003)(8676002)(50986999)(33646002)(106356001)(229853002)(5660300001)(189998001)(25786009)(83506002)(2950100002)(105586002)(6636002)(1706002)(36756003)(6116002)(23746002)(65826007)(230700001)(305945005)(54356999)(81166006)(76176999)(81156014)(7736002)(64126003)(8936002)(53546010)(6486002)(6666003)(58126008)(31696002)(4326008)(101416001)(50466002)(6246003)(2906002)(97736004)(65956001)(65806001)(68736007)(316002)(31686004)(86362001)(47776003)(53936002)(478600001)(67846002)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM3PR15MB0970;H:[IPv6:2620:10d:c081:1130::119f];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM3PR15MB0970;23:1FPQ2jSqQW8r9hXnoHzqjJ+8e+aBi5KFgKOgq?= =?Windows-1252?Q?bz4ubzUaVQi4JtnwHti35irEse6bTAOSS7WY0Xzwa3RBWpNz8VEZwcfI?= =?Windows-1252?Q?C3QHymqvzbY0oq1I3zbJI4DhoYo4cpYX5gd7cdaDyEIzrURJxmu8bn52?= =?Windows-1252?Q?4OZoX+MXfa4wnHa6gWmjvJZoiNfM5NPQxN7DSZV0CxzCXXcwOVKGtYtA?= =?Windows-1252?Q?VXjNNwX781DoYJgdExGTM44ZVxxJqw/icUknnS0AiX4JumkhzuS3Fopy?= =?Windows-1252?Q?47q2V4ZWMy3eDYDiKUFdncWSB2oDev5mGvPdlvBFrNkZNedrFSMxKWAW?= =?Windows-1252?Q?eiyPE9sf2x8v/0lX086kOvSghF5GiCZzJ3u4INnlA/dNPP7VIKSX5L2a?= =?Windows-1252?Q?B+L0vCY95abKVnpTth8KxczIYFGkvw2/6My8cvIUCPiwlSk96j9B2cJv?= =?Windows-1252?Q?6Tin0WToUxHVFImEwhhvIl2wpbiFOJrGqYnIPKnwXhrQPpcFMdkHgAm7?= =?Windows-1252?Q?TdHXX5OlojGUKxjQrGmfyPveE315ppSKfRhRdydX8qFtZKj6lyOKV8Tt?= =?Windows-1252?Q?ZGek+Vf49Va2e2Ha3BxKzyp0ANsrLW1Dg4o8dpewtCu5iJrX4+6UiNVU?= =?Windows-1252?Q?lbRJ0t/nm6NTM8+vYbm9RwlDgDhubEDN6mXNZMQbILw6cCQFL7yDyBHf?= =?Windows-1252?Q?E6rh3MqKVcL1kwa4xsb6I7pR7OGak7UfmAXk/rBfxoaFZa2qguFnPZTZ?= =?Windows-1252?Q?7fguyG3mmuH/i8cx0ukjbwZQJbjC5hcKeb1iU+PKfGYYccTDV3hleYXO?= =?Windows-1252?Q?7nfG0710wpGvQv7bU0P04z2+c/nsS9uxkHYJKrK/7q+SwDQJtmX0wWdd?= =?Windows-1252?Q?V5ss0zchH5qVv2GJycN9TtkR2DPkqYOrx0hFK2NjbTD1t1E/3cf4RDxm?= =?Windows-1252?Q?iZ63AyMGq2tOof8u3Q7neNR+tnW9hH2bvLf9VHquB4MOX4lYAZklmjp8?= =?Windows-1252?Q?D77LFtsCVh7NLODzRM7jihbR09h0S65N7eCnnaxDoOZFP9aVuURDeKhk?= =?Windows-1252?Q?aIVmdf2+X3oXeyLb+vvQqxgM0lro96dM7FwmIeY7PVAn76xPK8JU5/xR?= =?Windows-1252?Q?H5ZCI+CSR1KYn2IoYTrqkELuPZqlFQ2dJX8A/LX4YCrVYLxnth+mYBlY?= =?Windows-1252?Q?kevvjhSW4dJWsS9Cknviov/wuy4fyWgrc5XcvnXfy6Is431B0IUb4cYt?= =?Windows-1252?Q?bdWr5Rrd6V3XYZiSCy1FTo2LBIvcz6aiS5l4n18dUgArI3gsiuJPaBEE?= =?Windows-1252?Q?2rzFiU9EdM8jpQqT/xxYWOCwqaGdBz84ecPJQeYVetsC7Q=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0970;6:Whxs4JcGlk23Lrmq+G5BZQi/vIvBMvLq5g/tCs/dcdasESdxy+aqJhW/2Gvr4cZAUGzBF5iO+d8fj2lQdXJqrpZXvqbUw7OpYcxF/j7zCnRhM2qeUyC7f7PbfNKtAjXFJ7f5lJuxEPU+WtBttydVtrs85O2+phOdUY8tatBwp89/K6Ri/+VC4OQNeGwlYPVZqh3wz7nG2KdzO+eoScPa3X9Ul9mqLGIBRoyQrHqEaXgz7WpKtyiwfyQi5XnlZykCpAUCC63WWqr/zx4qdWntiNT9hxFDruou0ZuSE/tj9GvZJGRIFP98gG4uLNiMl9j7BFHQ67ZlDp1O50sYiLe5HGkKu7IG7VvOeW0GeATth9U=;5:eEFJmL2Rh/Fey1wSAVlUf+st0c7gMYve5lQnAgY/YjOx9w0/hLblJ7QKowHE8jr9hsW21Dmlo8vyr3j0fbwMDcHnw1teq27oGjdgwPNH/skJiSICH++0CRZHMgev/xe+B5ppl2EPMeOJLyRw51OZxfY6ZNRUkaBl9eNuVc64ecY=;24:9wJma3qmOqON9ZXkkPaKIf3+9svKmKD5IiFseAsOBXrf5PMcjwzoEXM5hJXoxo9asTxjE0x/pJuMru8XvGFADhwIeCxZBuWHsXEE68Kj0so=;7:PJvEbWGEAFbmXEbvZT72NyVY8CSvOd6iY2F5Nvgc6dzomWveuhfrT06mEbPCFhVIb66C4hNXzcF3Vwg84abUZvwkyVItgiyz95LP6o7D8Nuz/b+VmKFNDUgnpBk6Y6Vu1iTj3yFWYEDn1MkXKC5abrFuR3AOjb0eZ7eMd8f7dHN9jp+YHfjpLBTcZNvrNbj1Z3SdERAG7YrvkD8KQZZLYRRuB1v5VHX9wRZdi3iuyl4xvfO8bxT1XxGyeRQpUMV9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM3PR15MB0970;20:uuAw64RhdRl24n4KpAVrXG/gjYauh/BgZG1xPD0w3eaCuNxXfFrswPHIDfhBlxBOZnmcqxV9PwzOu6DioGPnZhgI8naGlj3JMROFub3nAKIF41QuHyMSd5ZJ14J/TvfWa6uq2z5WNV5BQNBqSWNk8kbWNGH1ztOzHwNpE/tg1jc= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2017 01:37:20.1322 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85f883a2-6086-4199-e781-08d51fffede0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR15MB0970 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-30_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/17 2:19 PM, Josef Bacik wrote: > + > +rm -f testfile.img > +dd if=/dev/zero of=testfile.img bs=1M seek=1000 count=1 > +DEVICE=$(losetup --show -f testfile.img) > +mkfs.btrfs -f $DEVICE > +mkdir tmpmnt > +./tracex7 $DEVICE > +if [ $? -eq 0 ] > +then > + echo "SUCCESS!" > +else > + echo "FAILED!" > +fi > +losetup -d $DEVICE nice test! > diff --git a/samples/bpf/tracex7_kern.c b/samples/bpf/tracex7_kern.c > new file mode 100644 > index 000000000000..a2f74f736e66 > --- /dev/null > +++ b/samples/bpf/tracex7_kern.c > @@ -0,0 +1,15 @@ > +#include > +#include > +#include > +#include "bpf_helpers.h" > + > +SEC("kprobe/open_ctree") > +int bpf_prog1(struct pt_regs *ctx) > +{ > + unsigned long rc = -12; pls add empty line here. > + bpf_override_return(ctx, rc); > + return 0; > +}