From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D9CC4167E for ; Mon, 7 Feb 2022 09:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345318AbiBGJto (ORCPT ); Mon, 7 Feb 2022 04:49:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237536AbiBGJry (ORCPT ); Mon, 7 Feb 2022 04:47:54 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04F46C043181 for ; Mon, 7 Feb 2022 01:47:52 -0800 (PST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id B846E3F1A1 for ; Mon, 7 Feb 2022 09:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644227271; bh=02twp3uRHoEkWeARZkBktRJlx0WiVnvn489ap38/rX4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GxLlLYPkf5AUgewX/129+d+Z71VGdobKBl01l7tU57Wz6kxtIp8dkAcQNWLY0W6AO fr0vTm8GPlkdqov6CiasPrXRwnx4A3rcUgHzBQ7c/8qPsnaz15dTyRoKXTZru9Lwha S5lQZXAwFDrVAG05/maWrOlKhkDjum3ZfHQNqqa8Sm3UFkupZUJElRWXT7bJG5xWdw Yua+pp3q0qVnITa0DAqt8LcPxWKHSvK4GaQo/ZTMLnh105vC1Te9auTb216W7QaKAA kRkSXBL+UbxuJfCRRG+h7nvc3q1rgaYglQpT/CiMzFEAJCFL0DP/eoBJ7q1BMfn6ME /fhE2+lp1IXDg== Received: by mail-ej1-f70.google.com with SMTP id o7-20020a170906860700b006cbe6deec1bso404809ejx.22 for ; Mon, 07 Feb 2022 01:47:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=02twp3uRHoEkWeARZkBktRJlx0WiVnvn489ap38/rX4=; b=R2051hNxuhOzXL/2wZcBMRgEl7U0zapQp+RJoxMlUZbBL68jRKz3kvpqR3ibM1uJ71 S2w5XjQT2Pnag9ZmddQdu0AjroDD8M2Cl7pAb/HalPDLVCc1WCWf3o5+uP4ixAlSt2W5 AAcFLWUGywHVeSxcPor6CJgvibivTxpaUx7orP1dC/tqVhyjGIIQswQuH+Nl5PgRn5Cx wsKSw12QZQhwNhLYHS/l1GOp9jGvBHwuYgLH2rTLxmssyoG6gYAc+2YZBZnivXI3Turo iUfCmqO1J29n+/AQi7E/q9gFWGml+c+RG52z6JkEoZwEeeMWfTjeDKWvQiEB7AESNoiI ldfw== X-Gm-Message-State: AOAM533tgpnNq8YrxthovyyU6vzOnrHUs3lxUQy0sabt9D+QagkEKjRo hLrzEQqvlxT29Bs+BsFAlHsZglpinYGxWfnPbhTRRLP5A/gkMx9hfMMFa2j2dr6ctWP7xV/ZXZN 59ck3l+yood5K7+DkRajqrybtP6iTxSsVWKzg5R6tIQ== X-Received: by 2002:a17:907:9493:: with SMTP id dm19mr9140720ejc.51.1644227271456; Mon, 07 Feb 2022 01:47:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlQkvubOOEp5bPnxeLEugPVpKArS6HCKXpsaxcE4JL2I3U9CU5YCEJ+yy0TDGtA5tgBQyGKQ== X-Received: by 2002:a17:907:9493:: with SMTP id dm19mr9140706ejc.51.1644227271280; Mon, 07 Feb 2022 01:47:51 -0800 (PST) Received: from [192.168.0.86] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id nb16sm307441ejc.136.2022.02.07.01.47.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Feb 2022 01:47:50 -0800 (PST) Message-ID: Date: Mon, 7 Feb 2022 10:47:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] ARM: socfpga: fix missing RESET_CONTROLLER Content-Language: en-US To: Dinh Nguyen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Nathan Chancellor , kernel test robot , stable@vger.kernel.org References: <20220207084404.212017-1-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2022 10:45, Dinh Nguyen wrote: > > > On 2/7/22 02:44, Krzysztof Kozlowski wrote: >> The SocFPGA machine since commit b3ca9888f35f ("reset: socfpga: add an >> early reset driver for SoCFPGA") uses reset controller, so it should >> select RESET_CONTROLLER explicitly. Selecting ARCH_HAS_RESET_CONTROLLER >> is not enough because it affects only default choice still allowing a >> non-buildable configuration: >> >> /usr/bin/arm-linux-gnueabi-ld: arch/arm/mach-socfpga/socfpga.o: in function `socfpga_init_irq': >> arch/arm/mach-socfpga/socfpga.c:56: undefined reference to `socfpga_reset_init' >> >> Reported-by: kernel test robot >> Cc: >> Fixes: b3ca9888f35f ("reset: socfpga: add an early reset driver for SoCFPGA") >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/mach-socfpga/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig >> index 43ddec677c0b..594edf9bbea4 100644 >> --- a/arch/arm/mach-socfpga/Kconfig >> +++ b/arch/arm/mach-socfpga/Kconfig >> @@ -2,6 +2,7 @@ >> menuconfig ARCH_INTEL_SOCFPGA >> bool "Altera SOCFPGA family" >> depends on ARCH_MULTI_V7 >> + select ARCH_HAS_RESET_CONTROLLER >> select ARCH_SUPPORTS_BIG_ENDIAN >> select ARM_AMBA >> select ARM_GIC >> @@ -18,6 +19,7 @@ menuconfig ARCH_INTEL_SOCFPGA >> select PL310_ERRATA_727915 >> select PL310_ERRATA_753970 if PL310 >> select PL310_ERRATA_769419 >> + select RESET_CONTROLLER >> >> if ARCH_INTEL_SOCFPGA >> config SOCFPGA_SUSPEND > > Acked-By: Dinh Nguyen Hi Dinh, I was expecting you will pick it up. If you only ack, who is going to take it? Shall I send it directly to soc@? Best regards, Krzysztof