From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0204E275AFD for ; Wed, 7 Jan 2026 07:39:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767771587; cv=none; b=dwTDEtJ7FNboyxYdql5veeKFCAEqb6rJt1r8ysZYAlPx8n0LfHmbgJIqVnzwdGrmXwSJeg1IA/K94cdhO7tq8BMcE32pRZZ0GpmdKWX1/KxI6UTuIAUBc0oe+fR47sz9izZ1HEn0uDPVpKLf5v5Oh3qAYEELwF8y+g8HuUXgJJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767771587; c=relaxed/simple; bh=glPKfl8V1dLid4Uhk4Di9ZmvY/56MYsT7qi92tzjDvw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=swgoj0kt9WRCTC/Xxpd0OZw90r8W2L0JIq/Zjlm+NKlbl3TuJmo/tRpHBYgbt52+rKXx204AYiML70nF4fZsvlV+fYNlNuDu7lF7Kicd+KJEsiZPVm9kc76aaY2hTQ+IzauxUWgsJD3d6RyxpaeXuwo+/3IJLxnqEDPjGgV3c8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PPbAo4iP; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PPbAo4iP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B250C4CEF7; Wed, 7 Jan 2026 07:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767771586; bh=glPKfl8V1dLid4Uhk4Di9ZmvY/56MYsT7qi92tzjDvw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PPbAo4iPQi8SviPCmjcUeHBWBS8QE7ieS/V5eEyLAvCvAB+kBWPvP1LplTZ1Xnflf sqrXU3ULOiKZzqkETrLidsidrMEFWSxooIL3alcVfdFkLh3CIWe4K8suzrnxVBEGAY Od6Mq0DXs+74pMgYgLePQYdREGlsF3drtjjvrD/9xRuOfJ4wvf+mF9KrDjHQ3QRK5k 2m917ZpmvD+Ko++w6oW0awrzcfOxVH9/f4PDywk4q8r6WK+B3Q41XhsKtTkxF/Li/U lc9ZL07XWb4XEdTJRgGanFOnJCy3VoDY9oolxslROmuRc1MRH3UKs+WwLDiYEcllCX vJSOWZCdBTPiw== Message-ID: Date: Wed, 7 Jan 2026 08:39:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bus: fsl-mc: add missing fsl_mc_bus_dpdbg_type declaration To: Ioana Ciornei Cc: Laurentiu Tudor , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <2026010755-registrar-agreeably-a626@gregkh> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <2026010755-registrar-agreeably-a626@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Ioana, Le 07/01/2026 à 06:30, Greg Kroah-Hartman a écrit : > On Tue, Jan 06, 2026 at 07:54:21PM +0100, Christophe Leroy (CS GROUP) wrote: >> Fix following sparse warning: >> >> CHECK drivers/bus/fsl-mc/fsl-mc-bus.c >> drivers/bus/fsl-mc/fsl-mc-bus.c:435:26: warning: symbol 'fsl_mc_bus_dpdbg_type' was not declared. Should it be static? >> >> As it is exported it can't be static. So declare it in mc.h like >> all other similar objects. >> >> Fixes: e70ba1b06c26 ("bus: fsl-mc: add the dpdbg device type") >> Signed-off-by: Christophe Leroy (CS GROUP) >> --- >> include/linux/fsl/mc.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h >> index 897d6211c1635..28441a456bb48 100644 >> --- a/include/linux/fsl/mc.h >> +++ b/include/linux/fsl/mc.h >> @@ -451,6 +451,7 @@ extern const struct device_type fsl_mc_bus_dpdcei_type; >> extern const struct device_type fsl_mc_bus_dpaiop_type; >> extern const struct device_type fsl_mc_bus_dpci_type; >> extern const struct device_type fsl_mc_bus_dpdmai_type; >> +extern const struct device_type fsl_mc_bus_dpdbg_type; > > As it's obviously not used anywhere, this should not be the fix, please > just mark it static and remove the EXPORT_SYMBOL_GPL() as well. What's your opinion here as Maintainer of this driver, what should we do ? Greg is right that it is nowhere used, and it is the same for several other types, the only difference being that they have a matching is_fsl_mc_bus_dp..() helper that hides the type, but not all helpers are used, and many of them are not used outside drivers/bus/fsl-mc/ which cannot be built as a module: $ git grep is_fsl_mc_bus_ drivers/bus/fsl-mc/dprc-driver.c: if (!is_fsl_mc_bus_dprc(mc_dev)) drivers/bus/fsl-mc/dprc-driver.c: if (!is_fsl_mc_bus_dprc(mc_dev)) drivers/bus/fsl-mc/fsl-mc-allocator.c: return is_fsl_mc_bus_dpbp(mc_dev) || drivers/bus/fsl-mc/fsl-mc-allocator.c: is_fsl_mc_bus_dpmcp(mc_dev) || drivers/bus/fsl-mc/fsl-mc-allocator.c: is_fsl_mc_bus_dpcon(mc_dev); drivers/bus/fsl-mc/fsl-mc-allocator.c: if (is_fsl_mc_bus_dprc(mc_dev)) drivers/bus/fsl-mc/fsl-mc-allocator.c: if (is_fsl_mc_bus_dprc(mc_dev)) drivers/bus/fsl-mc/fsl-mc-bus.c: if (is_fsl_mc_bus_dprc(mc_dev) || drivers/bus/fsl-mc/fsl-mc-bus.c: is_fsl_mc_bus_dpmcp(mc_dev)) { drivers/bus/fsl-mc/fsl-mc-bus.c: } else if (is_fsl_mc_bus_dpio(mc_dev)) { drivers/bus/fsl-mc/fsl-mc-bus.c: if (is_fsl_mc_bus_dprc(mc_dev) && drivers/bus/fsl-mc/fsl-mc-bus.c: if (is_fsl_mc_bus_dprc(mc_dev)) drivers/vfio/fsl-mc/vfio_fsl_mc.c: int no_mmap = is_fsl_mc_bus_dprc(mc_dev); drivers/vfio/fsl-mc/vfio_fsl_mc.c: if (is_fsl_mc_bus_dprc(vdev->mc_dev)) { drivers/vfio/fsl-mc/vfio_fsl_mc.c: if (is_fsl_mc_bus_dprc(mc_dev)) drivers/vfio/fsl-mc/vfio_fsl_mc.c: if (!is_fsl_mc_bus_dprc(mc_dev)) { drivers/vfio/fsl-mc/vfio_fsl_mc.c: if (!is_fsl_mc_bus_dprc(mc_dev)) drivers/vfio/fsl-mc/vfio_fsl_mc.c: if (!is_fsl_mc_bus_dprc(mc_dev)) drivers/vfio/fsl-mc/vfio_fsl_mc.c: if (is_fsl_mc_bus_dprc(mc_dev)) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dprc(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpni(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpio(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpsw(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpdmux(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpbp(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpcon(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpmcp(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpmac(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dprtc(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpseci(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpdcei(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpaiop(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpci(const struct fsl_mc_device *mc_dev) include/linux/fsl/mc.h:static inline bool is_fsl_mc_bus_dpdmai(const struct fsl_mc_device *mc_dev) And the only outside user is drivers/vfio/fsl-mc/vfio_fsl_mc.c which can be a module, but has been orphaned by commit af6605f87ca5 ("MAINTAINERS: Orphan vfio fsl-mc bus driver") and scheduled for removal by commit 1b1d9ca13475 ("vfio/fsl-mc: Mark for removal") Christophe