From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Joseph S. Barrera III" <joebar@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Douglas Anderson <dianders@chromium.org>,
Alexandru M Stan <amstan@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v8 1/5] arm64: dts: qcom: sc7180: Add wormdingler dts files
Date: Fri, 17 Jun 2022 17:32:17 -0700 [thread overview]
Message-ID: <a664b2a9-3cfa-9e8d-039a-bdd3b7448170@linaro.org> (raw)
In-Reply-To: <20220617164000.v8.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid>
On 17/06/2022 16:40, Joseph S. Barrera III wrote:
> Wormdingler is a trogdor-based board, shipping to customers as the
> Lenovo IdeaPad Chromebook Duet 3. These dts files are copies from
> the downstream Chrome OS 5.4 kernel, but with the camera
> (sc7180-trogdor-mipi-camera.dtsi) #include removed.
>
> Signed-off-by: Joseph S. Barrera III <joebar@chromium.org>
>
> ---
>
> (no changes since v7)
>
> Changes in v7:
> - Incorporated changes from Stephen's "Simplify!" series.
>
> Changes in v5:
> - Replaced _ in node name with -
> - Ordered nodes by name
>
> Changes in v4:
> - Cleaned up rt5682s files
> - Restored camcc definition
> - Added missing version history
>
> Changes in v3:
> - Removed camcc definition
>
> Changes in v2:
> - Word wrapped patch description.
> - Removed "Author" from patch description.
> - Fixed whitespace around "en_pp3300_dx_edp"
>
> arch/arm64/boot/dts/qcom/Makefile | 6 +
> .../sc7180-trogdor-wormdingler-rev0-boe.dts | 22 +
> .../sc7180-trogdor-wormdingler-rev0-inx.dts | 22 +
> .../qcom/sc7180-trogdor-wormdingler-rev0.dtsi | 53 +++
> ...0-trogdor-wormdingler-rev1-boe-rt5682s.dts | 29 ++
> .../sc7180-trogdor-wormdingler-rev1-boe.dts | 28 ++
> ...0-trogdor-wormdingler-rev1-inx-rt5682s.dts | 29 ++
> .../sc7180-trogdor-wormdingler-rev1-inx.dts | 22 +
> .../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 408 ++++++++++++++++++
> 9 files changed, 619 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-inx.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-boe.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev1-inx.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 2f8aec2cc6db..e4114e22548a 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -81,6 +81,12 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r2-lte.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r3.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r3-lte.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev0-boe.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev0-inx.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-inx.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts
> new file mode 100644
> index 000000000000..d6ed7d0afe4a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-wormdingler-rev0-boe.dts
> @@ -0,0 +1,22 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Wormdingler board device tree source
> + *
> + * Copyright 2021 Google LLC.
> + *
> + * SKU: 0x10 => 16
> + * - bits 7..4: Panel ID: 0x1 (BOE)
> + */
> +
> +/dts-v1/;
> +
> +#include "sc7180-trogdor-wormdingler-rev0.dtsi"
> +
> +/ {
> + model = "Google Wormdingler rev0 BOE panel board";
> + compatible = "google,wormdingler-rev0-sku16", "qcom,sc7180";
There was a v6 a second ago, now it is v8... It's confusing. Don't send
too often, especially without incorporating actual review.
You need to document the compatibles. Please base on Doug's patches
adding the compatibles for existing boards.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-18 0:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 23:40 Joseph S. Barrera III
2022-06-17 23:40 ` [PATCH v8 2/5] arm64: dts: qcom: sc7180: Add quackingstick " Joseph S. Barrera III
2022-06-18 0:15 ` Doug Anderson
2022-06-17 23:40 ` [PATCH v8 3/5] arm64: dts: qcom: sc7180: Add mrbland " Joseph S. Barrera III
2022-06-17 23:40 ` [PATCH v8 4/5] arm64: dts: qcom: sc7180: Add pazquel " Joseph S. Barrera III
2022-06-18 0:16 ` Doug Anderson
2022-06-17 23:40 ` [PATCH v8 5/5] arm64: dts: qcom: sc7180: Add kingoftown " Joseph S. Barrera III
2022-06-18 0:16 ` Doug Anderson
2022-06-18 0:14 ` [PATCH v8 1/5] arm64: dts: qcom: sc7180: Add wormdingler " Doug Anderson
2022-06-21 4:03 ` Joseph S. Barrera III
2022-06-18 0:32 ` Krzysztof Kozlowski [this message]
2022-06-18 15:16 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a664b2a9-3cfa-9e8d-039a-bdd3b7448170@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=amstan@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=joebar@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®