From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbdBBKvE (ORCPT ); Thu, 2 Feb 2017 05:51:04 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38292 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbdBBKvC (ORCPT ); Thu, 2 Feb 2017 05:51:02 -0500 Subject: Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm To: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1486028864-19622-1-git-send-email-narmstrong@baylibre.com> <1486028864-19622-3-git-send-email-narmstrong@baylibre.com> <20170202104514.nogjnsuimeulml53@phenom.ffwll.local> From: Neil Armstrong Organization: Baylibre Message-ID: Date: Thu, 2 Feb 2017 11:50:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20170202104514.nogjnsuimeulml53@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/2017 11:45 AM, Daniel Vetter wrote: > On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote: >> The platform driver name is currently "meson" which can lead to some >> confusion, this patch renames it to "meson-drm" and removes the owner >> attribute. >> >> Signed-off-by: Neil Armstrong >> --- >> drivers/gpu/drm/meson/meson_drv.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c >> index ff1f601..380bde7 100644 >> --- a/drivers/gpu/drm/meson/meson_drv.c >> +++ b/drivers/gpu/drm/meson/meson_drv.c >> @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev) >> .probe = meson_drv_probe, >> .remove = meson_drv_remove, >> .driver = { >> - .owner = THIS_MODULE, Hi Daniel, > I don't get why you remove this, generally that will lead to trouble of > being able to unload code that's still in use ... Indeed, but since a (long ?) time, the owner field is now populated by the platform_driver_register() core code. > > Otherwise ack. > > Now, do you want to get this landed as part of the small drivers in > drm-mis experiment? I have a PR ready, but it can go through this experiment, yes. > -Daniel > >> - .name = DRIVER_NAME, >> + .name = "meson-drm", >> .of_match_table = dt_match, >> }, >> }; >> -- Thanks, Neil