From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756231AbcIAVQI (ORCPT ); Thu, 1 Sep 2016 17:16:08 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:38093 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbcIAVQE (ORCPT ); Thu, 1 Sep 2016 17:16:04 -0400 Subject: Re: [PATCH 9/9] serial/arc: constify uart_ops structures To: Julia Lawall References: <1472752298-981-1-git-send-email-Julia.Lawall@lip6.fr> <1472752298-981-10-git-send-email-Julia.Lawall@lip6.fr> CC: Greg Kroah-Hartman , , , , Jiri Slaby , Newsgroups: gmane.linux.kernel.arc,gmane.linux.kernel.janitors,gmane.linux.kernel,gmane.linux.serial From: Vineet Gupta Message-ID: Date: Thu, 1 Sep 2016 11:49:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472752298-981-10-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.130.78] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2016 10:51 AM, Julia Lawall wrote: > Check for uart_ops structures that are only stored in the ops field of a > uart_port structure. This field is declared const, so uart_ops structures > that have this property can be declared as const also. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct uart_ops i@p = { ... }; > > @ok@ > identifier r.i; > struct uart_port e; > position p; > @@ > e.ops = &i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct uart_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct uart_ops i = { ... }; > // > > Signed-off-by: Julia Lawall Acked-by: Vineet Gupta Thx for making it better Julia ! -Vineet > > --- > drivers/tty/serial/arc_uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c > index 3a1de5c..5ac06fc 100644 > --- a/drivers/tty/serial/arc_uart.c > +++ b/drivers/tty/serial/arc_uart.c > @@ -464,7 +464,7 @@ static int arc_serial_poll_getchar(struct uart_port *port) > } > #endif > > -static struct uart_ops arc_serial_pops = { > +static const struct uart_ops arc_serial_pops = { > .tx_empty = arc_serial_tx_empty, > .set_mctrl = arc_serial_set_mctrl, > .get_mctrl = arc_serial_get_mctrl, >