From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C82FA2367BA for ; Fri, 30 May 2025 17:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748625598; cv=none; b=mxSo5+xzwOzRzu6FIqio9V9/hDeiEO7nP/ZfygBX+qjP/yliK04ERph2PwzYqUokjDELhvh+id+eTFtC02F0erxqpKAeOlaD/vkfkiIghR6zoF3wWX7lTbM63zbjmiQ8J/8r78ihTKt6+qBYHiF1hdqg3KGHgP+gdpGTd+wEO1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748625598; c=relaxed/simple; bh=HMRcBPxFLRL8zWucCrFR6eiWaxDm26zk91Pn6r5m0SQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZAtyZTZnN+bCi9Q2hBAa1Y3/bfh9TZZCrsH7+FbmAfe3jHTHECIHXl97p3jkt1uY0S5wBhFl38JwcBgg++ghN3E4jkh+neppN7vFDF1ynAX0X3wNH3sIuAkKeT7McQa26EOcjWwY8Hyp0uYpX8HDCPFOAvsG9RP+Pf2OiKVXaoU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=WNOPIDUV; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="WNOPIDUV" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2e4bbd9cad6so1245244fac.0 for ; Fri, 30 May 2025 10:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1748625596; x=1749230396; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hl3zg7f8gq+l5qG5ruPbpuE3dBxZAj6EU7u8jCcyDSI=; b=WNOPIDUVeE2YKlkm2fPv+ED5hpEx6PWHF8ZiHSCxWdwOrJ7623nA+M19KKjbcoxFep K+ozGP8NWQ9bLv/xYGTqMHGJNsF1We7RpJ8pPKyygIO7nMA5Sk7jn48AhHXxk72mqFxC Kqdcp/Pw9xMnx6cS5Xb5qbDiZVxHZ0MKAT9aCQLcvqIwwD5hpiUgYgVGTV8/A5U0YphU UetP+NzoM5RNdEvFLbWwRW2dfi85OSj2yYhErEo9SkYPBPKFM7M3tFCba24sV6+RADY7 ynerLCbEJj2jrvP35cQlnPX2FwSLmy+OL85Wkzks+490s9XTZpiZQsm+HvXjAP77OHuE fEoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748625596; x=1749230396; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hl3zg7f8gq+l5qG5ruPbpuE3dBxZAj6EU7u8jCcyDSI=; b=UQEG+OwTGJ3owwx6LAZwAg0Hbq7SE5YfAekpSkujD3qvPuPOLInwXkXaYnnHrcyiiE yEordn4V17hZissJ0w6EDlWLhaxlSDG84HGemXuO99UbO9TzGF+mVomAv2NB1YrmOvRn +75qriIGpnATDZ1NyKTcpE0kUx4YNVW+gVqV+2QL+KLw3/TteMGU20b7Fof9ZN62dp1O D1Dz7+MIq4r3gX9n3/6VfhclXlQm5KosV2nRPc8V7DA+ElpYNrVZvpiBW/KdkuzIRxui FL9wjChFE/0Py3kMdfHeb2lniLF8gNU1AtWgQY8D7Xe8BdIv7ITLqaOCcU4Z+EcKpQjJ ZlMA== X-Forwarded-Encrypted: i=1; AJvYcCUnWwzzEOy7OI6nMPwVB83xoyWWKPp9pchw72IXpbdIyR+k1+bNpOWZBzcOcRROjsT9uuAmUTYjQa4QWcs=@vger.kernel.org X-Gm-Message-State: AOJu0YzevGCZ0YFBYBTTZUqEMGAq0mTtOGRNcbvPMOeHkqfxnZxKNK/o oXNb41H+eySJRH0chuWAgWg18/QhYEN4zOk+OLasg2kG7A7WJU62xAh0l3OkJb/q/B4= X-Gm-Gg: ASbGncshu4hxLQXEQIAmalzBrPJngVBhMWiP+8zW6UsRQr1LM5qYXldY3XXq76Rm39r g17BDDkH3JgqGgzwB1ewErXvkwUCzBZ5LvqtxqqgZIjw30Fup1x8qjZUp5rjdSwuaq/KQnICmYY +66IPOVSH+Do8iQjWqXqrKIcSLTWTWcbT6pViV3ul9JTxASOA8pG/9sWDzuCI0OSBvbgaTSaYB2 tszW76mJ3e/jJmwTULl/9jENFoCEYJYrInArfxCI/SKEjufAiitqWxkv967t9MbdSmpCAYk8Zss LXtWTudwfrL+W/cAu1HHwAOGDe3KvMCRDUxzmrx8EIn8Ory7TjAMEczPuNQznpAOxJKprE0HUTK bJqKNpCVjJgAb/u3ZbFPiNDCCDbH/ X-Google-Smtp-Source: AGHT+IFn+WqN0pov0ImkTs3JeWNX+a1ksqlo179uhSF9zJMLQZ+WbUztQFApqGLg2Obw3Fz5phANlw== X-Received: by 2002:a05:6871:4f14:b0:2d5:2534:ac19 with SMTP id 586e51a60fabf-2e9211a87e7mr2245882fac.4.1748625595764; Fri, 30 May 2025 10:19:55 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:29cb:b1cd:c8f4:2777? ([2600:8803:e7e4:1d00:29cb:b1cd:c8f4:2777]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2e9067a57afsm719360fac.11.2025.05.30.10.19.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 10:19:55 -0700 (PDT) Message-ID: Date: Fri, 30 May 2025 12:19:53 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/6] iio: adc: ad7606: add gain calibration support To: Angelo Dureghello , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250526-wip-bl-ad7606-calibration-v7-0-b487022ce199@baylibre.com> <20250526-wip-bl-ad7606-calibration-v7-6-b487022ce199@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: <20250526-wip-bl-ad7606-calibration-v7-6-b487022ce199@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/26/25 5:03 AM, Angelo Dureghello wrote: > From: Angelo Dureghello > > Add gain calibration support, using resistor values set on devicetree, > values to be set accordingly with ADC external RFilter, as explained in > the ad7606c-16 datasheet, rev0, page 37. > > Usage example in the fdt yaml documentation. > > Tested-by: David Lechner > Reviewed-by: Nuno Sá > Signed-off-by: Angelo Dureghello > --- ... > +static int ad7606_chan_calib_gain_setup(struct iio_dev *indio_dev) > +{ > + struct ad7606_state *st = iio_priv(indio_dev); > + unsigned int num_channels = st->chip_info->num_adc_channels; > + struct device *dev = st->dev; > + int ret; > + > + device_for_each_child_node_scoped(dev, child) { > + u32 reg, r_gain; > + > + ret = fwnode_property_read_u32(child, "reg", ®); > + if (ret) > + return ret; > + > + /* Chan reg is a 1-based index. */ > + if (reg < 1 || reg > num_channels) > + return ret; Shouldn't this return -EINVAL? Otherwise, it will return success for an out of range reg number and skip any addition child nodes. > + > + r_gain = 0; > + ret = fwnode_property_read_u32(child, "adi,rfilter-ohms", > + &r_gain); > + if (r_gain > AD7606_CALIB_GAIN_MAX) > + return -EINVAL; > + > + ret = st->bops->reg_write(st, AD7606_CALIB_GAIN(reg - 1), > + DIV_ROUND_CLOSEST(r_gain, AD7606_CALIB_GAIN_STEP)); > + if (ret) > + return ret; > + } > + > + return 0; > +} > +