mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Nadav Amit <namit@vmware.com>, kernel test robot <rong.a.chen@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Lutomirski <luto@amacapital.net>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Jessica Yu <jeyu@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Rik van Riel <riel@surriel.com>,
	LKML <linux-kernel@vger.kernel.org>, "lkp@01.org" <lkp@01.org>
Subject: Re: [x86/modules] f2c65fb322: will-it-scale.per_process_ops -2.9% regression
Date: Fri, 19 Jul 2019 10:05:01 -0700	[thread overview]
Message-ID: <a66f8f04-7ccc-d72a-4905-f21347c1f8e1@intel.com> (raw)
In-Reply-To: <52D013BF-9B4B-4D03-B56F-3F378E4A2BA4@vmware.com>

On 7/18/19 10:59 AM, Nadav Amit wrote:
> I don’t understand how this patch has any impact on this workload.
> 
> I ran it and set a function tracer for any function that is impacted by this
> patch:
> 
>   # cd /sys/kernel/debug/tracing
>   # echo text_poke_early > set_ftrace_filter
>   # echo module_alloc >> set_ftrace_filter
>   # echo bpf_int_jit_compile >> set_ftrace_filter
>   # tail -f trace
> 
> Nothing came up. Can you please check if you see any of them invoked on your
> setup? Perhaps you have some bpf filters being installed, although even then
> this is a one-time (small) overhead for each process invocation.

I think the direct map's structure changed.  I noticed the following the
0day data:

> 7298e24f904224fa f2c65fb3221adc6b73b0549fc7b 
> ---------------- --------------------------- 
>        fail:runs  %reproduction    fail:runs
>            |             |             |    
>            :4           50%           2:4     dmesg.WARNING:at#for_ip_interrupt_entry/0x
>          %stddev     %change         %stddev
>              \          |                \  
>   10541056 ±  7%     +12.1%   11820032        meminfo.DirectMap2>  2.909e+08           -12.0%   2.56e+08 ±  2%  perf-stat.i.iTLB-load-misses
>       1876           +10.4%       2071 ±  2%  perf-stat.i.instructions-per-iTLB-miss
>       1872           +10.4%       2068 ±  2%  perf-stat.overall.instructions-per-iTLB-miss
>  2.899e+08           -12.0%  2.551e+08 ±  2%  perf-stat.ps.iTLB-load-misses

So something with the direct map changed as did iTLB miss behavior.

      reply	other threads:[~2019-07-19 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18  9:50 kernel test robot
2019-07-18 17:59 ` Nadav Amit
2019-07-19 17:05   ` Dave Hansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a66f8f04-7ccc-d72a-4905-f21347c1f8e1@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jeyu@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namit@vmware.com \
    --cc=peterz@infradead.org \
    --cc=rick.p.edgecombe@intel.com \
    --cc=riel@surriel.com \
    --cc=rong.a.chen@intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®