From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79C8A39185A for ; Mon, 4 May 2026 10:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889338; cv=none; b=La0PRxPBy8Tk2b9fUGGsRyME54uMybTKG5x80J3t/EDi8DnpAX54FXZcXVg6Hjkihdp5n+keGIJ4SOU/w9OYqkqqIocf/taAZSCD3jx4fi067qAFm/sYeSdXseGOoSlxtEZmnP9ZD1Q33ho9Wu3Lx45Q5Zlq/9pKcdmKR0WojCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889338; c=relaxed/simple; bh=uzVYR2oxORfswsKO5073AqMtFJIBGpVKkfVCVIKVeRc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ON3+7jCKfSIguoOy/S+IkKlmp3bXuNx6T24Em31x63D84Sl7AReHEAbGS8aw4QVEs3Zo33AARJq37o3SjO0IA/nfy0DMFZZnTXmMBX5nhEoujK4Y8jUijs3gYau1a8AVUJ44YF+d4vQ6XFbG5IBuwUH3Pe4yr3NyyfcVFvZUw1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=feK+iruv; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="feK+iruv" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-38def541b0bso35539291fa.1 for ; Mon, 04 May 2026 03:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777889332; x=1778494132; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8ejlKc5ArUlrjZTG0qqBOiFFqj7qKQRkSb3mwVckWx0=; b=feK+iruvb0ALyN0MADYxSac4gGLl7iEq0HanQj2RruHck/yCuiTPXK283kX+4MgmTZ 6zjO1Dmn+nyvuaFQ8XDxP2XMEMuLUnPBb4ZDhvyabmqr1JuGszN6AYw7ontpd/S+N7E7 ce7tndGDrKu/89VbkIxc5/qpzzhmJ8tsN8yJ5zMFJ2V+m2BAqkKxC9Y9zPLsDQ79Okhs H3iIIRe1NRkiyjCXk4P+b2VUK4TZUNkdRAGOn66GHEA1yhp5Xe0TkMA/GIsJFe5qQx9M NLfwjRw1RaoAqadmgFdFOwj0JX23mvyG/E0jCgt95wHwO2swHFIoN0r6UVndWCLHlcf2 Cb+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777889332; x=1778494132; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8ejlKc5ArUlrjZTG0qqBOiFFqj7qKQRkSb3mwVckWx0=; b=JfVj+nF8Msw6QcXP9+YBU0eVlEQUXsG38/Nsld8EWfiFFMU904AMge5AnADd0Qap3y xPqWe/CajZ7hku1dhpIJyuXA1Z9zZgeieh0ul5/LGPEjeGwzMxh6LZyGR3HkUoMw27cf 3fAaS/kMBA+thnLFv6s+1U+9j4ehqvaYIrnmBYcshwrdAY3TgD8mGMPALBq2Pn4hUXM4 vF8PrfQU3nx8CSjldN4+ERWcTDwSPFeNgUVnngIIDyBY88ESsde1iVy/mXFFEhhEEDXj 6CUZpXPRC+K27xfutug4fVj1bGrvWWxZNdDNCngJ2rfmJ+zmK0YEHsZ08MbCNN8BfZNd Bc1A== X-Gm-Message-State: AOJu0YyxvJubuf1kTyvgOVTeJEMHUHE/cPb7yiQScpzqLyreD74SUGl1 XncBrknEXQQzLoryORkSwgKiWHCUiV2Ve3oROmeN6192yzzj1ePpgSV+f8Ygztx0g+6y0RjiXhE = X-Gm-Gg: AeBDietnyj+jn0afM6378bcNtPqRH5OJWbREGCOb7mykE2aAPEqYzgLL2+JT1zh2/oi L8DWBjkzNHGQ3OyInF8pdNPPIZdTgOkhQZtOw0DmIRdrQf1KFbwVfsia3sYHV7I5RC6AkAJnGWB f382HjWGbcw23pUMZu9dFuBC6aUKlCqMgy8emG7V1wLeIyqr9yHvUVt6J17sDokc0joWVZbXZDR 6DVzHj4RXPlXvLxavHSBpQmELy+WTlAXk6O0vgGnF7EQ4NEUrTM7SGVrERn/rcFS5ZLThhZ1OWQ lx4ZDeaNA5AEZRmwFcSZ1Lnvzo8rG21rwxcfHATWm8EP5+Qw8cKgVUlaxRKEAWXgUGTVE29gI1w s9636dvoLmkiDRymjqF7Zg6sHIBZbgetQHbOcYWVWVs9m0yOOHQmHHNWwWgec1UDUPp6jpoVTT8 7xPDHa3jUgGXWlUWEVHzLlBHm9c630v0loKnO0ZRajS+6FaVjfpgsEmcLUlU5l6knpbnEDixg= X-Received: by 2002:a05:6512:1250:b0:5a4:1198:5016 with SMTP id 2adb3069b0e04-5a862ec11a7mr2894531e87.11.1777889331651; Mon, 04 May 2026 03:08:51 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a86645ae7csm1979099e87.79.2026.05.04.03.08.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 03:08:51 -0700 (PDT) From: Vastargazing To: linux-kernel@vger.kernel.org Cc: Vastargazing , stable@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Anatolij Gustschin , Andrew Morton Subject: [PATCH 1/5] misc: eeprom: digsy_mtc: fix reference leak on failed device registration Date: Mon, 4 May 2026 13:08:43 +0300 Message-ID: X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When platform_device_register() fails in digsy_mtc_eeprom_devices_init(), the embedded struct device has already been initialized by device_initialize() inside platform_device_register(). The failure path cleans up the software node but returns the error without dropping the device reference: digsy_mtc_eeprom_devices_init() -> platform_device_register(&digsy_mtc_eeprom) -> device_initialize(&digsy_mtc_eeprom.dev) /* kref = 1 */ -> platform_device_add(&digsy_mtc_eeprom) /* fails */ <- returns error, kref still 1, reference leaked Per platform_device_register() kernel-doc: NOTE: _Never_ directly free @pdev after calling this function, even if it returned an error! Always use platform_device_put() to give up the reference initialised in this function instead. Fix this by calling platform_device_put() in the error branch before removing the software node. Fixes: 469dded18391 ("misc/eeprom: add eeprom access driver for digsy_mtc board") Cc: stable@vger.kernel.org Assisted-by: GitHub Copilot (Claude Sonnet 4.5) Signed-off-by: Vastargazing --- drivers/misc/eeprom/digsy_mtc_eeprom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/eeprom/digsy_mtc_eeprom.c b/drivers/misc/eeprom/digsy_mtc_eeprom.c index ee58f7ce5bfa..4ca3e567c49d 100644 --- a/drivers/misc/eeprom/digsy_mtc_eeprom.c +++ b/drivers/misc/eeprom/digsy_mtc_eeprom.c @@ -89,8 +89,10 @@ static int __init digsy_mtc_eeprom_devices_init(void) return ret; ret = platform_device_register(&digsy_mtc_eeprom); - if (ret) + if (ret) { + platform_device_put(&digsy_mtc_eeprom); device_remove_software_node(&digsy_mtc_eeprom.dev); + } return ret; } -- 2.51.0