From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC5B26F28A for ; Thu, 27 Nov 2025 18:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764268811; cv=none; b=aH3fxd57JH/tbtnCVjOLguapLwS5G67fwqiyTgBd4TYGUlS8txkt/eoTxBmEvVm0wBCRYaTvO1wxexKejiwsAHSgHuLyY/EJhyubOKfG2z4EtGjMxbxXBPwEb1zFlizOGSGZzJD6T3/iMqcMAJ5jP0X4FQ0QMk/dkGxNkHFUm3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764268811; c=relaxed/simple; bh=wyFS8spSqZWn+/cG9dlErAMQS76HMdPbjHRQHZPfCD8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dr7/sGmM5v008r+MFm1QZTsKnc/p3k4c8CWURLmJ9SkaAsO5bl61PXvrnUnRwTXCIfvgtlA/KogGbFu8wNUwcBpEPgmmcJMEPFjT7pMNlSl6HQrEfVTbBeMZiev5whagOtwkWgy/08DCU1lCGzTo74XbcbURnYx1/5XA8rYK1dY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BgbjNIwB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GsKuK7pG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BgbjNIwB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GsKuK7pG" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ARA3ZW3848490 for ; Thu, 27 Nov 2025 18:40:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4JE8GdFgY/lBsXFFVF1PdHAx37kWrNNokkrKmrbQUYM=; b=BgbjNIwBSXw4lqKd ITY8pUxXObH8grFPsJQ/dJeecRINT3oabnMqJY02HuXbaHBLjEwb+SLMBZ7VUY/A q+Cp+Jq+WGZDz5udmr7/eUa7f2exUsmH7PAL21weo8JMF7VAZ42OS2XRa61Xzdnu mA9WUFIIZQEFCfCRibJPQMLAh6seYbRzxtoAtT8YlNDHtgSfMr/+ydQp017y4CuE mKWmsMakXpuVqxRmiktugVA5K92k4k6fkSamBGio35e5AapwjlkWMUUjARXG98H+ O59lH3YqIaw96nCrqrl242Xq4qsF0dmJsx+C3RoJt0AGv1gGYTbBijZXWPniscuc d6NZcw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apmjd97d8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Nov 2025 18:40:09 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ee00f2b7d7so2883121cf.0 for ; Thu, 27 Nov 2025 10:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764268809; x=1764873609; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4JE8GdFgY/lBsXFFVF1PdHAx37kWrNNokkrKmrbQUYM=; b=GsKuK7pGRLLAQaZ/5joWkZJHAd5eAtIAMDRaYFASRxiaVMosC+nQf3qTMAVPmAsHz3 uhBna116L/HHRCtFv+5F1S/0d3XAhCQsGQ+BqO9Hj42DzmUwr6SoRV4RiHDM1GkCwVh5 u0ISwDYC9/GOa3OoEf8EyFTn1xOy/ubf8nsuIWVtdT1kjRsB3vNiKSPdowGlXsdz/64D jITY6AXv1xHQbFXb26chvXUSz8NmfqugMK/iAONO9c03tNl7bI96f4FMz1Xat0ZHWB1S ne2dfbIMBItLK4z826mMDout8dnR1eQnaYeduOFz/SzD1+fgClbPTthe959ppCs/q111 GqBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764268809; x=1764873609; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4JE8GdFgY/lBsXFFVF1PdHAx37kWrNNokkrKmrbQUYM=; b=IdccH4tq+q0F9NuHrg7cUtFuayoDIpuF2wW3dlVX4D3xzComXNCdKIGvN6gT6s7xES 9hSbJnSCt4APNH5fYplj4KfceQ0zGz3RNA4J8GZMWY/oO0PsheLQ1+HwTd88NWI9fOEB cr0KQXPyFSsoFc26PqalyLcaEDnzcE1/k9ThJXJCqEJkyMfpM30zUOP/mMCnwdMYqXAZ FlqU0TkaBckf4BjG+8TVQ/6mxDvvbYc1S6QFhr/6GHFBEEy/SD1WxdXjHtOYC2gajNIx JRvrHvWDvz842JNBJD5ECk1Wk+0gRjiPyNEeR1xfu8G9piGjXvER7AafcibnHTn9gGm3 MR2g== X-Forwarded-Encrypted: i=1; AJvYcCVhVqaYzjsanxi0nQps0VD0VJgkyUEIufnmnumQOJU411J7Y63fFgW6yoriVCt22QATmu4exLV5sboOWOc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq3wccqNuoE/MtzRaZEBPvJDS4sNVlXiufR0v4R5ZngpLbVyN3 t7NJWmWCX/gLXnYJhyy6eKlKFwvaGmQ+coRkbm7dEekHIorL+xzzCHb3LCGN61Ly1nsYp6CJx+p L9Ril6TyRG2veoCx4N32RrzPAIn51OZ3WHocCO3JBGHixm1QNs7Aj1jGcr9HG2weyDmY= X-Gm-Gg: ASbGncvUOzonJspdO1dVwLPxPvUBuWmlmcBoTSKWaSDkfv5WbR45vXHaSIxkgbwyt3R N2JvQjPNIU0RbIxq7s0xVnc5wCEzW1HsgVjQOmRo0Eqpks1y5svOQQ4jwFPOHRG32MSU3ldVJXj n8WYW5H38PWiFGu3Qzt970+30fim09D9FGsxroCRVAxNRcdCDKZYqnS3SClmP6GhnLB80fLmkXX GArPJJ5Y0T7ZCStiM0Iq10NwN+tLjjYWfJ783r9hgfXNN+Ja7BLsxPOx8DkjNZydIKx2nIyveal 2SpTzKEwXce4SE0Ac5ZfxjUqbuQFCsRpqJTyZmxxQXmhpkcvErgYSz0xOS9rJ5VL1qe0zjhB+/e eUKJM27T11ozWaWG2BAwzL32EKdWt1Y2WGPCpnIQOshZUGMUo1uBjvpHm8EG/ojZTgOg= X-Received: by 2002:a05:622a:c3:b0:4ee:2580:9bc5 with SMTP id d75a77b69052e-4ee5883ae04mr263262431cf.2.1764268808746; Thu, 27 Nov 2025 10:40:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyUFH7H352RTWbh5g726JBPXmn/y8Uo1Oe4zNmxCviaA8u5s/V5GnQbd0HzftLjmmntQoIKg== X-Received: by 2002:a05:622a:c3:b0:4ee:2580:9bc5 with SMTP id d75a77b69052e-4ee5883ae04mr263262121cf.2.1764268808359; Thu, 27 Nov 2025 10:40:08 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f51c8393sm234863766b.31.2025.11.27.10.40.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 10:40:07 -0800 (PST) Message-ID: Date: Thu, 27 Nov 2025 19:40:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs To: Manivannan Sadhasivam , Bjorn Helgaas Cc: Manivannan Sadhasivam , bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Bogoslavsky , Jeffrey Lien , Avinash M N References: <20251120161253.189580-1-mani@kernel.org> <20251124235307.GA2725632@bhelgaas> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: gI3stqmpJBjZjj04uP4HZStZKA5YG5pr X-Proofpoint-ORIG-GUID: gI3stqmpJBjZjj04uP4HZStZKA5YG5pr X-Authority-Analysis: v=2.4 cv=OPcqHCaB c=1 sm=1 tr=0 ts=69289b09 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bKK-hE_CYPLHlUXilesA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI3MDE0MCBTYWx0ZWRfXxr68hYXWKmB9 UL4KyjdnPEdcyLNoXcm7683cNC59XpvtJllIJLV09+ytXSsC4WgfZ+FgA+gcQvFHClz7qHVGhFy zE4jveYRR5I+JTpVa8QbChEcFuWJh/PKD6VGArFkKbBFmp29wJfgrSiJtq2omxp7sc+oTQPufWx 0eF1TbdtpFtRstAckBslVP+9rNAemh/NY0qLuXNrSqhC1aA7L4L/+YzKDK9v6E3lzTFlqETaEve lJA4ys3rdZXlOsim4HPIqz4HzoX5mgd9L6p+3lmchOuQztuq0Bbn6zTkKKgYIRvr7ariDKVs4i+ GwfPMe1S7/MwAGafUAKC8gEg+cbLplza9Eu8EH3X7xnC8WBBJH9n0nzuGklQhX8GMlFz3BIJorb utKNW28IfoRkWhXxz/6clBdgqQ4NzQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511270140 On 11/25/25 6:21 AM, Manivannan Sadhasivam wrote: > On Mon, Nov 24, 2025 at 05:53:07PM -0600, Bjorn Helgaas wrote: >> [+cc Alexey, Jeffrey, Avinash] >> >> On Thu, Nov 20, 2025 at 09:42:53PM +0530, Manivannan Sadhasivam wrote: >>> The Sandisk SN740 NVMe SSDs cause below AER errors on the upstream Root >>> Port of PCIe controller in Microsoft Surface Laptop 7, when ASPM L1 is >>> enabled: >>> >>> pcieport 0006:00:00.0: AER: Correctable error message received from 0006:01:00.0 >>> nvme 0006:01:00.0: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Receiver ID) >>> nvme 0006:01:00.0: device [15b7:5015] error status/mask=00000001/0000e000 >>> nvme 0006:01:00.0: [ 0] RxErr >> >> Do we have any information about whether this error happens with the >> SN740 on platforms other than the Surface Laptop 7? Or whether it >> happens on the Surface with other endpoints? [...] > -/* > - * Sandisk SN740 NVMe SSDs cause AER timeout errors on the upstream PCIe Root > - * Port when ASPM L1 is enabled. > - */ > DECLARE_PCI_FIXUP_HEADER(0x15b7, 0x5015, quirk_disable_aspm_l1); > > /* > > This check is similar to the DMI checks we have currently non-DT platforms. > Infact, we have also use the DMI checks on this laptop as it comes with SMBIOS. > > Note: I'm not sure if Konrad's lapto is based on "microsoft,romulus13" or > "microsoft,romulus15". 15, but they're otherwise identical hardware. Please quirk off both if you go this route. Konrad