From: Ashwin Ganti <ashwin.ganti@gmail.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Greg KH <greg@kroah.com>,
rsc@swtch.com, ericvh@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Ron Minnich <rminnich@gmail.com>,
jt.beard@gmail.com
Subject: Re: [PATCH 1/8] p9auth: set fsuid
Date: Thu, 4 Mar 2010 14:04:10 -0800 [thread overview]
Message-ID: <a67e66b21003041404h75d7aacaqb4f3e2a1c97adadc@mail.gmail.com> (raw)
In-Reply-To: <20100226181930.GA17850@us.ibm.com>
On Fri, Feb 26, 2010 at 10:19 AM, Serge E. Hallyn <serue@us.ibm.com> wrote:
> Ashwin, Ron, Eric, (whoever else cares to take a look) I will put
> up a git tree hopefully this weekend or monday... hmm, hang on, already
> exists - you can take a look at
> http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/sergeh/linux-cr.git;a=shortlog;h=refs/heads/p9auth.feb16.3
>
Greg/Serge: Sorry for the delay. I am okay with the patches in
general. Thanks for making the reaping of old capabilities change as
well along with these.
The only comment I have is that it would be nice to have a README file
in the p9auth directory describing these changes to the semantics.
Especially since we are handling groups, file system checks etc. which
is going through the capability string, it would be easier and helpful
to understand if there is some basic documentation on each of these
changes.
Also, I don't know if you want to further get them looked by someone
more knowledgeable to comment on the implications of modifying/moving
the set*id functions over but they look alright to me.
I have requested Eric too a couple of days ago to take a look at these
patches if he finds time.
Thanks,
Ashwin
next prev parent reply other threads:[~2010-03-04 22:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 22:44 Serge Hallyn
2010-02-16 22:44 ` [PATCH 2/8] p9auth: split core function out of some set*{u,g}id functions Serge Hallyn
2010-02-16 22:44 ` [PATCH 3/8] p9auth: use setresuid Serge Hallyn
2010-02-16 22:44 ` [PATCH 4/8] p9auth: add CAP_GRANT_ID to authorize use of /dev/caphash Serge Hallyn
2010-02-16 22:44 ` [PATCH 5/8] p9auth cleanup Serge Hallyn
2010-02-16 22:44 ` [PATCH 6/8] p9auth: do groups Serge Hallyn
2010-02-16 22:45 ` [PATCH 7/8] p9auth: add cap_node timeout Serge Hallyn
2010-02-16 22:45 ` [PATCH 8/8] p9auth: don't trim entries on write-only open Serge Hallyn
2010-02-25 23:28 ` [PATCH 1/8] p9auth: set fsuid Greg KH
2010-02-26 4:05 ` Serge E. Hallyn
2010-02-26 5:06 ` Greg KH
2010-02-26 18:19 ` Serge E. Hallyn
2010-03-04 22:04 ` Ashwin Ganti [this message]
2010-03-05 20:07 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a67e66b21003041404h75d7aacaqb4f3e2a1c97adadc@mail.gmail.com \
--to=ashwin.ganti@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=ericvh@gmail.com \
--cc=greg@kroah.com \
--cc=jt.beard@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rminnich@gmail.com \
--cc=rsc@swtch.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®