From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2628AC43215 for ; Mon, 25 Nov 2019 13:23:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F32292084D for ; Mon, 25 Nov 2019 13:23:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="CEwL8xFx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727884AbfKYNXE (ORCPT ); Mon, 25 Nov 2019 08:23:04 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:18029 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbfKYNXD (ORCPT ); Mon, 25 Nov 2019 08:23:03 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Nov 2019 05:23:05 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Nov 2019 05:23:03 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Nov 2019 05:23:03 -0800 Received: from [10.26.11.207] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 25 Nov 2019 13:23:00 +0000 Subject: Re: [PATCH 4.4 000/159] 4.4.203-stable review To: Greg Kroah-Hartman CC: Guenter Roeck , , , , , , , , , linux-tegra References: <20191122100704.194776704@linuxfoundation.org> <20191122133931.GA2033651@kroah.com> <20191122134131.GA2050590@kroah.com> <20191122134627.GB2050590@kroah.com> <9f976044-2dbc-6c19-11e7-210cd7ab35ea@nvidia.com> <7edc9531-347e-9ac7-2583-5efb49acffdb@nvidia.com> <20191125094116.GA2340170@kroah.com> From: Jon Hunter Message-ID: Date: Mon, 25 Nov 2019 13:22:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191125094116.GA2340170@kroah.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574688185; bh=ELEhJCED7O3rcEfoP5yQSLU/i/5KHSCPYZ+weYv2TVU=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=CEwL8xFxSp9SAYST4MfQQfALoxCNqdJCxuNuVeadANm/gBk65Q6aqlyBmLncAB7h4 DdzcV2ACeQKkcpj9GfVW9wz07X0BxledyA+QcUV8wYyAQpf2KIt8LLD/97VD7m3BbN 9NcmSC9Vd7YW1yCRlGVVI8qamxrXH/3/KU50c0FcldmIrJ3yocWvCU2ETnMUOc+56/ gzm4Sk5vtCDa0Vcid41KBWf7ZkXXQ6qNSNVUv+fSY9YzD1k6GW+gl8yWtapR4tXmj6 RCWLDm+kUH4P+9CZBnXVV4mz3zwm9Oc7DA5Zq3ddyzQ4c0gzDtWHGJcqff4ReQ35DP Kbo25R1VQ1U9g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/2019 09:41, Greg Kroah-Hartman wrote: > On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote: >> >> On 23/11/2019 15:46, Guenter Roeck wrote: >>> On 11/22/19 6:48 AM, Jon Hunter wrote: >>> >>> [ ... ] >>> >>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path >>>> dwc3 not found >>>> FATAL ERROR: Syntax error parsing input tree >>>> scripts/Makefile.lib:293: recipe for target >>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed >>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1 >>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed >>>> make: *** [dtbs] Error 2 >>>> >>>> >>>> This is caused by the following commit ... >>>> >>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f >>>> Author: H. Nikolaus Schaller >>>> Date:=C2=A0=C2=A0 Fri Sep 28 17:54:00 2018 +0200 >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 ARM: dts: omap5: enable OTG role for DWC3 con= troller >>>> >>> >>> On top of the breakage caused by this patch, I would also argue >>> that it is not a bug fix and should not have been included >>> in the first place. >>> >>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5: >>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of >>> that patch, I highly doubt that a backport to 4.4 would work. >=20 > Good catch, I have now dropped both of these patches and pushed out a > -rc3 >=20 >> FYI ... I am still seeing a build failure because of this with -rc2 ... >=20 > Can you see if -rc3 is also giving you problems? Better, but I appear to be seeing some random suspend failures with this now on one board. I will try to bisect this. Test results for stable-v4.4: 6 builds: 6 pass, 0 fail 12 boots: 12 pass, 0 fail 19 tests: 18 pass, 1 fail Linux version: 4.4.203-rc3-g2576206c30b5 Boards tested: tegra124-jetson-tk1, tegra20-ventana, tegra30-cardhu-a04 Cheers Jon --=20 nvpublic