From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF9BC4332F for ; Fri, 18 Mar 2022 11:29:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235779AbiCRLas (ORCPT ); Fri, 18 Mar 2022 07:30:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235769AbiCRLam (ORCPT ); Fri, 18 Mar 2022 07:30:42 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B1251ED062; Fri, 18 Mar 2022 04:29:16 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 2FC531F45EB1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647602954; bh=yR6YIljfGinF+pJoIGBmN8q7+1O8ZzcAnqybJw3gz6o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E8KU89+4XqdG3J8L/OLvNgA8upKBw/lygW9TlmKTChO/fWZuTxAKqOVrkhGEHE5PR c1Ryx3Vb+ETKbMRiLx6pJnL+NA2cDmyUdUJynygITn8Wb9TBa5wDM295sjIftjUl2B MAg9nV3rdwRkQQpDBMxI0C90KVKWsDkNvPDrOuy1HDy4YCzPHEQgVfA7C1LsGVRhAj pfu271TQ3FdfpyAjnkxjslqSIpCW4nytRx86bQwaPHHVJaPhfTN1btlb7QpB0l0lYA 8ZgZiIiTho3/i1kGNMNsbs/WiZ/aS8aDvQqp0uTJp4CRPanOklvbHzknoBcvPf4Zok qLFCymsgSwXhw== Message-ID: Date: Fri, 18 Mar 2022 12:29:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH V5 1/3] spi: mediatek: add spi memory support for ipm design Content-Language: en-US To: Leilk Liu , Mark Brown Cc: Rob Herring , Matthias Brugger , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220318025027.31281-1-leilk.liu@mediatek.com> <20220318025027.31281-2-leilk.liu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220318025027.31281-2-leilk.liu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 18/03/22 03:50, Leilk Liu ha scritto: > this patch add the support of spi-mem for ipm design. > > Signed-off-by: Leilk Liu > --- > drivers/spi/spi-mt65xx.c | 302 ++++++++++++++++++++++++++++++++++++++- > 1 file changed, 301 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c > index 1a0b3208dfca..ea6223259060 100644 > --- a/drivers/spi/spi-mt65xx.c > +++ b/drivers/spi/spi-mt65xx.c ...snip... > @@ -78,8 +79,21 @@ > #define SPI_CMD_IPM_GET_TICKDLY_OFFSET 22 > > #define SPI_CMD_IPM_GET_TICKDLY_MASK GENMASK(24, 22) > + > +#define PIN_MODE_CFG(x) ((x) / 2) > + > +#define SPI_CFG3_IPM_PIN_MODE_OFFSET 0 This definition is useless, the offset is zero... and this is used to bitshift zero. Please remove that, after which: Reviewed-by: AngeloGioacchino Del Regno