From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel Kiper <daniel.kiper@oracle.com>,
linux-kernel@vger.kernel.org, x86@kernel.org,
xen-devel@lists.xenproject.org
Cc: andrew.cooper3@citrix.com, boris.ostrovsky@oracle.com,
david.vrabel@citrix.com, hpa@zytor.com, ian.campbell@citrix.com,
jbeulich@suse.com, jeremy@goop.org, matt.fleming@intel.com,
mingo@redhat.com, stefano.stabellini@eu.citrix.com,
tglx@linutronix.de
Subject: Re: [PATCH v2 1/2] xen: Silence compiler warnings
Date: Sun, 13 Jul 2014 05:59:18 -0400 [thread overview]
Message-ID: <a686b87e-a1db-4a08-9b92-86b37e7d518c@email.android.com> (raw)
In-Reply-To: <1405199388-5692-2-git-send-email-daniel.kiper@oracle.com>
On July 12, 2014 5:09:47 PM EDT, Daniel Kiper <daniel.kiper@oracle.com> wrote:
>Add inline keyword to silence the following compiler
>warnings if xen_efi_probe() is not used:
>
> CC arch/x86/xen/setup.o
>In file included from arch/x86/xen/xen-ops.h:7:0,
> from arch/x86/xen/setup.c:31:
>include/xen/xen-ops.h:43:35: warning: ‘xen_efi_probe’ defined but not
>used [-Wunused-function]
>
>Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <Konrad.wilk@oracle.com>
>---
> include/xen/xen-ops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>index 771bbba..7491ee5 100644
>--- a/include/xen/xen-ops.h
>+++ b/include/xen/xen-ops.h
>@@ -40,7 +40,7 @@ bool xen_running_on_version_or_later(unsigned int
>major, unsigned int minor);
> #ifdef CONFIG_XEN_EFI
> extern efi_system_table_t *xen_efi_probe(void);
> #else
>-static efi_system_table_t __init *xen_efi_probe(void)
>+static inline efi_system_table_t __init *xen_efi_probe(void)
> {
> return NULL;
> }
next prev parent reply other threads:[~2014-07-13 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 21:09 [PATCH v2 0/2] " Daniel Kiper
2014-07-12 21:09 ` [PATCH v2 1/2] " Daniel Kiper
2014-07-13 9:59 ` Konrad Rzeszutek Wilk [this message]
2014-07-28 13:11 ` David Vrabel
2014-07-12 21:09 ` [PATCH v2 2/2] arch/x86/xen: " Daniel Kiper
2014-07-13 9:58 ` Konrad Rzeszutek Wilk
2014-07-14 15:26 ` [PATCH v2 0/2] xen: " Konrad Rzeszutek Wilk
2014-07-14 19:22 ` Matt Fleming
2014-07-28 21:38 [PATCH v2 1/2] " Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a686b87e-a1db-4a08-9b92-86b37e7d518c@email.android.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=ian.campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®