From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Dmitry Safonov <dima@arista.com>, linux-kernel@vger.kernel.org
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Borislav Petkov <bp@alien8.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Guo Ren <guoren@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Ingo Molnar <mingo@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Will Deacon <will@kernel.org>,
x86@kernel.org
Subject: Re: [PATCH v2 08/19] arm/vdso: Remove vdso pointer from mm->context
Date: Tue, 24 Nov 2020 07:22:11 +0100 [thread overview]
Message-ID: <a6877fff-b066-cffb-cede-011601f8a410@csgroup.eu> (raw)
In-Reply-To: <20201124002932.1220517-9-dima@arista.com>
Le 24/11/2020 à 01:29, Dmitry Safonov a écrit :
> Not used any more.
But what about mremap() ? Maybe you should explain why you can remove it ?
>
> Signed-off-by: Dmitry Safonov <dima@arista.com>
> ---
> arch/arm/include/asm/mmu.h | 3 ---
> arch/arm/kernel/vdso.c | 12 ------------
> 2 files changed, 15 deletions(-)
>
> diff --git a/arch/arm/include/asm/mmu.h b/arch/arm/include/asm/mmu.h
> index 1592a4264488..2397b0a19f59 100644
> --- a/arch/arm/include/asm/mmu.h
> +++ b/arch/arm/include/asm/mmu.h
> @@ -12,9 +12,6 @@ typedef struct {
> #endif
> unsigned int vmalloc_seq;
> unsigned long sigpage;
> -#ifdef CONFIG_VDSO
> - unsigned long vdso;
> -#endif
> #ifdef CONFIG_BINFMT_ELF_FDPIC
> unsigned long exec_fdpic_loadmap;
> unsigned long interp_fdpic_loadmap;
> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
> index 710e5ca99a53..4b39c7d8f525 100644
> --- a/arch/arm/kernel/vdso.c
> +++ b/arch/arm/kernel/vdso.c
> @@ -47,17 +47,8 @@ static const struct vm_special_mapping vdso_data_mapping = {
> .pages = &vdso_data_page,
> };
>
> -static int vdso_mremap(const struct vm_special_mapping *sm,
> - struct vm_area_struct *new_vma)
> -{
> - current->mm->context.vdso = new_vma->vm_start;
> -
> - return 0;
> -}
> -
> static struct vm_special_mapping vdso_text_mapping __ro_after_init = {
> .name = "[vdso]",
> - .mremap = vdso_mremap,
> };
>
> struct elfinfo {
> @@ -239,8 +230,6 @@ void arm_install_vdso(struct mm_struct *mm, unsigned long addr,
> struct vm_area_struct *vma;
> unsigned long len;
>
> - mm->context.vdso = 0;
> -
> if (vdso_text_pagelist == NULL)
> return;
>
> @@ -258,7 +247,6 @@ void arm_install_vdso(struct mm_struct *mm, unsigned long addr,
> if (IS_ERR(vma))
> return;
>
> - mm->context.vdso = addr;
> *sysinfo_ehdr = addr;
> }
>
>
next prev parent reply other threads:[~2020-11-24 6:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 0:29 [PATCH v2 00/19] Add generic vdso_base tracking Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 01/19] x86/elf: Check in_x32_syscall() in compat_arch_setup_additional_pages() Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 02/19] elf: Move arch_setup_additional_pages() to generic elf.h Dmitry Safonov
2020-11-24 6:12 ` Christophe Leroy
2020-11-26 19:45 ` Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 03/19] arm64: Use in_compat_task() in arch_setup_additional_pages() Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 04/19] x86: Remove compat_arch_setup_additional_pages() Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 05/19] elf: " Dmitry Safonov
2020-11-24 6:13 ` Christophe Leroy
2020-11-26 19:45 ` Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 06/19] elf/vdso: Reuse arch_setup_additional_pages() parameters Dmitry Safonov
2020-11-24 6:18 ` Christophe Leroy
2020-11-26 19:46 ` Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 07/19] elf: Use sysinfo_ehdr in ARCH_DLINFO() Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 08/19] arm/vdso: Remove vdso pointer from mm->context Dmitry Safonov
2020-11-24 6:22 ` Christophe Leroy [this message]
2020-11-26 19:48 ` Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 09/19] s390/vdso: Remove vdso_base " Dmitry Safonov
2020-11-24 6:22 ` Christophe Leroy
2020-11-24 0:29 ` [PATCH v2 10/19] sparc/vdso: Remove vdso " Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 11/19] mm/mmap: Make vm_special_mapping::mremap return void Dmitry Safonov
2020-11-24 6:25 ` Christophe Leroy
2020-11-24 0:29 ` [PATCH v2 12/19] x86/signal: Land on &frame->retcode when vdso isn't mapped Dmitry Safonov
2020-11-24 23:08 ` Andy Lutomirski
2020-11-24 0:29 ` [PATCH v2 13/19] x86/signal: Check if vdso_image_32 is mapped before trying to land on it Dmitry Safonov
2020-11-24 23:43 ` Andy Lutomirski
2020-11-26 20:00 ` Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 14/19] mm: Add vdso_base in mm_struct Dmitry Safonov
2020-11-24 23:37 ` Andy Lutomirski
2020-11-24 0:29 ` [PATCH v2 15/19] x86/vdso: Migrate to generic vdso_base Dmitry Safonov
2020-11-24 2:51 ` kernel test robot
2020-11-24 0:29 ` [PATCH v2 16/19] arm/vdso: " Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 17/19] arm64/vdso: Migrate compat signals " Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 18/19] arm64/vdso: Migrate native " Dmitry Safonov
2020-11-24 0:29 ` [PATCH v2 19/19] mips/vdso: Migrate " Dmitry Safonov
2020-11-24 6:53 ` [PATCH v2 00/19] Add generic vdso_base tracking Christophe Leroy
2020-11-26 20:41 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6877fff-b066-cffb-cede-011601f8a410@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dima@arista.com \
--cc=guoren@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vincenzo.frascino@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®