From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 791E71E7C18 for ; Fri, 8 Nov 2024 12:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731068914; cv=none; b=uDHyqndNg/kcy9aU0bfZyn6uz6e6EaTF85ecEjyV8i7ABRWZrSK+iDyfyaL9lWOPr9VGcI4Sf/XMPTBsZYiBih0ClpJ+obRGzmEnBid7f7xTJJhu5wRHX0jp2gS/c603IrNQmcd8NhnmaEr27WZBeLRHX1uTMzTzw70YAlyt3zQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731068914; c=relaxed/simple; bh=T3RAhCxZJEcvDRAbhNU88i5VYp+Nw02wibCuALcA4zs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pZC3AbF+z8COcEJ872QDlt6kssxYHN0Msq224VwmmF/7F7NlKMYFlyztlvj6nDdti5Y/80Cy70N04+OUDOACfr/9+XTTBtyUMTBGtCvsIZmZs+LnkYmIwRWy2p8LAzABT/dP21V1ucnDYvdjQPR6ld3hr6iLgrbD6n/z+b1EaM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nsUoRQjS; arc=none smtp.client-ip=209.85.208.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nsUoRQjS" Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-5cec9ad04aeso373281a12.1 for ; Fri, 08 Nov 2024 04:28:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731068910; x=1731673710; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AFd92mrT4vT9LbEkl123rvklE/FQdMhVq9EhkKWamEM=; b=nsUoRQjSm/v+7Eg9+cP1N8RjpR1OskwokQ+4ZcSHfFSOlo5pCgewCZbTBF0OYIDJlA lfSRawqwTkUUit2UdHt4xSNRYPWWLUcwP3gCs3T702YyzweYhntClLyr0pwb66aSR57w Q2uOPbhbR0/2kq0tllb8YzZcOPNbvIrLFmaVZStRhYM6EX1zKJuIz+7FTUYR1oaUVLwF g43A4U86JERlynd96oZse1DxVDFLYHHdQQKfSkvdl+PVHORKcJX34hsSR44WIBNFhcIk PtSY+uDcAhVLTHMwpogJpSuU4oZrOJXjV7ZMwGTC5ZwthkKEOYoO8jifV2Sx8GSIoCG3 cwUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731068910; x=1731673710; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AFd92mrT4vT9LbEkl123rvklE/FQdMhVq9EhkKWamEM=; b=bK0rigMQFVUMZYAw3altUxl1BwFexeCCMVNlNoPJ6ICj9jbHdJrSyW9p/uRKllle9j WQpXBgwAaQf5rCl0WhVufRWnVH6qm78neG5WST/Lv63UjE8CSvfWrMXi8oIC++IZDGCL iIrl2aC7ttGCeJd48nR0Rgcs6+lZkaUaEuUA4+wwaYtNdUpqSGz/lpr+3y+GmDems7N8 CEIADsK8QXkW3eED6rwuT8uqv7EFceYDTBnx0LnmpDh0YQrwqoZYf62OwVhLiVXNyuP3 e8Wt8ZI5uPRWEzn/icWdrH1TOQqPwD+WjXNHta8MhCWhekQMawdji+J6Wl/tItETUPSe i/QQ== X-Forwarded-Encrypted: i=1; AJvYcCXdSrjx6g2tUD8qP9DuxC3ldZ5YShIEX11KSVB03zPh+x5ZMLr3pXQ5a8djKqITSYx+9PCRx8Wo4iboUAI=@vger.kernel.org X-Gm-Message-State: AOJu0YyP5U2yDN+Xe7JQKom+IwSr4yjxd4P5OpLTEXdmgckonQfaMJ9W alkUPThPyVkD/xg7G/iHH9Ow4S8rF57jd0+IDUaD0rGbl9VNlC3jm0EN1jslzUs= X-Google-Smtp-Source: AGHT+IGIMhp4vgQ0XK+8VV24sRm5sbYfxtPQ1MHg6R9lN8hVCGdLYosibCDtNjbQ8V9/MfUtaIBfxg== X-Received: by 2002:a05:6402:270d:b0:5c9:879e:6998 with SMTP id 4fb4d7f45d1cf-5cf0a307a13mr889515a12.1.1731068909802; Fri, 08 Nov 2024 04:28:29 -0800 (PST) Received: from [172.20.144.41] ([89.101.134.25]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cf03bb72a7sm1912384a12.45.2024.11.08.04.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2024 04:28:29 -0800 (PST) Message-ID: Date: Fri, 8 Nov 2024 12:28:27 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/11] dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller Content-Language: en-US To: Taniya Das , Bjorn Andersson , Michael Turquette , Stephen Boyd , Abhishek Sahu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon Cc: Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski References: <20241108-qcs615-mm-clockcontroller-v3-0-7d3b2d235fdf@quicinc.com> <20241108-qcs615-mm-clockcontroller-v3-3-7d3b2d235fdf@quicinc.com> From: Vladimir Zapolskiy In-Reply-To: <20241108-qcs615-mm-clockcontroller-v3-3-7d3b2d235fdf@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Taniya, On 11/8/24 06:09, Taniya Das wrote: > Add DT bindings for the Camera clock on QCS615 platforms. Add the > relevant DT include definitions as well. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Taniya Das > --- > .../bindings/clock/qcom,qcs615-camcc.yaml | 60 +++++++++++ > include/dt-bindings/clock/qcom,qcs615-camcc.h | 110 +++++++++++++++++++++ > 2 files changed, 170 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs615-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs615-camcc.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..0abd277aa3ddd2e1384d0af59699dc1deda5575b > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,qcs615-camcc.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,qcs615-camcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Camera Clock & Reset Controller on QCS615 > + > +maintainers: > + - Taniya Das > + > +description: | > + Qualcomm camera clock control module provides the clocks, resets and power > + domains on QCS615 > + > + See also: include/dt-bindings/clock/qcom,qcs615-camcc.h > + > +properties: > + compatible: > + const: qcom,qcs615-camcc > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Board XO source > + > + '#clock-cells': > + const: 1 > + > + '#reset-cells': > + const: 1 > + > + '#power-domain-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - '#clock-cells' > + - '#reset-cells' > + - '#power-domain-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + clock-controller@ad00000 { > + compatible = "qcom,qcs615-camcc"; > + reg = <0xad00000 0x10000>; > + clocks = <&rpmhcc RPMH_CXO_CLK>; > + > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > +... would you find it possible to merge this binding into the existing one qcom,sdm845-camcc.yaml? Those two are very similar, sdm845-camcc requires clock-names though. -- Best wishes, Vladimir