From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B19ECE58D for ; Fri, 11 Oct 2019 18:02:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E11220659 for ; Fri, 11 Oct 2019 18:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728778AbfJKSCl (ORCPT ); Fri, 11 Oct 2019 14:02:41 -0400 Received: from smtprelay0155.hostedemail.com ([216.40.44.155]:35364 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728374AbfJKSCl (ORCPT ); Fri, 11 Oct 2019 14:02:41 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 5A8FE100E86C4; Fri, 11 Oct 2019 18:02:39 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: crack32_8b747c21a4229 X-Filterd-Recvd-Size: 4323 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Fri, 11 Oct 2019 18:02:38 +0000 (UTC) Message-ID: Subject: Re: [PATCH] checkpatch: Warn if DT bindings are not in schema format From: Joe Perches To: Rob Herring Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Andy Whitcroft , Andrew Morton Date: Fri, 11 Oct 2019 11:02:37 -0700 In-Reply-To: References: <20190913211349.28245-1-robh@kernel.org> <713b2e5bbab16ddf850245ae1d92be66d9730e02.camel@perches.com> <7672dd2f651bfdcdb1615ab739e36a381b2535b1.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-10-11 at 12:56 -0500, Rob Herring wrote: > On Fri, Sep 27, 2019 at 10:39 AM Rob Herring wrote: > > On Fri, Sep 27, 2019 at 9:29 AM Joe Perches wrote: > > > On Fri, 2019-09-27 at 09:02 -0500, Rob Herring wrote: > > > > On Fri, Sep 13, 2019 at 4:48 PM Joe Perches wrote: > > > > > On Fri, 2019-09-13 at 16:13 -0500, Rob Herring wrote: > > > > > > DT bindings are moving to using a json-schema based schema format > > > > > > instead of freeform text. Add a checkpatch.pl check to encourage using > > > > > > the schema for new bindings. It's not yet a requirement, but is > > > > > > progressively being required by some maintainers. > > > > > [] > > > > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > > > > [] > > > > > > @@ -2822,6 +2822,14 @@ sub process { > > > > > > "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr); > > > > > > } > > > > > > > > > > > > +# Check for adding new DT bindings not in schema format > > > > > > + if (!$in_commit_log && > > > > > > + ($line =~ /^new file mode\s*\d+\s*$/) && > > > > > > + ($realfile =~ m@^Documentation/devicetree/bindings/.*\.txt$@)) { > > > > > > + WARN("DT_SCHEMA_BINDING_PATCH", > > > > > > + "DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst\n"); > > > > > > + } > > > > > > + > > > > > > > > > > As this already seems to be git dependent, perhaps > > > > > > > > It's quite rare to see a non git generated diff these days. > > > > > > > > > it's easier to read with a single line test like: > > > > > > > > > > if ($line =~ m{^\s*create mode\s*\d+\s*Documentation/devicetree/bindings/.*\.txt$}) { > > > > > etc... > > > > > } > > > > > > > > I frequently do 'git show $commit | scripts/checkpatch.pl' and this > > > > doesn't work with that. I really should have a '--pretty=email' in > > > > there, but I just ignore the commit msg warnings. In any case, that > > > > still doesn't help because there's no diffstat. There's probably some > > > > way to turn that on or just use git-format-patch, but really we want > > > > this to work with any git diff. > > > > > > I don't understand your argument against what I proposed at all. > > > > It is dependent on the commit message rather than the diff itself. I > > want it to work with or without a diffstat. > > > > > and btw: > > > > > > $ git format-patch -1 --stdout | ./scripts/checkpatch.pl > > > > Yes, I stated this was possible. My concern is there are lots of ways > > to generate a diff in git. My way works for *all* of them. Yours > > doesn't. > > Joe, are you okay with this? Sure, Andrew Morton does most of the checkpatch upstreaming, but if you want to send your own pull request, I've no objection. > Rob