From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Karel Balej <karelb@gimli.ms.mff.cuni.cz>,
Karel Balej <balejk@matfyz.cz>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org
Cc: "Duje Mihanović" <duje.mihanovic@skole.hr>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH v3 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC
Date: Mon, 4 Mar 2024 09:03:04 +0100 [thread overview]
Message-ID: <a6937e1b-ec4b-4eed-8771-8f5dae801815@linaro.org> (raw)
In-Reply-To: <20240303101506.4187-2-karelb@gimli.ms.mff.cuni.cz>
On 03/03/2024 11:04, Karel Balej wrote:
> From: Karel Balej <balejk@matfyz.cz>
>
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pmic@30 {
> + compatible = "marvell,88pm886-a1";
> + reg = <0x30>;
> + interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-parent = <&gic>;
> + wakeup-source;
> +
> + regulators {
> + ldo2: ldo2 {
> + regulator-min-microvolt = <3100000>;
> + regulator-max-microvolt = <3300000>;
> + };
Messed indentation here and in following lines..
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-04 8:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 10:04 [RFC PATCH v3 0/5] initial support " Karel Balej
2024-03-03 10:04 ` [RFC PATCH v3 1/5] dt-bindings: mfd: add entry " Karel Balej
2024-03-04 8:03 ` Krzysztof Kozlowski [this message]
2024-03-03 10:04 ` [RFC PATCH v3 2/5] mfd: add driver " Karel Balej
2024-03-05 11:44 ` Lee Jones
2024-03-05 18:53 ` Karel Balej
2024-03-07 8:16 ` Lee Jones
2024-03-03 10:04 ` [RFC PATCH v3 3/5] regulator: add regulators " Karel Balej
2024-03-03 10:04 ` [RFC PATCH v3 4/5] input: add onkey " Karel Balej
2024-03-03 20:39 ` Dmitry Torokhov
2024-03-04 20:28 ` Karel Balej
2024-03-05 1:10 ` Dmitry Torokhov
2024-03-10 11:35 ` Karel Balej
2024-03-10 20:35 ` Krzysztof Kozlowski
2024-03-10 21:48 ` Dmitry Torokhov
2024-03-11 10:26 ` Karel Balej
2024-03-11 10:41 ` Krzysztof Kozlowski
2024-03-11 12:12 ` Karel Balej
2024-03-11 16:18 ` Dmitry Torokhov
2024-03-03 10:04 ` [RFC PATCH v3 5/5] MAINTAINERS: add myself " Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6937e1b-ec4b-4eed-8771-8f5dae801815@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=balejk@matfyz.cz \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=duje.mihanovic@skole.hr \
--cc=karelb@gimli.ms.mff.cuni.cz \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®