From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932595AbcLLVCb (ORCPT ); Mon, 12 Dec 2016 16:02:31 -0500 Received: from zed.grinta.net ([109.74.203.128]:59602 "EHLO zed.grinta.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753064AbcLLVC3 (ORCPT ); Mon, 12 Dec 2016 16:02:29 -0500 Subject: Re: Clarification for acceptance statistics? To: SF Markus Elfring References: <5560ffc2-e17d-5750-24e5-3150aba5d8aa@grinta.net> <581046dd-0a4a-acea-a6a8-8d2469594881@grinta.net> <3d09590c-9a10-f756-1b71-536ea37d8524@users.sourceforge.net> Cc: linux-media@vger.kernel.org, Alexey Khoroshilov , Hans Verkuil , Mauro Carvalho Chehab , LKML , kernel-janitors@vger.kernel.org From: Daniele Nicolodi Message-ID: Date: Mon, 12 Dec 2016 14:02:24 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <3d09590c-9a10-f756-1b71-536ea37d8524@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/16 11:03 AM, SF Markus Elfring wrote: >> Have you proposed a similar patch that was accepted? > > Yes. - It happened a few times. The question was: have you ever had a patch changing code in the form { a = kmalloc(...); b = kmalloc(...); if (!a || !b) goto out; ... out: kfree(a); kfree(b); } to something else, accepted? I went checking and I haven't found such a patch. Did you understand my question? > It is really needed to clarify the corresponding software development > history any further? It is relevant because you are submitting a patch and your changelog implies that it makes the code follow some code structure rule that needs to be applied to the kernel. As the above is a recurring pattern in kernel code, it is legitimate to ask if such a rule exist, and has been enforced before, or you are making it up. My conclusion is that you are making it up. As a proposer of a new pattern, what is the evidence you can bring to the discussion that supports that your solution is better? What is the metric you are using to define "better"? Cheers, Daniele