Re: [PATCH v2] drm/vmgfx: Use non-hybrid PCI devres API

[Philipp Stanner <phasta@mailbox.org>]

On Thu, 2025-05-08 at 11:39 -0400, Zack Rusin wrote:
> On Thu, May 8, 2025 at 6:40 AM Philipp Stanner <phasta@mailbox.org>
> wrote:
> > 
> > On Wed, 2025-04-23 at 14:06 +0200, Philipp Stanner wrote:
> > > vmgfx enables its PCI device with pcim_enable_device(). This,
> > > implicitly, switches the function pci_request_regions() into
> > > managed
> > > mode, where it becomes a devres function.
> > > 
> > > The PCI subsystem wants to remove this hybrid nature from its
> > > interfaces. To do so, users of the aforementioned combination of
> > > functions must be ported to non-hybrid functions.
> > > 
> > > Moreover, since both functions are already managed in this
> > > driver,
> > > the
> > > calls to pci_release_regions() are unnecessary.
> > > 
> > > Remove the calls to pci_release_regions().
> > > 
> > > Replace the call to sometimes-managed pci_request_regions() with
> > > one
> > > to
> > > the always-managed pcim_request_all_regions().
> > > 
> > > Signed-off-by: Philipp Stanner <phasta@kernel.org>
> > 
> > *PING*
> 
> Thanks, that looks great. I missed it because the driver's name is
> vmwgfx. I'd be happy to fix the subject for you while pushing this to
> drm-misc-fixes,

But, I don't think that this is a bug. It's just a bit ugly and this
patch performs cleanup work, but all the code behaves as intended,
without leaks or stuff like that.

Thus, I think it should go to drm-misc-next instead of drm-misc-fixes.

Regards

>  if you're ok with it of course. Otherwise:
> Reviewed-by: Zack Rusin <zack.rusin@broadcom.com>
> 
> z