From: Tapio Reijonen <tapio.reijonen@vaisala.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Tapio Reijonen <tapio.reijonen@kolumbus.fi>,
Maarten Brock <Maarten.Brock@sttls.nl>
Subject: Re: [PATCH v7 1/9] serial: max310x: don't clobber the TX break bit in set_termios
Date: Tue, 6 Oct 2026 07:06:06 +0300 [thread overview]
Message-ID: <a69c09a9-76d8-46c2-9aa3-64b7a961cdad@vaisala.com> (raw)
In-Reply-To: <20261005115737.3a26240eadeff00262e920ff@hugovil.com>
Hi Hugo,
On 10/5/26 18:57, Hugo Villeneuve wrote:
> You commit message indicate only part of what your patch changed,
> but not why.
>
> In this case, IIUC, your patch prevent ending a preconfigured
> TX break when calling set_termios()?
Yes, exactly: a break asserted with TIOCSBRK must stay on the wire
until TIOCCBRK, but any termios change landing in between rewrote the
whole LCR register and silently ended the break early. The second
hunk covers the leftover that fix exposes: nothing clears a break
still asserted when the port is closed - the unconditional LCR write
was the accidental recovery - so startup() now clears it, the same
way 8250 does.
I can reword the message for a v8 to lead with that user-visible
failure rather than the register mechanics.
Tapio
next prev parent reply other threads:[~2026-10-06 4:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 13:19 [PATCH v7 0/9] (no cover subject) Tapio Reijonen
2026-10-05 13:19 ` [PATCH v7 1/9] serial: max310x: don't clobber the TX break bit in set_termios Tapio Reijonen
2026-10-05 15:57 ` Hugo Villeneuve
2026-10-06 4:06 ` Tapio Reijonen [this message]
2026-10-06 13:42 ` Hugo Villeneuve
2026-10-05 13:19 ` [PATCH v7 2/9] serial: max310x: assert the transceiver during a break Tapio Reijonen
2026-10-05 13:19 ` [PATCH v7 3/9] serial: max310x: centralize the RS485 transceiver programming Tapio Reijonen
2026-10-05 13:19 ` [PATCH v7 4/9] serial: max310x: convert RS485 delays from milliseconds to bit-times Tapio Reijonen
2026-10-05 13:19 ` [PATCH v7 5/9] serial: max310x: stop the transmitter before powering down in shutdown Tapio Reijonen
2026-10-05 13:19 ` [PATCH v7 6/9] serial: max310x: support active-low RTS on the hardware path Tapio Reijonen
2026-10-05 13:19 ` [PATCH v7 7/9] serial: max310x: schedule tx_work directly from the IRQ handler Tapio Reijonen
2026-10-05 13:19 ` [PATCH v7 8/9] serial: max310x: drive RTS in software when hardware delays are too short Tapio Reijonen
2026-10-05 13:19 ` [PATCH v7 9/9] serial: max310x: don't transmit while an RS485 reconfigure is pending Tapio Reijonen
2026-10-05 13:37 ` [PATCH v7 0/9] (no cover subject) Tapio Reijonen
2026-10-05 15:51 ` Hugo Villeneuve
2026-10-06 4:03 ` Tapio Reijonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a69c09a9-76d8-46c2-9aa3-64b7a961cdad@vaisala.com \
--to=tapio.reijonen@vaisala.com \
--cc=Maarten.Brock@sttls.nl \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tapio.reijonen@kolumbus.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®