From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f52.google.com (mail-dl1-f52.google.com [74.125.82.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810C426A1A7 for ; Fri, 30 Jan 2026 09:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769765818; cv=none; b=WXJ5701Flub+ZTSdjV2JFt3v+9Agp3L9lsYcK0YJveGxOYiPWu8T7fdWXXTRJRk2sDjpVZh5zeA/OPU7on4kwakkwA18g6ZyZ7jMWUs5Gl+FqAGXX7nzI1UvLaAZv79V1MWVQPhuQRk6uy3qzZNCCAnaIAj1XZASHbdVmKVO6yo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769765818; c=relaxed/simple; bh=BLz6J8sxyMrE62ZOAa2vX3Jaiyx1D5+eYXHfqLUktvw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vDJcpmyR4N9LxxHioy45vb0ujOhy8j7qJq2Oq9X/uDPyxBRb5mauuaeEl2XidojVoTDa4XHMjRRSts7HymQq3BEN0EiOXNymPzKMSEuD+dcD4al/2s4SRN63Mjlbpt56g9dUszsGFHPCDlHLRXQ+FT7HnG4I7tnfzHxWOUTLMn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VdPpH9Xt; arc=none smtp.client-ip=74.125.82.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VdPpH9Xt" Received: by mail-dl1-f52.google.com with SMTP id a92af1059eb24-1233b953bebso2089927c88.1 for ; Fri, 30 Jan 2026 01:36:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769765815; x=1770370615; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8zq5baMT7RWrdtdglgJK9Mog541Ficeysb4gE2eqeeE=; b=VdPpH9XtohA9p2n9a7j6WWxpctarqOQJEORakk2W3PeZSLU6gyQuRdcQfnY33tGbJB RDU4JSKBf2LcXxpUpCo0PChH0W8PlBEmIvKeQXQqDetBbAZcHGGbeWqLqVph7PPwrI0k CLBk60DxjrFJBVEOSOvnZ3wiOoYA4Sw4jzJm0J3M+XvFxjT81hAIJQ5FzEI2VGsaOOt/ IVQDbF0hs6NPX2aSpGxpc4W53bV5Y4BdsAtj6h+VLetboPLRcSn0zJ+FZnXLIM9T7N2Z 9F0Xo0Q+PKIM3ttZBWg012TleCz8fyNXFOjBH6zeidYqltuUu4lnUGMfQifR0kcaOSnA cCgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769765815; x=1770370615; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8zq5baMT7RWrdtdglgJK9Mog541Ficeysb4gE2eqeeE=; b=IHrR1/Ba0md8+kNFt/nE0BN6JJU2x1uZnJIoem3OFgxSOknq3RrE46baMJYzyRMvqB 6CpjXeu5Y4afbD3j5sKOqU3bXSiH48Za5btxRBSWR5WPH38pcJoMN2FTBgo5HvQmih7o tSNPvJSwJue0w5ufzcUuMsINCiV7zxBfnT2fZ8xQQAdLbJpr4JXeF5ppV9dKdcHOXjM6 59JaKpokBZz4Itg0rNYIczqH+tkKMkM3ctnLuj3m/2xhcqECK1IYT/7m9pu2c4Iw0KvF rKWQT0lPJ8qx8tSQjOhc7jXq/zwLHaJ8h9+y1MUDAA4wKfU2nJBXCVj9M6NisvCyTJqR rJsw== X-Forwarded-Encrypted: i=1; AJvYcCUAF1dZJeAyMC99YYpVhwJvQxIkBIgBn71AbYZNbrFR/lToK/q1wGa2JD/Y15OB0jluuuqAuVMoGskCdI0=@vger.kernel.org X-Gm-Message-State: AOJu0YzDGFoQp46T7HbfCWdaJ9f4wv7Q/5W34n4nqyJ8l8LOHmjxPyGW W/J1FiyK/6H326Z3Q3X037PFYz7eV9+3FDaj9p5po77eGItcTeAaLbtS X-Gm-Gg: AZuq6aIM4+HtfPzHjHLlzah7/TM/MtpOh5A4Yp9rvEusM8ifAe0NoLyk/Gy8iBu25G4 +vTv4hvU7PiScoru2OwtOhWP7GHti/Y5R6S28NECACEjdx2ObcFMRKoHMMM7H1I4KxhtJe/2c+1 SOsAcYaKRlqqg65t86ggp2HbhkBEiyLpS7UCH8srZ8Bzn1IabRxUWczd45ZMZlsq8PMzFxkAjfA MlrMbJ9ut24y1/cYUHJVLTObeQh/+bMWGSkG/6EgAgG7ZZpR7rLtFaxGErELU7bVZppQPfz+5zA eDwJkvITFbBj51xATjT+A8CU1evrHXFO96dpmQtJpjyvCKAMltM65Glv7QWIfHu3sdVdVrn+bIF 3zj9LxQaf3uf7cwTFg5SnD9pwgHnsRXUc06o0uk6XzY7CcDnYJYnERzsZsfRzPxGNQ62fS5Wgmu Y3iY8jdwTDWCqeaeUbmdIKO2oe42YYeRfFS3dpA0tMw+tVeT7t2fVXjAuEAHKdCg== X-Received: by 2002:a05:7022:fa6:b0:124:abaa:7ff2 with SMTP id a92af1059eb24-125c0ff825bmr1381141c88.24.1769765815326; Fri, 30 Jan 2026 01:36:55 -0800 (PST) Received: from ?IPV6:2804:d57:4e32:d200:d9b8:e236:f824:3578? ([2804:d57:4e32:d200:d9b8:e236:f824:3578]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9de948esm10422746c88.9.2026.01.30.01.36.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 01:36:54 -0800 (PST) Message-ID: Date: Fri, 30 Jan 2026 06:36:48 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9] rust: add new macro for common bitflag operations To: Miguel Ojeda Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , daniel.almeida@collabora.com, rust-for-linux@vger.kernel.org, felipe_life@live.com, linux-kernel@vger.kernel.org, Lyude Paul References: <20260117-feat-add-bitmask-macro-v9-1-45ea1f00f846@gmail.com> Content-Language: en-US From: Filipe Xavier In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/30/26 2:25 AM, Miguel Ojeda wrote: > On Sat, Jan 17, 2026 at 11:41 AM Filipe Xavier wrote: >> We have seen a proliferation of mod_whatever::foo::Flags >> being defined with essentially the same implementation >> for BitAnd, BitOr, contains and etc. >> >> This macro aims to bring a solution for this, >> allowing to generate these methods for user-defined structs. >> With some use cases in KMS and upcoming GPU drivers. >> >> Link: https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/topic/We.20really.20need.20a.20common.20.60Flags.60.20type >> Suggested-by: Daniel Almeida >> Suggested-by: Lyude Paul >> Reviewed-by: Daniel Almeida >> Reviewed-by: Lyude Paul >> Tested-by: Andreas Hindborg >> Reviewed-by: Andreas Hindborg >> Signed-off-by: Filipe Xavier > So I was about to apply this one and I noticed a few bits (no need for > a new version): > > - This was added to the prelude -- I asked the team and they felt it > wasn't needed, so I will remove it. We can always add it later on if > needed. Sounds good, no problem. > > - Is `BitXorAssign<$flag> for $flags` missing for some reason? I will add: > > impl ::core::ops::BitXorAssign<$flag> for $flags { > #[inline] > fn bitxor_assign(&mut self, rhs: $flag) { > *self = *self ^ rhs; > } > } > > This is why I like to have tests for every operator... I may open > a good first issue about it :) Regarding |BitXorAssign|, that was indeed an oversight on my part. Adding it makes perfect sense. > I also fixed an intra-doc link and tweaked a couple other bits. Thanks for the review and for taking the time with this. Xavier > Cheers, > Miguel