From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2071.outbound.protection.outlook.com [40.107.243.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E97CC1FDA; Fri, 9 Aug 2024 02:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.71 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723168869; cv=fail; b=HD4N/WVZg0SMeiFIdRAD2RZXmhvp4qbu31+20Lc9TowxZXHIEuOfhaCgk/sa4VK0TBQ9D3l6GR4KaV9tTh6w04LumqE9JxJv5p4vUn6sLB/KHLpA4IkLVzj6typG+ICyLoKWv53TrqpYPcJKG3a2tfxHevbxeJZ3fUZfG+WQkh4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723168869; c=relaxed/simple; bh=xXwIZmH61VtpTQVGXi6rFVZTJsP8hGYFdqH8nnaY+JA=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=CfWeoi2972thTcLQ4yaPUz4YqxGB2X31QtzBI9VbrwpIJCNf7l/BjOUrSveJs0zjAjnJk3LfSTEoL7Dw+3JVchBhm/1dyesRucGqEvZXKWrzihjDj9/2zc0MLCnG0lQPtsHkJi5/4vWmZ4GnfyjZN37TUfJ89SlxhRa6YWVTwog= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=cZV7gXdO; arc=fail smtp.client-ip=40.107.243.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="cZV7gXdO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MB3OMUKWebFGtjBvV8aQOBlYnJkSCZb19w0J3Etm+duCWB/U1OjBCBSgNSmk7sRzjpuxidvtZ/D573fQbGNTTMoRPoXjjUYnKJjOutltZfMtPndPtXBzk3l0mZftvVtGRRgsnlTwGLVtqJuM9/wPOVquWdqatkOQcBUALELvoxinaTZUuTWOk/LJYXLUV5IS6U89txI5o/bAOTzflgk1r4eQ58mTgknBn9WWZR7m2ibb8s3qr69E0rTjqw+CtNOHxreg00TNgFCXESttzGxBnK0FcL2hMs46OT/XB9ZdgvNUp9vHw8qmDndGOrnhPQp6JwDCnUqGZXFcPglCzd9ttg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fWQ/bhvy3Ra6c0decCBmLuoEGTg77z7/dyVmjnmsX3c=; b=Km75ieddjhCGB7BNa4p6lt7zU+ak/egNnWU/ywt/kqXEvzxVQEVWyf/UmWC/dkE2zLDdccsnrx3ySSzg57FjRoO4tSsRrNYAe+/a7vAGeD5kVhzG6FKyh+dvyX2t4cGidcrgqP7kLVPGEzlBUNxDzUoQZJ+Q1xUDixLRY21dW0vZpoItHWBJ7Qrl6nW076PFTo6nJ26fRd/9TI9yfKfXNEcW6DW3CmCh8D8Ti8/cCLJsRTJXIE3+84hEmtG6Gay+RaJSf6fKbb/qJgD9WSOdF99BcEvEM98tkmWB0F0l+ZrEKcNJcm7EaAc6c1kt6Ul27wA/AGHwrZ1IzN4QHyZlig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fWQ/bhvy3Ra6c0decCBmLuoEGTg77z7/dyVmjnmsX3c=; b=cZV7gXdOQ0h8cP1DfVMcuLeCzfgMZt/+QoAU92O7vICw+LSFQ8a3KLH03f2BjRX5DohhZCNJeEL16ou0rVx2345LhpVEWWXwjavoYZskTY3u3nnExw5PQi6Vmv0U+Qy+YPr35mDd0uERfNcJrvP0k7pQkEQIOIHH12DD0ALajPE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4123.namprd12.prod.outlook.com (2603:10b6:5:21f::23) by MW5PR12MB5598.namprd12.prod.outlook.com (2603:10b6:303:193::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.28; Fri, 9 Aug 2024 02:01:04 +0000 Received: from DM6PR12MB4123.namprd12.prod.outlook.com ([fe80::512d:6caa:552a:7ebf]) by DM6PR12MB4123.namprd12.prod.outlook.com ([fe80::512d:6caa:552a:7ebf%4]) with mapi id 15.20.7849.014; Fri, 9 Aug 2024 02:01:04 +0000 Message-ID: Date: Fri, 9 Aug 2024 07:30:54 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] ASoC: SOF: amd: fix for acp error reason registers wrong offset Content-Language: en-US To: Mark Brown Cc: alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, venkataprasad.potturu@amd.com, Ranjani Sridharan , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Daniel Baluta , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Cristian Ciocaltea , Krzysztof Kozlowski , "moderated list:SOUND - SOUND OPEN FIRMWARE (SOF) DRIVERS" , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list References: <20240807051341.1616925-1-Vijendar.Mukunda@amd.com> <20240807051341.1616925-2-Vijendar.Mukunda@amd.com> From: "Mukunda,Vijendar" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PN2PR01CA0216.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:ea::14) To DM6PR12MB4123.namprd12.prod.outlook.com (2603:10b6:5:21f::23) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4123:EE_|MW5PR12MB5598:EE_ X-MS-Office365-Filtering-Correlation-Id: b5cc0778-7f5b-451b-e3d6-08dcb8172048 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZFJ4MmMzNEp1aDhQeVU5ZmZJdloxOXMzTlZrTE1KVlBYY2tVeHB3R0JNUWtz?= =?utf-8?B?bWZVMjB0YVdDZWJjV3B6MlVVd1Bhb2RkR0FPWkdwQmYxMkpHOVVWUHlsdnY3?= =?utf-8?B?YTdEYUhLbGluUmx1QmtXckpUZnpnMnNncXRYUG9OUVBrc0w1aUxKT1dnVVB1?= =?utf-8?B?emNzdDhCeTRJNGhxTzZnR0JhNDJDZmxiajhWaHFsRXd4MFdCKzZOTHV2MW1J?= =?utf-8?B?eGx0dDNKWUVFVlRTQk0wd0dpWUZQV1hGMnEwRHN5VnhHekpHY0hndVgwa0lp?= =?utf-8?B?TWxnOCtqaXQ2V2dzQ29Zb1BJTnVDN3NWVklSYnM5SklzZ0RXcjgxdUxQL2xr?= =?utf-8?B?b3Uwb2RPcGNzdXc4Mk9EQVhHZWpSbnh2cC9jZ1hNczFRajZlQ1VYdXRZekNI?= =?utf-8?B?VjBwNkJYbll0c3hWOE5xV3B5SG9nRjhWQ2tJSzRzaWszRjUwS0xIbkNHcFRF?= =?utf-8?B?T0RFMXN3VnBnSkRncW9FYld2ZlJPK3kvSzlEM1Qrb0NvUFk5aktDK3Fmbkh0?= =?utf-8?B?MVRtQmQvckkrc1VlRWZ0aGlud1V0VHJmUVIxUHBBamVXcm80cnRCRkprS2FL?= =?utf-8?B?a0NUaUlvb0JhaTBHQ0hKeC9rUUNSOUpFZVBibkpWRTFqd0ZueWdQVWdJSUJ3?= =?utf-8?B?YWt1ZkNid1RGT2ZudlI1S1F2eVJna05TTHdaV3pjVGpHNFZPSmpIa1lMOW56?= =?utf-8?B?WUdmUGRKMVRmeDNMakVsS0JxcDVObnRyQlVSc0EzODNLWFBLMnZOeUZINWY0?= =?utf-8?B?RGFCZkRkais4MlAwWTQ3dlBkSGRid3FKM2JPcUQ1bHhlaWFEbkMxNXZ3Q3k3?= =?utf-8?B?SHBodkozaERJMG04SFE2eFF1QjA3NXJrak1DYkFIdU5TYllPM2ZNS05CdVdT?= =?utf-8?B?NFpxdlR1OHlKa1h2WmluVjhVU0Z4RHo2TzRKamplQjV4bnZQTHc1UUNrb2Qv?= =?utf-8?B?TnlQQVN4ZkptV3BBSHpEelU1ekJma2lyK0tSckV0a0NUL0VLMFA4UUF3M29S?= =?utf-8?B?dE5zN21WeGdzVVd4czd3Q1pjWGpVbHdhSmZRdmUyUDlFVHQ0bnQ2bEtEYUVI?= =?utf-8?B?TDdHaS9PMy9PSnMxOHdlTUloREJvMTFaZ2lLVUY3WGlqVkNwTWxROTUxdHVZ?= =?utf-8?B?MXpGV1JvWWUveHQ3N0ppVWNUc1ZNV0pJVW4yWXNKNXBZbGNzVitoUU0xZUJS?= =?utf-8?B?cUkvMnpYTmhzUGRJZGhhUGMxSXcwZDFXYjNMUUlWMDhtbENPT0N6amhieTMw?= =?utf-8?B?eGcyaDErK2x4Q3hOTFNjZnZQWko5Tzkyb3E2Ryt1ZXQyUHdrY2FPRktWTWZZ?= =?utf-8?B?QXdQY2d4OUtzZjZXeDRyL3d4ZnRTeTU5WHhlaEplQWlIL01JMEYrVVliV3pY?= =?utf-8?B?OWlvNXJQQmhxQU9BRThCUkJHQzc2VExVN3MwbTU0c0ZJbFc4bGFYaDBWZ3pz?= =?utf-8?B?aUQ4eS80VFB6a1BWWkdEcDYrektYWlhQc0k5OVZGQWlIdys1ckJ1WEtqZzB4?= =?utf-8?B?RGlQTzlFZ0xuOEh1L3R0OFdKNFVNQU5tRlcvVjVDZnRldEkyRitRRTMyaC9t?= =?utf-8?B?N0phTmh3Vy9oZ2JTNVVPSTZnYTBrWkxwdzZRWC9VaS9oWSt2ZlVoVC8wS0gx?= =?utf-8?B?bUR5clJhZlkvazRZNEdmRlRVeUtCN0NmTEw1QnZWSmc1azliSVFkeE1OdjJp?= =?utf-8?B?b1hFZHY3TE0vYVJlR3dCa0tlcjg4U2hXS0NoRkltZnRibXBLcU1WSWpGcE9M?= =?utf-8?Q?UUVsWzWRxkOqVvaTYA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4123.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MitCSDZuZnZuTTNreDJ0K1BLZUJSbHlXUHR3LzArN2gzUEg0UFZ4ZFB0bzBF?= =?utf-8?B?VkJIbUJET1lqUXJRNndIdk05M29IU2FDTlBsdCtIZjB1d1U4aW5QSXNnOEpP?= =?utf-8?B?bGY5RFBCYzQzK0NsNks3QVdqUy9WNzB4YmpmdmpLRFVsVndGUDR5NkV3SXIw?= =?utf-8?B?cXVzdFZkZ1lsMVRWS0tnQ3dFNWRyYVA2NE0zOVNwSHFmemJWYTZzZ1RvYVdo?= =?utf-8?B?cUZoYVNrL0JRNGJ2My9WU2JTL05sRFpKUG50Q1JubHdIeWpjZURmV0FrWWE2?= =?utf-8?B?RWVFT3dEZy9XL0d3QnVYdFRZbXNJZC9IMjVpc0ZzeWpsQ0xNMXh2UXZMbncr?= =?utf-8?B?QlYzc2k0RytxZFRjUTJycUM1Zm9TdnJPY21ZdGNyeXFYOG9FMG1TM2FqTHox?= =?utf-8?B?SUYyckVZRWYyamNXb0NhcDhpem5TNlV6YWc2OUF2VXh1U2h6aUNvc2ZQLzNN?= =?utf-8?B?NVR0dVNFYXJvMlVUUlJSVDltUmVvaTFsbEorNzI5VnB6YmI2L0NxVnJWU1gw?= =?utf-8?B?eTVNdGtOR0QrVGdra2FSK2ptbDlTNFF6VGdxSDZKV0FjWHh4eFNIbXRBMU56?= =?utf-8?B?cFZyUG9KczM5Q1ArNXBFeTdMcTFaSDZST1EzYlphWnczZFNzQWJBYkZzOVFy?= =?utf-8?B?MU9IVnJDRU1Mai9wZDNQaW1VbXFiY1k1MGxqVEo5MUg3dk8wbjZOUEZSMDla?= =?utf-8?B?Qy9qWEYvdS81N2dSRjcwbUtwak9uSnVyR3RUK1VpSXhCeHdTaUdjMVN4WlN0?= =?utf-8?B?NzVrNDZucmlVeVVVZTNaN1B1VUhCLzhmZmgzcHUxRXZYa1dHNkRDdUgxaExN?= =?utf-8?B?aG1PRlRJYTZzaDJzS3o2d01Ham1XMXZEVTNIVllqeWQyK0lOZHR1L3ZTSFVv?= =?utf-8?B?K3E0bjMzL21mb0MwWThjUzNOOE9wZ0xTZ0g0VTVHREdhdjduUVNEOFdpenhr?= =?utf-8?B?aUhPUDVWSVdPNTFZb0hzMWNxSGtWbmJvY0lMQzlBNlRsWTJLU2pndmtYdnpm?= =?utf-8?B?TzVCSkM3L3NibitCNzJUTWNLTEdNNVlKb2NQOXFjdkhZS3BWQWpqVDRaemJn?= =?utf-8?B?VTQ1cUhNNHJvb25YR2pPNUVvYWxkNEhNVDZ2amI0WlhvUndCS0VtU21QK3Bl?= =?utf-8?B?NUtkRWlJOTZCcklUeHRMVkM1ZmUzdHp0VGY1N2ZzVE8rUjhteUlNSk5KekFV?= =?utf-8?B?Zmw3R0Y1TmRjbmU1Yk1nTXhZUHlZd3k3Z0kwNkdkTmNJNk1GSkE4VEdRb0Ri?= =?utf-8?B?U0xqNW5GOGFFZ0dnbmtHOHdpZXFrVHpHK2thU2doRDZHK00yODBVM2c2dTdv?= =?utf-8?B?RnBSei9zbFJxRFU1cHJjQTB6V1dxUWp3c3JFc1lBQVRjQVNGR1hOVjFxdEZv?= =?utf-8?B?bUduejZpdkhVVnlnOFdDbnA2czdIR0xMRFN6c1NBMHJ3ZktEQjZadUNtNCtt?= =?utf-8?B?U3RidHpKb2pTVTd4Umloei9Ia1E5elZtRnM3dElNTHFPc3dGT25sWEJ0RHlq?= =?utf-8?B?dWNJUE9oTUdEeXhLRkRhRlk4Y3pFT0w0L0lURG9URlAzUUFZa0dIdC9vUFdK?= =?utf-8?B?R0wvY25SQS9jVHY1ZjdZVFNyQ3cxZ2pkd2JXR20yYnRCZVdaSmcvNlZWU0t6?= =?utf-8?B?ckhuT2doZW51bFp3am9keUh4Q2hETTJRdnhsblFWYWFqZkJ3R084MHFMRjVC?= =?utf-8?B?SU8rNjJ2RlFONDRHN3pnTTNvVmVGREMwVG93c1JRNk5US1ZRQTlTMDg2RGpJ?= =?utf-8?B?ZlZuYXlJcmxHQlN3NXprUUxwM20xZWFJYjcrRE5IVHBIRTJZakRpZXNNelhR?= =?utf-8?B?Nzc5UVFySi9XSldKdlBSejB2ZHRDTTJ1TW84eFZidDU5M0JOS1FTUStvQklR?= =?utf-8?B?djI4cWM5S05BZ3BOVHRickFKWmd2T0VGOHRJY1JvUkJTaERUcjlUdkhFN1d0?= =?utf-8?B?ejkwTkpqQm9ORDhuN2EvSFFMK0FJODZjSmlCbXVLUWtZT1B4VU9jTko2MXVC?= =?utf-8?B?VXNYeGpzNGptUzNFZ3JJU1JkQmprODRyOHg0Mlp5RFRWVnBHamU2dFBuWnNz?= =?utf-8?B?SURhTEhCODFWV1hXQkRjWjVvbHdhd3hOVnNIRC9UODFDeWVWN3JBVDAydGpN?= =?utf-8?Q?wnUb0vNCo0qs1oPxiQ0nhZX8g?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5cc0778-7f5b-451b-e3d6-08dcb8172048 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2024 02:01:04.6775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dMWCtuPv74+uKwF/1dk82zj9Yccjay1ynIYgqkjJfLKkJpV+RH3wnTb3OHeZaolP6FH/B34HM8V5XD9m9ar46w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5598 On 09/08/24 01:02, Mark Brown wrote: > On Wed, Aug 07, 2024 at 10:43:14AM +0530, Vijendar Mukunda wrote: >> Fix the incorrect register offsets for acp error reason registers. >> Add 'acp_sw0_i2s_err_reason' as register field in acp descriptor structure >> and update the value based on the acp variant. >> ACP_SW1_ERROR_REASON register was added from Rembrandt platform onwards. >> Add conditional check for the same. >> >> Fixes: 96eb81851012 ("ASoC: SOF: amd: add interrupt handling for SoundWire manager devices") > This breaks an x86 allmodconfig build: > > /build/stage/linux/sound/soc/sof/amd/acp.c: In function ‘acp_irq_handler’: > /build/stage/linux/sound/soc/sof/amd/acp.c:407:26: error: ‘struct acp_dev_data’ h > as no member named ‘pci_rev’ > 407 | if (adata->pci_rev >= ACP_RMB_PCI_ID) > | ^~ This patch is part of https://github.com/thesofproject/linux/pull/5103 which got successfully merged into sof github without any build errors. This patch is dependent on Link: https://patch.msgid.link/20240801111821.18076-10-Vijendar.Mukunda@amd.com which got already merged in to ASoC tree for-next base. It shouldn't cause build error if the dependent patch already merged. > /build/stage/linux/sound/soc/sof/amd/acp.c: In function ‘acp_power_on’: > /build/stage/linux/sound/soc/sof/amd/acp.c:444:22: error: ‘struct acp_dev_data’ h > as no member named ‘pci_rev’ > 444 | switch (adata->pci_rev) { > | ^~